Skip to content

Conversation

@radzserg
Copy link

@radzserg radzserg commented Apr 3, 2025

Description

This PR bumps the libpg_query submodule to the latest commit on the 17-latest branch:
pganalyze/libpg_query@1c1a32e

Key change:

  • Adds proper support for macOS 15.4+, which now includes strchrnul in the standard library.
  • Fixes build failures on up-to-date macOS environments (tested on macOS 15.4, where the build previously failed due to a symbol conflict).

@emieljanson
Copy link

Would be sweet to get this merged.

@pcnc
Copy link

pcnc commented Apr 14, 2025

Could we remove .idea/workspace.xml? Seems superfluous.

@mufeez-amjad
Copy link

Mentioning #88 here, since it will be fixed with this PR.

@pyramation pyramation changed the base branch from 16-latest to 17-latest April 15, 2025 03:16
@pyramation
Copy link
Collaborator

Thanks for the update here! I'll make a new branch 17-latest for this to keep in step with the branch naming convention.

@pyramation pyramation merged commit fd94d30 into launchql:17-latest Apr 15, 2025
3 checks passed
@pyramation
Copy link
Collaborator

let's follow this branch and make PRs into this from here https://github.com/launchql/libpg-query-node/tree/17-latest

@pyramation
Copy link
Collaborator

pyramation commented Apr 15, 2025

@radzserg @emieljanson @pcnc @mufeez-amjad — my GitHub notifications are a bit noisy, so feel free to ping me in the LaunchQL Telegram group if any PRs need urgent merging:

https://t.me/launchql

can you guys test this out? https://www.npmjs.com/package/libpg-query/v/17.0.0

@radzserg
Copy link
Author

Thanks for merging. Sorry missed .idea file. Was late night commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants