Merge branch 'main' into pg/create-view-281

Author: pyramation

AGENTS.md

@@ -132,6 +132,7 @@ await deparse(stmt);
 | [**@pgsql/cli**](./packages/pgsql-cli) | Unified CLI for all PostgreSQL AST operations | • Parse SQL to AST<br>• Deparse AST to SQL<br>• Generate TypeScript from protobuf<br>• Single tool for all operations |
 | [**@pgsql/utils**](./packages/utils) | Type-safe AST node creation utilities | • Programmatic AST construction<br>• Runtime Schema<br>• Seamless integration with types |
 | [**pg-proto-parser**](./packages/proto-parser) | PostgreSQL protobuf parser and code generator | • Generate TypeScript interfaces from protobuf<br>• Create enum mappings and utilities<br>• AST helper generation |
+| [**@pgsql/transform**](./packages/transform) | Multi-version PostgreSQL AST transformer | • Transform ASTs between PostgreSQL versions (13→17)<br>• Single source of truth deparser pipeline<br>• Backward compatibility for legacy SQL |
 
 
 ## 🛠️ Development
@@ -232,4 +233,4 @@ console.log(await deparse(query));
 
 AS DESCRIBED IN THE LICENSES, THE SOFTWARE IS PROVIDED "AS IS", AT YOUR OWN RISK, AND WITHOUT WARRANTIES OF ANY KIND.
 
-No developer or entity involved in creating Software will be liable for any claims or damages whatsoever associated with your use, inability to use, or your interaction with other users of the Software code or Software CLI, including any direct, indirect, incidental, special, exemplary, punitive or consequential damages, or loss of profits, cryptocurrencies, tokens, or anything else of value.
+No developer or entity involved in creating Software will be liable for any claims or damages whatsoever associated with your use, inability to use, or your interaction with other users of the Software code or Software CLI, including any direct, indirect, incidental, special, exemplary, punitive or consequential damages, or loss of profits, cryptocurrencies, tokens, or anything else of value.

README.md

@@ -21619,7 +21619,7 @@
   "latest/postgres/create_view-278.sql": "select pg_get_viewdef('tt19v', true)",
   "latest/postgres/create_view-279.sql": "create view tt20v as\nselect * from\n  coalesce(1,2) as c,\n  collation for ('x'::text) col,\n  current_date as d,\n  localtimestamp(3) as t,\n  cast(1+2 as int4) as i4,\n  cast(1+2 as int8) as i8",
   "latest/postgres/create_view-280.sql": "select pg_get_viewdef('tt20v', true)",
-  "latest/postgres/create_view-281.sql": "create view tt201v as\nselect\n  ('2022-12-01'::date + '1 day'::interval) at time zone 'UTC' as atz,\n  extract(day from now()) as extr,\n  (now(), '1 day'::interval) overlaps\n    (current_timestamp(2), '1 day'::interval) as o,\n  'foo' is normalized isn,\n  'foo' is nfkc normalized isnn,\n  normalize('foo') as n,\n  normalize('foo', nfkd) as nfkd,\n  overlay('foo' placing 'bar' from 2) as ovl,\n  overlay('foo' placing 'bar' from 2 for 3) as ovl2,\n  position('foo' in 'foobar') as p,\n  substring('foo' from 2 for 3) as s,\n  substring('foo' similar 'f' escape '#') as ss,\n  substring('foo' from 'oo') as ssf,  -- historically-permitted abuse\n  trim(' ' from ' foo ') as bt,\n  trim(leading ' ' from ' foo ') as lt,\n  trim(trailing ' foo ') as rt,\n  trim(E'\\\\000'::bytea from E'\\\\000Tom\\\\000'::bytea) as btb,\n  trim(leading E'\\\\000'::bytea from E'\\\\000Tom\\\\000'::bytea) as ltb,\n  trim(trailing E'\\\\000'::bytea from E'\\\\000Tom\\\\000'::bytea) as rtb,\n  CURRENT_DATE as cd,\n  (select * from CURRENT_DATE) as cd2,\n  CURRENT_TIME as ct,\n  (select * from CURRENT_TIME) as ct2,\n  CURRENT_TIME (1) as ct3,\n  (select * from CURRENT_TIME (1)) as ct4,\n  CURRENT_TIMESTAMP as ct5,\n  (select * from CURRENT_TIMESTAMP) as ct6,\n  CURRENT_TIMESTAMP (1) as ct7,\n  (select * from CURRENT_TIMESTAMP (1)) as ct8,\n  LOCALTIME as lt1,\n  (select * from LOCALTIME) as lt2,\n  LOCALTIME (1) as lt3,\n  (select * from LOCALTIME (1)) as lt4,\n  LOCALTIMESTAMP as lt5,\n  (select * from LOCALTIMESTAMP) as lt6,\n  LOCALTIMESTAMP (1) as lt7,\n  (select * from LOCALTIMESTAMP (1)) as lt8,\n  CURRENT_CATALOG as ca,\n  (select * from CURRENT_CATALOG) as ca2,\n  CURRENT_ROLE as cr,\n  (select * from CURRENT_ROLE) as cr2,\n  CURRENT_SCHEMA as cs,\n  (select * from CURRENT_SCHEMA) as cs2,\n  CURRENT_USER as cu,\n  (select * from CURRENT_USER) as cu2,\n  USER as us,\n  (select * from USER) as us2,\n  SESSION_USER seu,\n  (select * from SESSION_USER) as seu2,\n  SYSTEM_USER as su,\n  (select * from SYSTEM_USER) as su2",
+  "latest/postgres/create_view-281.sql": "create view tt201v as\nselect\n  ('2022-12-01'::date + '1 day'::interval) at time zone 'UTC' as atz,\n  extract(day from now()) as extr,\n  (now(), '1 day'::interval) overlaps\n    (current_timestamp(2), '1 day'::interval) as o,\n  'foo' is normalized isn,\n  'foo' is nfkc normalized isnn,\n  normalize('foo') as n,\n  normalize('foo', nfkd) as nfkd,\n  overlay('foo' placing 'bar' from 2) as ovl,\n  overlay('foo' placing 'bar' from 2 for 3) as ovl2,\n  position('foo' in 'foobar') as p,\n  substring('foo' from 2 for 3) as s,\n  substring('foo' from '%o%') as ss,  -- if you're extracting using a pattern  \n  substring('foo' from 'oo') as ssf,  -- historically-permitted abuse\n  trim(' ' from ' foo ') as bt,\n  trim(leading ' ' from ' foo ') as lt,\n  trim(trailing ' foo ') as rt,\n  trim(E'\\\\000'::bytea from E'\\\\000Tom\\\\000'::bytea) as btb,\n  trim(leading E'\\\\000'::bytea from E'\\\\000Tom\\\\000'::bytea) as ltb,\n  trim(trailing E'\\\\000'::bytea from E'\\\\000Tom\\\\000'::bytea) as rtb,\n  CURRENT_DATE as cd,\n  (select * from CURRENT_DATE) as cd2,\n  CURRENT_TIME as ct,\n  (select * from CURRENT_TIME) as ct2,\n  CURRENT_TIME (1) as ct3,\n  (select * from CURRENT_TIME (1)) as ct4,\n  CURRENT_TIMESTAMP as ct5,\n  (select * from CURRENT_TIMESTAMP) as ct6,\n  CURRENT_TIMESTAMP (1) as ct7,\n  (select * from CURRENT_TIMESTAMP (1)) as ct8,\n  LOCALTIME as lt1,\n  (select * from LOCALTIME) as lt2,\n  LOCALTIME (1) as lt3,\n  (select * from LOCALTIME (1)) as lt4,\n  LOCALTIMESTAMP as lt5,\n  (select * from LOCALTIMESTAMP) as lt6,\n  LOCALTIMESTAMP (1) as lt7,\n  (select * from LOCALTIMESTAMP (1)) as lt8,\n  CURRENT_CATALOG as ca,\n  (select * from CURRENT_CATALOG) as ca2,\n  CURRENT_ROLE as cr,\n  (select * from CURRENT_ROLE) as cr2,\n  CURRENT_SCHEMA as cs,\n  (select * from CURRENT_SCHEMA) as cs2,\n  CURRENT_USER as cu,\n  (select * from CURRENT_USER) as cu2,\n  USER as us,\n  (select * from USER) as us2,\n  SESSION_USER seu,\n  (select * from SESSION_USER) as seu2,\n  SYSTEM_USER as su,\n  (select * from SYSTEM_USER) as su2",
   "latest/postgres/create_view-282.sql": "select pg_get_viewdef('tt201v', true)",
   "latest/postgres/create_view-283.sql": "create view tt21v as\nselect * from tt5 natural inner join tt6",
   "latest/postgres/create_view-284.sql": "select pg_get_viewdef('tt21v', true)",

__fixtures__/generated/generated.json

@@ -686,7 +686,7 @@ select
   overlay('foo' placing 'bar' from 2 for 3) as ovl2,
   position('foo' in 'foobar') as p,
   substring('foo' from 2 for 3) as s,
-  substring('foo' similar 'f' escape '#') as ss,
+  substring('foo' from '%o%') as ss,  -- if you're extracting using a pattern  
   substring('foo' from 'oo') as ssf,  -- historically-permitted abuse
   trim(' ' from ' foo ') as bt,
   trim(leading ' ' from ' foo ') as lt,

__fixtures__/kitchen-sink/latest/postgres/create_view.sql

@@ -731,7 +731,7 @@ select
   overlay('foo' placing 'bar' from 2 for 3) as ovl2,
   position('foo' in 'foobar') as p,
   substring('foo' from 2 for 3) as s,
-  substring('foo' similar 'f' escape '#') as ss,
+  substring('foo' from '%o%') as ss,  -- if you're extracting using a pattern
   substring('foo' from 'oo') as ssf,  -- historically-permitted abuse
   trim(' ' from ' foo ') as bt,
   trim(leading ' ' from ' foo ') as lt,

__fixtures__/postgres/create_view.sql

@@ -0,0 +1,29 @@
+## Custom testing strategy
+
+Parse the any deparsed or pretty-formatted SQL back and verify the AST matches the original. This ensures the formatting doesn't break the SQL semantics.
+
+Please review the test utilities — note that exact SQL string equality is not required. The focus is on comparing the resulting ASTs.
+
+Refer to `expectAstMatch` to understand how correctness is validated.
+
+The pipeline is:
+parse(sql1) → ast → deparse(ast) → sql2
+While sql2 !== sql1 (textually), a correct round-trip means:
+parse(sql1) === parse(sql2) (AST-level equality).
+
+You can see `expectAstMatch` here: packages/deparser/test-utils/index.ts
+
+## Testing Process & Workflow
+
+**Our systematic approach to fixing deparser issues:**
+
+1. **One test at a time**: Focus on individual failing tests using `yarn test --testNamePattern="specific-test"`
+2. **Always check for regressions**: After each fix, run full `yarn test` to ensure no previously passing tests broke
+3. **Track progress**: Update this file with current pass/fail counts after each significant change
+4. **Build before testing**: Always run `yarn build` after code changes before testing
+5. **Clean commits**: Stage files explicitly with `git add <file>`, never use `git add .`
+6. **Tight feedback loops**: Use isolated debug scripts for complex issues, but don't commit them
+
+**Workflow**: Make changes → `yarn test --testNamePattern="target-test"` → `yarn test` (check regressions) → Update this file → Commit & push
+
+**When committing to TESTS.md, always run all tests — do not use testNamePattern, only `yarn test`**