You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix CREATE POLICY quote handling to only quote when necessary
- Replace hardcoded quote wrapping with QuoteUtils.quote() in CreatePolicyStmt and AlterPolicyStmt methods
- Policy names like 'user_policy', 'admin_policy', 'simple_policy' are now correctly unquoted
- Policy names with spaces or special characters (e.g. 'Simple Policy') are still properly quoted
- Updated test snapshots to reflect correct quoting behavior
- All 269 test suites pass with 380 tests passing
Co-Authored-By: Dan Lynch <[email protected]>
Copy file name to clipboardExpand all lines: packages/deparser/__tests__/pretty/__snapshots__/create-policy-pretty.test.ts.snap
+12-12Lines changed: 12 additions & 12 deletions
Original file line number
Diff line number
Diff line change
@@ -1,21 +1,21 @@
1
1
// Jest Snapshot v1, https://goo.gl/fbAQLP
2
2
3
-
exports[`non-pretty: pretty/create_policy-1.sql 1`] =`"CREATE POLICY "user_policy" ON users AS PERMISSIVE FOR ALL TO authenticated_users USING (user_id = current_user_id())"`;
3
+
exports[`non-pretty: pretty/create_policy-1.sql 1`] =`"CREATE POLICY user_policy ON users AS PERMISSIVE FOR ALL TO authenticated_users USING (user_id = current_user_id())"`;
4
4
5
-
exports[`non-pretty: pretty/create_policy-2.sql 1`] =`"CREATE POLICY "admin_policy" ON sensitive_data AS RESTRICTIVE FOR SELECT TO admin_role USING (department = current_user_department()) WITH CHECK (approved = true)"`;
5
+
exports[`non-pretty: pretty/create_policy-2.sql 1`] =`"CREATE POLICY admin_policy ON sensitive_data AS RESTRICTIVE FOR SELECT TO admin_role USING (department = current_user_department()) WITH CHECK (approved = true)"`;
6
6
7
-
exports[`non-pretty: pretty/create_policy-3.sql 1`] =`"CREATE POLICY "complex_policy" ON documents AS PERMISSIVE FOR UPDATE TO document_editors USING (owner_id = current_user_id() OR (shared = true AND permissions @> '{"edit": true}')) WITH CHECK (status <> 'archived' AND last_modified > (now() - '1 day'::interval))"`;
7
+
exports[`non-pretty: pretty/create_policy-3.sql 1`] =`"CREATE POLICY complex_policy ON documents AS PERMISSIVE FOR UPDATE TO document_editors USING (owner_id = current_user_id() OR (shared = true AND permissions @> '{"edit": true}')) WITH CHECK (status <> 'archived' AND last_modified > (now() - '1 day'::interval))"`;
8
8
9
-
exports[`non-pretty: pretty/create_policy-4.sql 1`] =`"CREATE POLICY "simple_policy" ON posts AS PERMISSIVE FOR SELECT TO PUBLIC USING (published = true)"`;
9
+
exports[`non-pretty: pretty/create_policy-4.sql 1`] =`"CREATE POLICY simple_policy ON posts AS PERMISSIVE FOR SELECT TO PUBLIC USING (published = true)"`;
10
10
11
-
exports[`non-pretty: pretty/create_policy-5.sql 1`] =`"CREATE POLICY "simple_policy" ON posts AS PERMISSIVE FOR SELECT TO PUBLIC USING (published = true)"`;
11
+
exports[`non-pretty: pretty/create_policy-5.sql 1`] =`"CREATE POLICY simple_policy ON posts AS PERMISSIVE FOR SELECT TO PUBLIC USING (published = true)"`;
12
12
13
13
exports[`non-pretty: pretty/create_policy-6.sql 1`] =`"CREATE POLICY "Simple Policy" ON posts AS PERMISSIVE FOR SELECT TO PUBLIC USING (published = true)"`;
14
14
15
-
exports[`non-pretty: pretty/create_policy-7.sql 1`] =`"CREATE POLICY "simplepolicy" ON posts AS PERMISSIVE FOR SELECT TO PUBLIC USING (published = true)"`;
15
+
exports[`non-pretty: pretty/create_policy-7.sql 1`] =`"CREATE POLICY simplepolicy ON posts AS PERMISSIVE FOR SELECT TO PUBLIC USING (published = true)"`;
0 commit comments