types

Author: pyramation

__fixtures__/transform/generation-summary.json

@@ -1,5 +1,5 @@
 {
-  "generated": "2025-06-24T09:08:18.532Z",
+  "generated": "2025-06-25T03:21:32.829Z",
   "versions": [
     13,
     14,

packages/transform/AST_PLAN.md

@@ -16,7 +16,7 @@ We have implemented a series of AST transformers that can upgrade ASTs sequentia
 
 The approach will be functional and composable, allowing us to chain transformations to go from any older version to version 17.
 
-## Phase 1: Generate Example ASTs (Current Task)
+## Phase 1: Generate Example ASTs ✅ COMPLETED
 
 ### Directory Structure
 ```
@@ -54,6 +54,20 @@ We'll use these SQL queries to generate ASTs for each version:
 7. **alter_table.json**: `ALTER TABLE users ADD COLUMN email TEXT`
 8. **complex_query.json**: A more complex query with CTEs, window functions, etc.
 
+### Generated Fixtures
+
+The AST fixtures have been successfully generated in `__fixtures__/transform/` with the following structure:
+
+- Each version (13-17) has its own directory
+- Each directory contains 8 JSON files with ASTs for the test queries
+- The script used: `packages/transform/scripts/generate-ast-fixtures.js`
+- Generation summary available at: `__fixtures__/transform/generation-summary.json`
+
+These fixtures now serve as the foundation for:
+1. Understanding AST differences between versions
+2. Testing our transformation logic
+3. Validating that transformations preserve semantic meaning
+
 ## Phase 2: Implement Core Transformation Infrastructure
 
 ### Base Types and Interfaces
@@ -153,7 +167,7 @@ Key changes:
 
 ## Implementation Order
 
-1. **Step 0** (Current): Generate example ASTs for testing
+1. **Step 0** ✅ COMPLETED: Generate example ASTs for testing
 2. **Step 1**: Build core infrastructure and base types
 3. **Step 2**: Implement 14→15 transformer (most critical due to enum format change)
 4. **Step 3**: Implement 13→14 transformer

packages/transform/src/transformers/v14-to-v15.ts

@@ -1,6 +1,10 @@
 import { BaseTransformer, TransformerContext } from '../visitors/base';
-import { Node as PG14Node } from '../14/types';
-import { Node as PG15Node } from '../15/types';
+import * as PG14 from '../14/types';
+import * as PG15 from '../15/types';
+
+// Note: We use 'any' for some node types because the generated types don't accurately
+// reflect the actual parser output. For example, A_Const.val is typed as generic 'Node'
+// but actually contains specific node types like String, Integer, Float, etc.
 
 export class V14ToV15Transformer extends BaseTransformer {
   transform(node: any, context?: TransformerContext): any {
@@ -23,6 +27,7 @@ export class V14ToV15Transformer extends BaseTransformer {
   }
 
   A_Const(nodeData: any, context?: TransformerContext): any {
+    // Using 'any' because PG14.A_Const.val is typed as generic Node but contains specific types
     const transformedData: any = { ...nodeData };
 
     if (nodeData.val) {
@@ -64,6 +69,7 @@ export class V14ToV15Transformer extends BaseTransformer {
   }
 
   String(node: any, context?: TransformerContext): any {
+    // String node transformation: str -> sval
     const transformedData = { ...node };
 
     if ('str' in transformedData) {
@@ -75,6 +81,7 @@ export class V14ToV15Transformer extends BaseTransformer {
   }
 
   BitString(node: any, context?: TransformerContext): any {
+    // BitString node transformation: str -> bsval
     const transformedData = { ...node };
 
     if ('str' in transformedData) {
@@ -86,6 +93,7 @@ export class V14ToV15Transformer extends BaseTransformer {
   }
 
   Float(node: any, context?: TransformerContext): any {
+    // Float node transformation: str -> fval
     const transformedData = { ...node };
 
     if ('str' in transformedData) {
@@ -97,6 +105,7 @@ export class V14ToV15Transformer extends BaseTransformer {
   }
 
   AlterPublicationStmt(node: any, context?: TransformerContext): any {
+    // AlterPublicationStmt: tables -> pubobjects, tableAction -> action
     const transformedData = { ...node };
 
     if ('tables' in transformedData) {
@@ -112,6 +121,7 @@ export class V14ToV15Transformer extends BaseTransformer {
   }
 
   CreatePublicationStmt(node: any, context?: TransformerContext): any {
+    // CreatePublicationStmt: transform tables array to pubobjects with PublicationObjSpec
     const transformedData = { ...node };
 
     if ('tables' in transformedData && Array.isArray(transformedData.tables)) {
@@ -141,7 +151,7 @@ export class V14ToV15Transformer extends BaseTransformer {
     return transformedData;
   }
 
-  FuncCall(node: any, context?: TransformerContext): any {
+  FuncCall(node: PG14.FuncCall, context?: TransformerContext): any {
     const transformedData = { ...node };
 
     if (!('funcformat' in transformedData)) {
@@ -181,7 +191,7 @@ export class V14ToV15Transformer extends BaseTransformer {
     return transformedData;
   }
 
-  ColumnRef(node: any, context?: TransformerContext): any {
+  ColumnRef(node: PG14.ColumnRef, context?: TransformerContext): any {
     const transformedData = { ...node };
 
     if (transformedData.fields && Array.isArray(transformedData.fields)) {
@@ -191,7 +201,7 @@ export class V14ToV15Transformer extends BaseTransformer {
     return transformedData;
   }
 
-  WindowDef(node: any, context?: TransformerContext): any {
+  WindowDef(node: PG14.WindowDef, context?: TransformerContext): any {
     const transformedData = { ...node };
 
     if (!('frameOptions' in transformedData)) {
@@ -213,6 +223,7 @@ export class V14ToV15Transformer extends BaseTransformer {
   }
 
   SelectStmt(nodeData: any, context?: TransformerContext): any {
+    // SelectStmt: handle limitOption and op defaults, orderClause -> sortClause in some contexts
     const transformedData: any = {};
 
     for (const [key, value] of Object.entries(nodeData)) {
@@ -289,7 +300,7 @@ export class V14ToV15Transformer extends BaseTransformer {
 
 
 
-  Integer(node: any, context?: TransformerContext): any {
+  Integer(node: PG14.Integer, context?: TransformerContext): any {
     const transformedData = { ...node };
 
     if (!('ival' in transformedData)) {
@@ -300,6 +311,7 @@ export class V14ToV15Transformer extends BaseTransformer {
   }
 
   DefElem(node: any, context?: TransformerContext): any {
+    // DefElem: convert Integer(0/1) to Boolean for 'strict' and 'cycle' definitions
     const transformedData = { ...node };
 
     if (transformedData.arg && transformedData.arg.Integer && (transformedData.defname === 'strict' || transformedData.defname === 'cycle')) {
@@ -326,7 +338,7 @@ export class V14ToV15Transformer extends BaseTransformer {
     return transformedData;
   }
 
-  RangeVar(node: any, context?: TransformerContext): any {
+  RangeVar(node: PG14.RangeVar, context?: TransformerContext): any {
     return node;
   }
 }

packages/transform/src/transformers/v15-to-v16.ts

@@ -1,6 +1,10 @@
 import { BaseTransformer, TransformerContext } from '../visitors/base';
-import { Node as PG15Node } from '../15/types';
-import { Node as PG16Node } from '../16/types';
+import * as PG15 from '../15/types';
+import * as PG16 from '../16/types';
+
+// Note: We use 'any' for some node types because the generated types don't accurately
+// reflect the actual parser output structure, particularly for fields that exist in
+// the parser output but not in the generated types.
 
 export class V15ToV16Transformer extends BaseTransformer {
   transform(node: any, context?: TransformerContext): any {
@@ -25,6 +29,7 @@ export class V15ToV16Transformer extends BaseTransformer {
 
 
   SelectStmt(nodeData: any, context?: TransformerContext): any {
+    // SelectStmt: handle limitOption and op defaults
     const transformedData: any = {};
 
     for (const [key, value] of Object.entries(nodeData)) {
@@ -93,15 +98,15 @@ export class V15ToV16Transformer extends BaseTransformer {
 
 
 
-  Var(node: any, context?: TransformerContext): any {
+  Var(node: PG15.Var, context?: TransformerContext): any {
     return node;
   }
 
-  Aggref(node: any, context?: TransformerContext): any {
+  Aggref(node: PG15.Aggref, context?: TransformerContext): any {
     return node;
   }
 
-  Integer(node: any, context?: TransformerContext): any {
+  Integer(node: PG15.Integer, context?: TransformerContext): any {
     const transformedData = { ...node };
 
     if (!('ival' in transformedData)) {

packages/transform/src/transformers/v16-to-v17.ts

@@ -1,6 +1,6 @@
 import { BaseTransformer, TransformerContext } from '../visitors/base';
-import { Node as PG16Node } from '../16/types';
-import { Node as PG17Node } from '../17/types';
+import * as PG16 from '../16/types';
+import * as PG17 from '../17/types';
 
 export class V16ToV17Transformer extends BaseTransformer {
   transform(node: any, context?: TransformerContext): any {