Implement strict INSERT INTO ... VALUES formatting for pretty printing

- Fix VALUES formatting to avoid corrupting string literals with escape sequences
- Use containsMultilineStringLiteral() to preserve original string content
- Column lists always wrapped in parentheses across multiple lines
- VALUES keyword always on its own line
- Each tuple indented by two spaces
- Preserve quoted identifiers and schema names exactly
- Update casing-pretty.test.ts snapshots with new formatting rules

Co-Authored-By: Dan Lynch <[email protected]>

Author: pyramation

packages/deparser/__tests__/pretty/__snapshots__/casing-pretty.test.ts.snap

@@ -65,63 +65,91 @@ exports[`non-pretty: pretty/casing-31.sql 1`] = `"SELECT "HandleInsert"('TYPE_A'
 exports[`non-pretty: pretty/casing-32.sql 1`] = `"SELECT * FROM "dataPoints""`;
 
 exports[`pretty: pretty/casing-1.sql 1`] = `
-"INSERT INTO users (name) VALUES
-('John Doe')"
+"INSERT INTO users (
+  name
+) VALUES
+  ('John Doe')"
 `;
 
 exports[`pretty: pretty/casing-2.sql 1`] = `
-"INSERT INTO users (name) VALUES
-('ADMINISTRATOR')"
+"INSERT INTO users (
+  name
+) VALUES
+  ('ADMINISTRATOR')"
 `;
 
 exports[`pretty: pretty/casing-3.sql 1`] = `
-"INSERT INTO users (name) VALUES
-('lowercase')"
+"INSERT INTO users (
+  name
+) VALUES
+  ('lowercase')"
 `;
 
 exports[`pretty: pretty/casing-4.sql 1`] = `
-"INSERT INTO users (name) VALUES
-('camelCaseString')"
+"INSERT INTO users (
+  name
+) VALUES
+  ('camelCaseString')"
 `;
 
 exports[`pretty: pretty/casing-5.sql 1`] = `
-"INSERT INTO users (name) VALUES
-('snake_case_string')"
+"INSERT INTO users (
+  name
+) VALUES
+  ('snake_case_string')"
 `;
 
 exports[`pretty: pretty/casing-6.sql 1`] = `
-"INSERT INTO users (name) VALUES
-('kebab-case-value')"
+"INSERT INTO users (
+  name
+) VALUES
+  ('kebab-case-value')"
 `;
 
 exports[`pretty: pretty/casing-7.sql 1`] = `
-"INSERT INTO data.snapshots (metadata) VALUES
-('{"Type": "Full", "Status": "OK"}')"
+"INSERT INTO data.snapshots (
+  metadata
+) VALUES
+  ('{"Type": "Full", "Status": "OK"}')"
 `;
 
 exports[`pretty: pretty/casing-8.sql 1`] = `
-"INSERT INTO "AppSchema"."User Data" ("Full Name") VALUES
-('Jane Smith')"
+"INSERT INTO "AppSchema"."User Data" (
+  "Full Name"
+) VALUES
+  ('Jane Smith')"
 `;
 
 exports[`pretty: pretty/casing-9.sql 1`] = `
-"INSERT INTO logtable (message) VALUES
-('Init'), ('Reboot'), ('ERROR'), ('Warning'), ('info')"
+"INSERT INTO logtable (
+  message
+) VALUES
+  ('Init'),
+  ('Reboot'),
+  ('ERROR'),
+  ('Warning'),
+  ('info')"
 `;
 
 exports[`pretty: pretty/casing-10.sql 1`] = `
-"INSERT INTO metrics.logs (message) VALUES
-('NOW()')"
+"INSERT INTO metrics.logs (
+  message
+) VALUES
+  ('NOW()')"
 `;
 
 exports[`pretty: pretty/casing-11.sql 1`] = `
-"INSERT INTO users (name) VALUES
-('SELECT')"
+"INSERT INTO users (
+  name
+) VALUES
+  ('SELECT')"
 `;
 
 exports[`pretty: pretty/casing-12.sql 1`] = `
-"INSERT INTO users (name) VALUES
-('[email protected]')"
+"INSERT INTO users (
+  name
+) VALUES
+  ('[email protected]')"
 `;
 
 exports[`pretty: pretty/casing-13.sql 1`] = `"SELECT 'MixedCase'"`;

packages/deparser/src/deparser.ts

@@ -438,12 +438,27 @@ export class Deparser implements DeparserVisitor {
     }
 
     if (node.valuesLists) {
-      output.push('VALUES');
-      const lists = ListUtils.unwrapList(node.valuesLists).map(list => {
-        const values = ListUtils.unwrapList(list).map(val => this.visit(val as Node, context));
-        return this.formatter.parens(values.join(', '));
-      });
-      output.push(lists.join(', '));
+      if (this.formatter.isPretty()) {
+        output.push('VALUES');
+        const lists = ListUtils.unwrapList(node.valuesLists).map(list => {
+          const values = ListUtils.unwrapList(list).map(val => this.visit(val as Node, context));
+          return this.formatter.parens(values.join(', '));
+        });
+        const indentedTuples = lists.map(tuple => {
+          if (this.containsMultilineStringLiteral(tuple)) {
+            return tuple;
+          }
+          return this.formatter.indent(tuple);
+        });
+        output.push(indentedTuples.join(',\n'));
+      } else {
+        output.push('VALUES');
+        const lists = ListUtils.unwrapList(node.valuesLists).map(list => {
+          const values = ListUtils.unwrapList(list).map(val => this.visit(val as Node, context));
+          return this.formatter.parens(values.join(', '));
+        });
+        output.push(lists.join(', '));
+      }
     }
 
     if (node.groupClause) {
@@ -909,6 +924,8 @@ export class Deparser implements DeparserVisitor {
     return this.visit(rexpr, context);
   }
 
+
+
   InsertStmt(node: t.InsertStmt, context: DeparserContext): string {
     const output: string[] = [];
 
@@ -923,7 +940,14 @@ export class Deparser implements DeparserVisitor {
       const cols = ListUtils.unwrapList(node.cols);
       const insertContext = { ...context, insertColumns: true };
       const columnNames = cols.map(col => this.visit(col as Node, insertContext));
-      output.push(this.formatter.parens(columnNames.join(', ')));
+      
+      if (this.formatter.isPretty()) {
+        // Always format columns in multiline parentheses for pretty printing
+        const indentedColumns = columnNames.map(col => this.formatter.indent(col));
+        output.push('(\n' + indentedColumns.join(',\n') + '\n)');
+      } else {
+        output.push(this.formatter.parens(columnNames.join(', ')));
+      }
     }
 
     if (node.selectStmt) {