fix: add pg_catalog prefix logic for SQL standard functions

- Add logic to prepend pg_catalog prefix to single-element function names
- Target SQL standard functions like btrim, trim, ltrim, rtrim
- Maintain 228/258 passing tests while working on function prefix issues

Co-Authored-By: Dan Lynch <[email protected]>

Author: devin-ai-integration[bot]

packages/transform/src/transformers/v13-to-v14.ts

@@ -184,7 +184,7 @@ export class V13ToV14Transformer {
           }
         }
 
-        // Handle pg_catalog prefix removal for specific functions
+        // Handle pg_catalog prefix for specific functions
         if (funcname.length >= 2) {
           const firstElement = funcname[0];
           const secondElement = funcname[1];
@@ -202,6 +202,23 @@ export class V13ToV14Transformer {
               }
             }
           }
+        } else if (funcname.length === 1) {
+          const singleElement = funcname[0];
+          if (singleElement && typeof singleElement === 'object' && 'String' in singleElement) {
+            const functionName = singleElement.String.str || singleElement.String.sval;
+            const sqlSyntaxFunctions = [
+              'btrim', 'trim', 'ltrim', 'rtrim',
+              'position', 'overlay',
+              'extract', 'timezone'
+            ];
+            
+            if (sqlSyntaxFunctions.includes(functionName.toLowerCase())) {
+              funcname = [
+                { String: { str: 'pg_catalog' } },
+                ...funcname
+              ];
+            }
+          }
         }
 
       }
@@ -961,22 +978,6 @@ export class V13ToV14Transformer {
       return 'COERCE_EXPLICIT_CALL';
     }
 
-    // Handle btrim function specifically - depends on pg_catalog prefix
-    if (funcname.toLowerCase() === 'btrim') {
-      // Check if the function has pg_catalog prefix by examining the node
-      if (node && node.funcname && Array.isArray(node.funcname) && node.funcname.length >= 2) {
-        const firstElement = node.funcname[0];
-        if (firstElement && typeof firstElement === 'object' && 'String' in firstElement) {
-          const prefix = firstElement.String.str || firstElement.String.sval;
-          if (prefix === 'pg_catalog') {
-            return 'COERCE_SQL_SYNTAX';
-          }
-        }
-      }
-      return 'COERCE_EXPLICIT_CALL';
-    }
-
-    
     const explicitCallFunctions = [
       'substr', 'timestamptz', 'timestamp', 'date', 'time', 'timetz',
       'interval', 'numeric', 'decimal', 'float4', 'float8', 'int2', 'int4', 'int8',