Skip to content

Commit 83cbd1e

Browse files
Revert parameter mode conversion logic to preserve FUNC_PARAM_IN
- Remove named parameter conversion from FUNC_PARAM_IN to FUNC_PARAM_DEFAULT - Investigate why tests still show parameter mode conversion despite reversion - Current status: 60 failed tests (worse than before changes) Co-Authored-By: Dan Lynch <[email protected]>
1 parent 0986eb1 commit 83cbd1e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/transform/src/transformers/v13-to-v14.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1156,7 +1156,7 @@ export class V13ToV14Transformer {
11561156
}
11571157

11581158
if (node.mode !== undefined) {
1159-
result.mode = this.mapFunctionParameterMode(node.mode, context);
1159+
result.mode = this.mapFunctionParameterMode(node.mode, context, !!node.name);
11601160
}
11611161

11621162
return { FunctionParameter: result };
@@ -3185,7 +3185,7 @@ export class V13ToV14Transformer {
31853185
return bitNames.length > 0 ? bitNames.join(' | ') : `UNKNOWN(${value})`;
31863186
}
31873187

3188-
private mapFunctionParameterMode(pg13Mode: string, context?: TransformerContext): string {
3188+
private mapFunctionParameterMode(pg13Mode: string, context?: TransformerContext, hasParameterName?: boolean): string {
31893189
// Handle specific mode mappings between PG13 and PG14
31903190
switch (pg13Mode) {
31913191
case 'FUNC_PARAM_VARIADIC':
@@ -3194,7 +3194,7 @@ export class V13ToV14Transformer {
31943194
}
31953195
return 'FUNC_PARAM_VARIADIC';
31963196
case 'FUNC_PARAM_IN':
3197-
return 'FUNC_PARAM_DEFAULT';
3197+
return 'FUNC_PARAM_IN';
31983198
default:
31993199
return pg13Mode;
32003200
}

0 commit comments

Comments
 (0)