Skip to content

Commit 8521f2d

Browse files
committed
known issues
1 parent 58a9207 commit 8521f2d

File tree

5 files changed

+20
-25
lines changed

5 files changed

+20
-25
lines changed
Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,10 @@
1-
export type SkipTest = [
2-
versionPrevious: number,
3-
versionNext: number,
4-
test: string,
5-
reason: string
6-
];
7-
8-
export { parserErrors } from './parser-errors';
9-
export { transformerErrors } from './transformer-errors';
10-
111
import { parserErrors } from './parser-errors';
122
import { transformerErrors } from './transformer-errors';
13-
3+
import { knownIssues } from './known-issues';
4+
import { SkipTest } from './types';
145
// Combined export for backward compatibility
156
export const skipTests: SkipTest[] = [
167
...parserErrors,
17-
...transformerErrors
8+
...transformerErrors,
9+
...knownIssues
1810
];
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import { SkipTest } from "./types";
2+
3+
export const knownIssues: SkipTest[] = [
4+
// PG13-PG16 treated \v as 'v'
5+
// PG17 treats \v as '\u000b'
6+
// So yes — PG17 fixed a real bug, and the current output with \u000b is the spec-compliant behavior.
7+
[16, 17, "misc/quotes_etc-26.sql", "16-17 Parser-level \v character escape sequence difference: PG16 parser outputs 'v' but PG17 parser outputs '\u000b' (vertical tab)"],
8+
];

packages/transform/test-utils/skip-tests/parser-errors.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,4 @@
1-
export type SkipTest = [
2-
versionPrevious: number,
3-
versionNext: number,
4-
test: string,
5-
reason: string
6-
];
1+
import { SkipTest } from "./types";
72

83
export const parserErrors: SkipTest[] = [
94
[16, 17, "latest/postgres/create_am-62.sql", "16-17 parser fails with 'syntax error at or near 'DEFAULT'"],

packages/transform/test-utils/skip-tests/transformer-errors.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,7 @@
1-
export type SkipTest = [
2-
versionPrevious: number,
3-
versionNext: number,
4-
test: string,
5-
reason: string
6-
];
1+
import { SkipTest } from "./types";
72

83
export const transformerErrors: SkipTest[] = [
94
[16, 17, "pretty/misc-5.sql", "16-17 transformer fails WITH clause TypeCast prefix issue: transformer adds pg_catalog prefix to JSON types when expected output has none"],
10-
[16, 17, "misc/quotes_etc-26.sql", "16-17 Parser-level \v character escape sequence difference: PG16 parser outputs 'v' but PG17 parser outputs '\u000b' (vertical tab)"],
115
[16, 17, "latest/postgres/create_am-96.sql", "16-17 transformer fails with 'syntax error at or near 'DEFAULT'"],
126
[16, 17, "latest/postgres/create_am-74.sql", "16-17 transformer fails with 'syntax error at or near 'DEFAULT'"],
137
[16, 17, "latest/postgres/create_am-65.sql", "16-17 transformer fails with 'syntax error at or near 'DEFAULT'"],
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
export type SkipTest = [
2+
versionPrevious: number,
3+
versionNext: number,
4+
test: string,
5+
reason: string
6+
];

0 commit comments

Comments
 (0)