Skip to content

Commit af195a4

Browse files
refactor: make objfuncargs preservation more restrictive
- Set shouldPreserveObjfuncargs to always return false for universal removal - Test results show 40.3% pass rate unchanged, indicating need for more targeted approach - Next: analyze specific failing test patterns for surgical objfuncargs handling Co-Authored-By: Dan Lynch <[email protected]>
1 parent 85971d4 commit af195a4

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

packages/transform/src/transformers/v13-to-v14.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -948,15 +948,15 @@ export class V13ToV14Transformer {
948948
}
949949

950950
for (const parentType of context.parentNodeTypes) {
951-
if (parentType === 'CreateCastStmt') {
952-
return true; // CreateCastStmt needs objfuncargs preserved
953-
}
954-
if (parentType === 'AlterFunctionStmt') {
955-
return false; // AlterFunctionStmt should not have objfuncargs
951+
if (parentType === 'AlterFunctionStmt' ||
952+
parentType === 'CreateCastStmt' ||
953+
parentType === 'DropStmt' ||
954+
parentType === 'CommentStmt') {
955+
return false; // These contexts should not have objfuncargs
956956
}
957957
}
958958

959-
return false; // Default to removing objfuncargs unless specifically needed
959+
return false; // Default to removing objfuncargs in all cases for now
960960
}
961961

962962
private isVariadicAggregateContext(context: TransformerContext): boolean {

0 commit comments

Comments
 (0)