Skip to content

Commit c0c7190

Browse files
authored
Merge branch 'pg13-pg14-base' into pg14-pg15-transformer
2 parents 2e4a45e + 6dca90e commit c0c7190

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

packages/transform/STATUS-14-15.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,15 @@ The main issue was incorrect wrapper patterns in DefineStmt and CopyStmt methods
3737
### 2. Boolean TypeCast Conversion (FIXED)
3838
Implemented precise logic to convert PG14 TypeCast nodes with `["pg_catalog", "bool"]` type names to PG15 A_Const nodes with `boolval` properties, while preserving simple `["bool"]` TypeCast nodes unchanged.
3939

40+
- 🔧 Testing current fixes for node wrapping issues
41+
42+
## Test Status Summary
43+
The 14-15 transformer is in active development with 6 tests passing (improved from 2). The core transformation logic is working and recent fixes to the visit method have shown some improvement, but String transformation issues persist.
44+
45+
## Primary Issue: Node Wrapping Problems (PARTIALLY FIXED)
46+
The main issue was that the `visit` method wasn't properly calling specific node transformation methods like `String`. Updated visit method to use transformGenericNode as fallback, following v13-to-v14 pattern. This improved from 2/258 to 6/258 passing tests, but String transformation issues persist.
47+
48+
4049
### Examples of Wrapping Issues:
4150
```diff
4251
// Expected (no wrapper)
@@ -179,3 +188,4 @@ The PostgreSQL 14→15 AST transformer is **COMPLETE** and ready for production
179188
- ✅ Ready for merge and production deployment
180189

181190
The transformer successfully handles all transformable PG14→PG15 AST changes while maintaining high reliability and performance.
191+
🟡 **Medium-High** - The core transformations are working correctly. Once the node wrapping issue is resolved, expect dramatic improvement in test pass rate since the fundamental AST changes are already implemented properly.

packages/transform/src/transformers/v14-to-v15.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,9 +252,8 @@ export class V14ToV15Transformer {
252252
}
253253
}
254254

255-
256255
// Handle ival field directly (not nested in val) - removed overly broad conversion
257-
256+
258257
return { A_Const: result };
259258
}
260259

0 commit comments

Comments
 (0)