Skip to content

Commit d4613fc

Browse files
fix: remove variadic parameter detection logic to fix arrays and rangetypes tests - restore 238 passing tests baseline
Co-Authored-By: Dan Lynch <[email protected]>
1 parent 14c69de commit d4613fc

File tree

1 file changed

+2
-20
lines changed

1 file changed

+2
-20
lines changed

packages/transform/src/transformers/v13-to-v14.ts

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1046,12 +1046,7 @@ export class V13ToV14Transformer {
10461046
if (node.mode === "FUNC_PARAM_VARIADIC") {
10471047
result.mode = "FUNC_PARAM_VARIADIC"; // Always preserve variadic parameters
10481048
} else if (node.mode === "FUNC_PARAM_IN") {
1049-
// Check if this parameter should be variadic based on polymorphic array types
1050-
if (this.isVariadicParameterType(node.argType)) {
1051-
result.mode = "FUNC_PARAM_VARIADIC";
1052-
} else {
1053-
result.mode = "FUNC_PARAM_DEFAULT";
1054-
}
1049+
result.mode = "FUNC_PARAM_DEFAULT";
10551050
} else {
10561051
result.mode = node.mode;
10571052
}
@@ -2124,20 +2119,7 @@ export class V13ToV14Transformer {
21242119

21252120
let mode = "FUNC_PARAM_DEFAULT";
21262121

2127-
// Check if this is a variadic parameter type (anyarray, anycompatiblearray, etc.)
2128-
if (this.isVariadicParameterType(argType)) {
2129-
mode = "FUNC_PARAM_VARIADIC";
2130-
}
2131-
2132-
if (argType && argType.names && Array.isArray(argType.names)) {
2133-
const typeName = argType.names[argType.names.length - 1];
2134-
if (typeName && typeName.String && typeName.String.str === 'anyarray') {
2135-
mode = "FUNC_PARAM_VARIADIC";
2136-
}
2137-
}
2138-
2139-
2140-
// Also check for VARIADIC context in aggregate functions
2122+
// Check if this should be variadic based on context (aggregate functions with VARIADIC keyword)
21412123
if (context && context.parentNodeTypes) {
21422124
const isAggregateContext = context.parentNodeTypes.includes('RenameStmt') &&
21432125
(context as any).renameObjectType === 'OBJECT_AGGREGATE';

0 commit comments

Comments
 (0)