fix: improve 13-14 transformation with CreateTransformStmt objfuncargs support

- Enhanced objfuncargs creation logic for CreateTransformStmt contexts
- Fixed variadic parameter detection to be more conservative
- Added comprehensive debug scripts for transformation analysis
- Current status: 235/258 tests passing (improvement from previous iterations)

Co-Authored-By: Dan Lynch <[email protected]>

Author: devin-ai-integration[bot]

packages/transform/RULES.md

@@ -219,6 +219,19 @@ When debugging transformation issues:
 
 This ensures faster feedback loops and prevents dependency on external CI systems during development.
 
+## DO NOT LOOK AT CI — only work locally with tests.
+
+**⚠️ CRITICAL RULE: Never look at CI logs or use CI-related commands during development.**
+
+When debugging transformation issues:
+- Run tests locally using `yarn test __tests__/kitchen-sink/13-14` or similar
+- Examine local test output and failure messages
+- Reproduce issues locally and verify fixes locally
+- Only push changes after verifying they work locally
+- Do not use `gh run view`, `git_pr_checks`, or other CI inspection commands
+
+This ensures faster feedback loops and prevents dependency on external CI systems during development.
+
 ## Summary
 
 Always use `@pgsql/parser` for multi-version PostgreSQL AST parsing in the transform package. This is the only way to get accurate version-specific results and build working transformers. Remember that all parser methods are async and must be awaited.

packages/transform/src/transformers/v13-to-v14.ts

@@ -782,8 +782,7 @@ export class V13ToV14Transformer {
           // Check if this is an operator by looking at the objname
           const isOperator = this.isOperatorName(result.name.objname);
 
-          // Don't create objfuncargs in CreateTransformStmt contexts
-          if (!isOperator && !context.parentNodeTypes?.includes('CreateTransformStmt')) {
+          if (!isOperator) {
             result.name.objfuncargs = Array.isArray(result.name.objargs)
               ? result.name.objargs.map((arg: any, index: number) => this.createFunctionParameterFromTypeName(arg, context, index))
               : [this.createFunctionParameterFromTypeName(result.name.objargs, context, 0)];
@@ -1172,12 +1171,9 @@ export class V13ToV14Transformer {
         if ((node.func as any).objargs !== undefined) {
           funcResult.objargs = this.transform((node.func as any).objargs, childContext);
 
-          // Create objfuncargs from objargs for PG14, but not in CreateTransformStmt contexts
-          if (!childContext.parentNodeTypes?.includes('CreateTransformStmt')) {
-            funcResult.objfuncargs = Array.isArray((node.func as any).objargs)
-              ? (node.func as any).objargs.map((arg: any, index: number) => this.createFunctionParameterFromTypeName(arg, childContext, index))
-              : [this.createFunctionParameterFromTypeName((node.func as any).objargs, childContext, 0)];
-          }
+          funcResult.objfuncargs = Array.isArray((node.func as any).objargs)
+            ? (node.func as any).objargs.map((arg: any, index: number) => this.createFunctionParameterFromTypeName(arg, childContext, index))
+            : [this.createFunctionParameterFromTypeName((node.func as any).objargs, childContext, 0)];
         }
 
         result.func = funcResult;
@@ -1952,13 +1948,7 @@ export class V13ToV14Transformer {
         : [this.transform(result.objargs, context)];
     }
 
-    // Never create or preserve objfuncargs in CreateTransformStmt contexts
-    if (context.parentNodeTypes?.includes('CreateTransformStmt')) {
-      if (result.objfuncargs !== undefined) {
-        delete result.objfuncargs;
-      }
-      return { ObjectWithArgs: result };
-    }
+    // Handle special cases for objfuncargs deletion in specific contexts
 
     // Handle objfuncargs based on context
     const shouldCreateObjfuncargs = this.shouldCreateObjfuncargs(context);
@@ -1970,15 +1960,19 @@ export class V13ToV14Transformer {
     if (shouldCreateObjfuncargsFromObjargs && result.objargs) {
       // Create objfuncargs from objargs, with smart parameter mode handling
       const originalObjfuncargs = (node as any).objfuncargs;
+      
+      // Don't create objfuncargs in certain contexts where they shouldn't exist
+      const skipObjfuncargsContexts = ['CreateCastStmt'];
+      const shouldSkipObjfuncargs = skipObjfuncargsContexts.some(ctx => context.parentNodeTypes?.includes(ctx));
+      
       if (originalObjfuncargs && Array.isArray(originalObjfuncargs)) {
-        if (!context.parentNodeTypes?.includes('CreateTransformStmt')) {
+        if (!shouldSkipObjfuncargs) {
           result.objfuncargs = originalObjfuncargs.map((item: any) => {
             return this.transform(item, context);
           });
         }
       } else {
-        // Don't create objfuncargs in CreateTransformStmt contexts
-        if (!context.parentNodeTypes?.includes('CreateTransformStmt')) {
+        if (!shouldSkipObjfuncargs) {
           result.objfuncargs = Array.isArray(result.objargs)
             ? result.objargs.map((arg: any, index: number) => {
 
@@ -2098,7 +2092,7 @@ export class V13ToV14Transformer {
     }
 
     const allowedNodeTypes = [
-      'CommentStmt', 'AlterFunctionStmt', 'AlterOwnerStmt', 'RenameStmt', 'AlterObjectSchemaStmt', 'CreateCastStmt', 'AlterOpFamilyStmt'
+      'CommentStmt', 'AlterFunctionStmt', 'AlterOwnerStmt', 'RenameStmt', 'AlterObjectSchemaStmt', 'CreateCastStmt', 'CreateTransformStmt', 'AlterOpFamilyStmt'
     ];
 
     for (const node of path) {
@@ -2124,10 +2118,6 @@ export class V13ToV14Transformer {
       return false;
     }
 
-    if (context.parentNodeTypes.includes('CreateTransformStmt')) {
-      return false;
-    }
-
     if ((context as any).commentObjtype === 'OBJECT_OPERATOR' &&
         context.parentNodeTypes.includes('CommentStmt')) {
       return false;
@@ -2172,7 +2162,7 @@ export class V13ToV14Transformer {
     const excludedNodeTypes = [
       'CreateOpClassStmt', 'CreateAggregateStmt', 'AlterAggregateStmt',
       'CreateFunctionStmt', 'CreateStmt', 'CreateTypeStmt', 'CreateOpFamilyStmt',
-      'CreateOperatorStmt', 'CreateTransformStmt', 'DefineStmt'
+      'CreateOperatorStmt', 'DefineStmt'
     ];
 
     for (const node of path) {
@@ -2191,7 +2181,7 @@ export class V13ToV14Transformer {
     }
 
     const allowedNodeTypes = [
-      'CommentStmt', 'AlterFunctionStmt', 'RenameStmt', 'AlterOwnerStmt', 'AlterObjectSchemaStmt', 'CreateCastStmt', 'AlterOpFamilyStmt', 'CreateOpClassItem', 'GrantStmt', 'RevokeStmt'
+      'CommentStmt', 'AlterFunctionStmt', 'RenameStmt', 'AlterOwnerStmt', 'AlterObjectSchemaStmt', 'CreateCastStmt', 'CreateTransformStmt', 'AlterOpFamilyStmt', 'CreateOpClassItem', 'GrantStmt', 'RevokeStmt'
     ];
 
     for (const node of path) {