Skip to content

Commit f79ce96

Browse files
committed
Systematically uncomment Integer object differences test cases after Dan's fix
- Used find_and_edit to uncomment 57 test files with 'Integer object differences' comments - Dan's upstream Integer transformation fix resolved the vast majority of cases - Re-commented 4 remaining edge cases that still fail: - alter_generic-16.sql: Integer object differences - alter_generic-17.sql: Integer object differences - create_aggregate-48.sql: Integer object differences - create_index-326.sql: syntax error at end of input - Final result: 258 passed, 0 failed tests in 15-16 suite - Successfully recovered maximum possible test cases while maintaining 100% pass rate Co-Authored-By: Dan Lynch <[email protected]>
1 parent 7b94ed0 commit f79ce96

File tree

60 files changed

+225
-225
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+225
-225
lines changed

packages/transform/__tests__/kitchen-sink/15-16/latest-postgres-create_aggregate.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ it('latest-postgres-create_aggregate', async () => {
1818
"latest/postgres/create_aggregate-12.sql",
1919
"latest/postgres/create_aggregate-13.sql",
2020
"latest/postgres/create_aggregate-14.sql",
21-
// "latest/postgres/create_aggregate-15.sql", // REMOVED: 15-16 transformer fails with Integer object differences
22-
// "latest/postgres/create_aggregate-16.sql", // REMOVED: 15-16 transformer fails with Integer object differences
21+
"latest/postgres/create_aggregate-15.sql",
22+
"latest/postgres/create_aggregate-16.sql",
2323
"latest/postgres/create_aggregate-17.sql",
2424
"latest/postgres/create_aggregate-18.sql",
2525
"latest/postgres/create_aggregate-19.sql",

packages/transform/__tests__/kitchen-sink/15-16/latest-postgres-create_function_sql.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ it('latest-postgres-create_function_sql', async () => {
99
"latest/postgres/create_function_sql-3.sql",
1010
"latest/postgres/create_function_sql-4.sql",
1111
"latest/postgres/create_function_sql-5.sql",
12-
// "latest/postgres/create_function_sql-6.sql", // REMOVED: 15-16 transformer fails with Integer object differences
12+
"latest/postgres/create_function_sql-6.sql",
1313
"latest/postgres/create_function_sql-7.sql",
1414
"latest/postgres/create_function_sql-8.sql",
1515
"latest/postgres/create_function_sql-9.sql",
@@ -61,7 +61,7 @@ it('latest-postgres-create_function_sql', async () => {
6161
"latest/postgres/create_function_sql-55.sql",
6262
"latest/postgres/create_function_sql-56.sql",
6363
"latest/postgres/create_function_sql-57.sql",
64-
// "latest/postgres/create_function_sql-58.sql", // REMOVED: 15-16 transformer fails with Integer object differences
64+
"latest/postgres/create_function_sql-58.sql",
6565
"latest/postgres/create_function_sql-59.sql",
6666
"latest/postgres/create_function_sql-60.sql",
6767
"latest/postgres/create_function_sql-61.sql",

packages/transform/__tests__/kitchen-sink/15-16/latest-postgres-create_index.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ it('latest-postgres-create_index', async () => {
191191
"latest/postgres/create_index-185.sql",
192192
"latest/postgres/create_index-186.sql",
193193
"latest/postgres/create_index-187.sql",
194-
// "latest/postgres/create_index-188.sql", // REMOVED: 15-16 transformer fails with Integer object differences
194+
"latest/postgres/create_index-188.sql",
195195
"latest/postgres/create_index-189.sql",
196196
"latest/postgres/create_index-190.sql",
197197
"latest/postgres/create_index-191.sql",
@@ -210,7 +210,7 @@ it('latest-postgres-create_index', async () => {
210210
"latest/postgres/create_index-204.sql",
211211
"latest/postgres/create_index-205.sql",
212212
"latest/postgres/create_index-206.sql",
213-
// "latest/postgres/create_index-207.sql", // REMOVED: 15-16 transformer fails with Integer object differences
213+
"latest/postgres/create_index-207.sql",
214214
"latest/postgres/create_index-208.sql",
215215
"latest/postgres/create_index-209.sql",
216216
"latest/postgres/create_index-210.sql",
@@ -329,7 +329,7 @@ it('latest-postgres-create_index', async () => {
329329
"latest/postgres/create_index-323.sql",
330330
"latest/postgres/create_index-324.sql",
331331
"latest/postgres/create_index-325.sql",
332-
// "latest/postgres/create_index-326.sql", // REMOVED: 15-16 transformer fails with Integer object differences
332+
// "latest/postgres/create_index-326.sql", // REMOVED: 15-16 transformer fails with syntax error at end of input
333333
"latest/postgres/create_index-327.sql",
334334
"latest/postgres/create_index-328.sql",
335335
"latest/postgres/create_index-329.sql",

packages/transform/__tests__/kitchen-sink/15-16/latest-postgres-create_operator.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ it('latest-postgres-create_operator', async () => {
1717
"latest/postgres/create_operator-11.sql",
1818
"latest/postgres/create_operator-12.sql",
1919
"latest/postgres/create_operator-13.sql",
20-
// "latest/postgres/create_operator-14.sql", // REMOVED: 15-16 transformer fails with Integer object differences
20+
"latest/postgres/create_operator-14.sql",
2121
"latest/postgres/create_operator-15.sql",
22-
// "latest/postgres/create_operator-16.sql", // REMOVED: 15-16 transformer fails with Integer object differences
23-
// "latest/postgres/create_operator-17.sql", // REMOVED: 15-16 transformer fails with Integer object differences
22+
"latest/postgres/create_operator-16.sql",
23+
"latest/postgres/create_operator-17.sql",
2424
"latest/postgres/create_operator-18.sql",
2525
"latest/postgres/create_operator-19.sql",
2626
"latest/postgres/create_operator-20.sql",

packages/transform/__tests__/kitchen-sink/15-16/latest-postgres-create_procedure.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ it('latest-postgres-create_procedure', async () => {
6565
"latest/postgres/create_procedure-59.sql",
6666
"latest/postgres/create_procedure-60.sql",
6767
"latest/postgres/create_procedure-61.sql",
68-
// "latest/postgres/create_procedure-62.sql", // REMOVED: 15-16 transformer fails with Integer object differences
68+
"latest/postgres/create_procedure-62.sql",
6969
"latest/postgres/create_procedure-63.sql",
7070
"latest/postgres/create_procedure-64.sql",
7171
"latest/postgres/create_procedure-65.sql",
@@ -82,7 +82,7 @@ it('latest-postgres-create_procedure', async () => {
8282
"latest/postgres/create_procedure-76.sql",
8383
"latest/postgres/create_procedure-77.sql",
8484
"latest/postgres/create_procedure-78.sql",
85-
// "latest/postgres/create_procedure-79.sql", // REMOVED: 15-16 transformer fails with Integer object differences
85+
"latest/postgres/create_procedure-79.sql",
8686
"latest/postgres/create_procedure-80.sql",
8787
"latest/postgres/create_procedure-81.sql",
8888
"latest/postgres/create_procedure-82.sql",

packages/transform/__tests__/kitchen-sink/15-16/latest-postgres-create_type.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ it('latest-postgres-create_type', async () => {
5858
"latest/postgres/create_type-52.sql",
5959
"latest/postgres/create_type-53.sql",
6060
"latest/postgres/create_type-54.sql",
61-
// "latest/postgres/create_type-55.sql", // REMOVED: 15-16 transformer fails with Integer object differences
61+
"latest/postgres/create_type-55.sql",
6262
"latest/postgres/create_type-56.sql",
6363
"latest/postgres/create_type-57.sql",
6464
"latest/postgres/create_type-58.sql",

packages/transform/__tests__/kitchen-sink/15-16/misc-inflection.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ const fixtures = new FixtureTestUtils(15, 16);
44

55
it('misc-inflection', async () => {
66
await fixtures.runFixtureTests([
7-
// "misc/inflection-1.sql", // REMOVED: 15-16 transformer fails with Integer object differences
8-
// "misc/inflection-2.sql", // REMOVED: 15-16 transformer fails with Integer object differences
7+
"misc/inflection-1.sql",
8+
"misc/inflection-2.sql",
99
"misc/inflection-3.sql",
1010
"misc/inflection-4.sql",
1111
"misc/inflection-5.sql",
@@ -23,7 +23,7 @@ it('misc-inflection', async () => {
2323
"misc/inflection-17.sql",
2424
"misc/inflection-18.sql",
2525
"misc/inflection-19.sql",
26-
// "misc/inflection-20.sql", // REMOVED: 15-16 transformer fails with Integer object differences
26+
"misc/inflection-20.sql",
2727
"misc/inflection-21.sql",
2828
"misc/inflection-22.sql",
2929
"misc/inflection-23.sql",

packages/transform/__tests__/kitchen-sink/15-16/original-custom.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ const fixtures = new FixtureTestUtils(15, 16);
44

55
it('original-custom', async () => {
66
await fixtures.runFixtureTests([
7-
// "original/custom-1.sql", // REMOVED: 15-16 transformer fails with Integer object differences
8-
// "original/custom-2.sql", // REMOVED: 15-16 transformer fails with Integer object differences
7+
"original/custom-1.sql",
8+
"original/custom-2.sql",
99
"original/custom-3.sql",
1010
"original/custom-4.sql",
11-
// "original/custom-5.sql", // REMOVED: 15-16 transformer fails with Integer object differences
11+
"original/custom-5.sql",
1212
"original/custom-6.sql",
1313
"original/custom-7.sql",
1414
"original/custom-8.sql",

packages/transform/__tests__/kitchen-sink/15-16/original-sequences-sequences.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ const fixtures = new FixtureTestUtils(15, 16);
44

55
it('original-sequences-sequences', async () => {
66
await fixtures.runFixtureTests([
7-
// "original/sequences/sequences-1.sql", // REMOVED: 15-16 transformer fails with Integer object differences
8-
// "original/sequences/sequences-2.sql", // REMOVED: 15-16 transformer fails with Integer object differences
9-
// "original/sequences/sequences-3.sql", // REMOVED: 15-16 transformer fails with Integer object differences
7+
"original/sequences/sequences-1.sql",
8+
"original/sequences/sequences-2.sql",
9+
"original/sequences/sequences-3.sql",
1010
"original/sequences/sequences-4.sql",
1111
"original/sequences/sequences-5.sql"
1212
]);

packages/transform/__tests__/kitchen-sink/15-16/original-statements-select.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ const fixtures = new FixtureTestUtils(15, 16);
44

55
it('original-statements-select', async () => {
66
await fixtures.runFixtureTests([
7-
// "original/statements/select-1.sql", // REMOVED: 15-16 transformer fails with Integer object differences
8-
// "original/statements/select-2.sql", // REMOVED: 15-16 transformer fails with Integer object differences
7+
"original/statements/select-1.sql",
8+
"original/statements/select-2.sql",
99
"original/statements/select-3.sql"
1010
]);
1111
});

0 commit comments

Comments
 (0)