Skip to content
This repository was archived by the owner on Apr 3, 2025. It is now read-only.

feat: Add movetype sync from props#149

Open
Artboomy wants to merge 1 commit intolaurenashpole:masterfrom
Artboomy:master
Open

feat: Add movetype sync from props#149
Artboomy wants to merge 1 commit intolaurenashpole:masterfrom
Artboomy:master

Conversation

@Artboomy
Copy link

No description provided.

@Artboomy
Copy link
Author

My usecase: I use middle mouse click to toggle between dragging and panning zoom.
I inspected the code and found out moveType from props is read only at initial component render.
I added effect for syncing value from props to allow toggling between modes without remounting the component.

@laurenashpole thank you for the package, I hope you will have the time to review fixes.

@laurenashpole
Copy link
Owner

@Artboomy Sorry for the delay noticing this PR! I've been working on moving all of this code to a new repo and just finished that. I'll include this with the next update there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants