Title bar color mismatch with selected theme in Joplin

[FrankleeM]

Operating system

Windows

Joplin version

3.5.12

Desktop version info

Joplin 3.5.12 (prod, win32)
设备: win32, Intel(R) Core(TM) i9-14900HX
客户端 ID:64fcd971f3d749898b1249077e130b9c

Current behaviour

[BUG] Two Theme Display Issues

1. Note list view stays dark when light theme is selected
2. Title bar/menu bar remains white when dark theme is enabled

Expected behaviour

1. Is the first case normal?
2. How do I fix the second issue?
   thanks

Logs

No response

[FrankleeM]

[hariprabhu571]

Hi,
I looked into this issue and it seems the title bar color is not updating according to the selected theme.
I’d like to investigate further and work on a fix. Please let me know if anyone is already working on this or if I can proceed.

[Osank31]

Hi I'd like to work on this issue. Please assign it to me

[personalizedrefrigerator]

Is the first case normal?

Yes, this is expected behavior. The current light theme sets the background color of the notebook list sidebar to a dark color with light text.

Title bar/menu bar remains white when dark theme is enabled

At present, the title bar/menu should usually match the OS theme. (But perhaps it would make more sense to match the Joplin theme instead?)

[personalizedrefrigerator]

Development note: Electron exposes nativeTheme.themeSource. It may be possible to use this to make the window title bar and menu match the color theme. (However, care should be taken to not break the theme auto-detect logic.)

I’d like to investigate further and work on a fix. Please let me know if anyone is already working on this or if I can proceed.
Hi I'd like to work on this issue. Please assign it to me

We usually don't assign issues. Feel free to work on this and open a pull request!

Be aware, however, that fixes for issues tagged "high" or "medium" are more likely to be accepted.

[FrankleeM]

@personalizedrefrigerator @hariprabhu571 @Osank31 thanks everyone

[Tarjmul810]

Is the dark background of sidebar in light theme intentional (system design) or should it match it match lighter content area?

[FrankleeM]

浅色主题下侧边栏的深色背景是故意设计的（系统设计），还是应该与浅色内容区域保持一致？

Based on @personalizedrefrigerator response, my understanding is that this was the original design

[personalizedrefrigerator]

Based on @personalizedrefrigerator response, my understanding is that this was the original design

Yes, the dark background with light text in the sidebar is expected behavior.