Skip to content

Commit 05a5475

Browse files
fujiifujii
committed
Non-unified source build fix 2025-09 (part 3)
https://bugs.webkit.org/show_bug.cgi?id=298385 Unreviewed build fix for non-unified builds. Moved inline functions recomputeIsIgnored() and isHidden() of AccessibilityObject class from AccessibilityObject.h to AccessibilityObjectInlines.h because they use the inline funtions defined in it. Uninlined ScriptWrappable::~ScriptWrappable(). Otherwise, the destructors of all derived classes had to be defined in *Inlines.h. * Source/JavaScriptCore/bytecode/CallLinkInfoBase.cpp: * Source/JavaScriptCore/bytecode/GetByVariant.h: * Source/JavaScriptCore/interpreter/CachedCall.h: * Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp: * Source/JavaScriptCore/runtime/JSFunction.h: * Source/JavaScriptCore/runtime/StackFrame.cpp: * Source/WebCore/Modules/WebGPU/GPURenderPassDepthStencilAttachment.h: * Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassDepthStencilAttachment.h: * Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp: * Source/WebCore/Modules/cache/DOMCacheStorage.cpp: * Source/WebCore/Modules/entriesapi/FileSystemDirectoryReader.cpp: * Source/WebCore/Modules/entriesapi/FileSystemEntry.cpp: * Source/WebCore/Modules/fetch/FetchResponse.cpp: * Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp: * Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp: * Source/WebCore/Modules/mediasource/ManagedMediaSource.cpp: * Source/WebCore/Modules/mediasource/SourceBuffer.cpp: * Source/WebCore/Modules/mediastream/MediaDevices.cpp: * Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.cpp: * Source/WebCore/Modules/permissions/Permissions.cpp: * Source/WebCore/Modules/reporting/ReportingObserver.cpp: * Source/WebCore/Modules/screen-wake-lock/NavigatorScreenWakeLock.cpp: * Source/WebCore/Modules/screen-wake-lock/WakeLock.cpp: * Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp: * Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations: * Source/WebCore/accessibility/AXCoreObject.cpp: * Source/WebCore/accessibility/AXListHelpers.cpp: * Source/WebCore/accessibility/AXSearchManager.cpp: * Source/WebCore/accessibility/AccessibilityMathMLElement.cpp: * Source/WebCore/accessibility/AccessibilityMenuList.cpp: * Source/WebCore/accessibility/AccessibilityMenuListOption.cpp: * Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp: * Source/WebCore/accessibility/AccessibilityMockObject.cpp: * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::isVisible const): * Source/WebCore/accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::isHidden const): Deleted. (WebCore::AccessibilityObject::recomputeIsIgnored): Deleted. * Source/WebCore/accessibility/AccessibilityObjectInlines.h: (WebCore::AccessibilityObject::isHidden const): (WebCore::AccessibilityObject::recomputeIsIgnored): * Source/WebCore/accessibility/AccessibilityProgressIndicator.cpp: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: * Source/WebCore/accessibility/AccessibilitySVGObject.cpp: * Source/WebCore/accessibility/AccessibilityScrollView.cpp: * Source/WebCore/accessibility/AccessibilitySlider.cpp: * Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp: * Source/WebCore/accessibility/atspi/AccessibilityObjectComponentAtspi.cpp: * Source/WebCore/accessibility/atspi/AccessibilityObjectDocumentAtspi.cpp: * Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp: * Source/WebCore/bindings/js/ScriptWrappable.cpp: * Source/WebCore/bindings/js/ScriptWrappable.h: * Source/WebCore/bindings/js/ScriptWrappableInlines.h: * Source/WebCore/css/MediaQueryMatcher.cpp: * Source/WebCore/css/PropertySetCSSDescriptors.cpp: * Source/WebCore/css/StyleAttributeMutationScope.cpp: * Source/WebCore/css/typedom/InlineStylePropertyMap.cpp: * Source/WebCore/dom/CharacterData.cpp: * Source/WebCore/dom/ChildListMutationScope.cpp: * Source/WebCore/dom/DocumentMediaElement.cpp: * Source/WebCore/dom/InternalObserverDrop.cpp: * Source/WebCore/dom/InternalObserverEvery.cpp: * Source/WebCore/dom/InternalObserverFilter.cpp: * Source/WebCore/dom/InternalObserverFind.cpp: * Source/WebCore/dom/InternalObserverMap.cpp: * Source/WebCore/dom/InternalObserverReduce.cpp: * Source/WebCore/dom/InternalObserverSome.cpp: * Source/WebCore/dom/InternalObserverTake.cpp: * Source/WebCore/dom/MutationObserverInterestGroup.cpp: * Source/WebCore/dom/PositionIterator.cpp: * Source/WebCore/dom/PseudoElement.cpp: * Source/WebCore/dom/RadioButtonGroups.cpp: * Source/WebCore/dom/ScriptedAnimationController.cpp: * Source/WebCore/dom/SerializedNode.cpp: * Source/WebCore/editing/InsertLineBreakCommand.cpp: * Source/WebCore/editing/RemoveFormatCommand.cpp: * Source/WebCore/editing/SpellChecker.cpp: * Source/WebCore/editing/TextCheckingHelper.cpp: * Source/WebCore/editing/TextInsertionBaseCommand.cpp: * Source/WebCore/editing/VisibleUnits.cpp: * Source/WebCore/html/CanvasBase.cpp: * Source/WebCore/html/CheckboxInputType.cpp: * Source/WebCore/html/CustomPaintImage.cpp: * Source/WebCore/html/HTMLMediaElement.cpp: * Source/WebCore/html/HTMLTableRowElement.cpp: * Source/WebCore/html/HTMLVideoElement.cpp: * Source/WebCore/html/ImageDocument.cpp: * Source/WebCore/html/PDFDocument.cpp: * Source/WebCore/html/PluginDocument.cpp: * Source/WebCore/html/TextDocument.cpp: * Source/WebCore/html/canvas/WebGLRenderingContext.cpp: * Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp: * Source/WebCore/html/shadow/SpinButtonElement.cpp: * Source/WebCore/html/track/TextTrackCue.cpp: * Source/WebCore/html/track/VTTRegion.cpp: * Source/WebCore/inspector/InspectorInstrumentation.cpp: * Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp: * Source/WebCore/inspector/agents/page/PageNetworkAgent.cpp: * Source/WebCore/layout/integration/LayoutIntegrationBoxTreeUpdater.cpp: * Source/WebCore/layout/integration/inline/InlineIteratorBox.cpp: * Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp: * Source/WebCore/loader/ResourceLoadNotifier.cpp: * Source/WebCore/loader/SinkDocument.cpp: * Source/WebCore/loader/cache/CachedResource.cpp: * Source/WebCore/page/DOMTimer.cpp: * Source/WebCore/page/EventHandler.cpp: * Source/WebCore/page/FocusController.cpp: * Source/WebCore/page/InteractionRegion.cpp: * Source/WebCore/page/IntersectionObserver.cpp: * Source/WebCore/page/MemoryRelease.cpp: * Source/WebCore/page/Quirks.cpp: (WebCore::shouldPreventOrientationMediaQueryFromEvaluatingToLandscapeInternal): (WebCore::standardUserAgentWithApplicationNameIncludingCompatOverridesInternal): * Source/WebCore/page/ResizeObserver.cpp: * Source/WebCore/page/SpatialNavigation.cpp: * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp: * Source/WebCore/rendering/AccessibilityRegionContext.cpp: * Source/WebCore/rendering/BorderPainter.cpp: * Source/WebCore/rendering/CounterNode.cpp: * Source/WebCore/rendering/EllipsisBoxPainter.cpp: * Source/WebCore/rendering/HitTestResult.cpp: * Source/WebCore/rendering/LegacyInlineFlowBox.cpp: * Source/WebCore/rendering/LegacyInlineTextBox.cpp: * Source/WebCore/rendering/RenderEmbeddedObject.cpp: * Source/WebCore/rendering/RenderHTMLCanvas.cpp: * Source/WebCore/rendering/RenderLayerBacking.cpp: * Source/WebCore/rendering/RenderLayerCompositor.cpp: * Source/WebCore/rendering/RenderLayerFilters.cpp: * Source/WebCore/rendering/RenderObject.h: * Source/WebCore/rendering/RenderSearchField.cpp: * Source/WebCore/rendering/RenderTheme.cpp: * Source/WebCore/rendering/TextBoxPainter.cpp: * Source/WebCore/rendering/TextBoxTrimmer.cpp: * Source/WebCore/rendering/TextDecorationPainter.cpp: * Source/WebCore/rendering/adwaita/RenderThemeAdwaita.cpp: * Source/WebCore/rendering/line/LineBreaker.cpp: * Source/WebCore/rendering/line/LineInlineHeaders.h: * Source/WebCore/rendering/style/SVGRenderStyle.cpp: * Source/WebCore/rendering/svg/RenderSVGShape.cpp: * Source/WebCore/rendering/svg/RenderSVGText.cpp: * Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp: * Source/WebCore/rendering/svg/SVGTextBoxPainter.cpp: * Source/WebCore/rendering/svg/SVGTextLayoutEngineBaseline.cpp: * Source/WebCore/rendering/svg/SVGTextQuery.cpp: * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipper.cpp: * Source/WebCore/rendering/svg/legacy/SVGResourcesCycleSolver.cpp: * Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp: * Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp: * Source/WebCore/rendering/updating/RenderTreeBuilderMathML.cpp: * Source/WebCore/rendering/updating/RenderTreeBuilderSVG.cpp: * Source/WebCore/rendering/updating/RenderTreeBuilderTable.cpp: * Source/WebCore/rendering/updating/RenderTreePosition.cpp: * Source/WebCore/style/AttributeChangeInvalidation.cpp: * Source/WebCore/style/StyleBuilderCustom.h: * Source/WebCore/style/values/transforms/StyleTransformList.cpp: * Source/WebCore/svg/SVGDefsElement.cpp: * Source/WebCore/svg/SVGElement.cpp: * Source/WebCore/svg/SVGGElement.cpp: * Source/WebCore/svg/SVGLocatable.cpp: * Source/WebCore/svg/SVGMarkerElement.cpp: * Source/WebCore/svg/SVGScriptElement.cpp: * Source/WebCore/svg/SVGSymbolElement.cpp: * Source/WebCore/workers/Worker.cpp: * Source/WebCore/workers/WorkerInspectorProxy.cpp: * Source/WebCore/workers/service/ServiceWorker.cpp: * Source/WebCore/workers/service/ServiceWorkerClient.cpp: * Source/WebCore/worklets/WorkletGlobalScope.cpp: * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.cpp: * Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.cpp: * Source/WebKit/Shared/JSHandleInfo.cpp: * Source/WebKit/Shared/WebGPU/WebGPURenderPassDepthStencilAttachment.cpp: * Source/WebKit/UIProcess/API/glib/WebKitNetworkSession.cpp: * Source/WebKit/UIProcess/Automation/BidiScriptAgent.cpp: * Source/WebKit/UIProcess/XR/openxr/PlatformXRSystemOpenXR.cpp: * Source/WebKit/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp: * Source/WebKit/WebProcess/WebCoreSupport/wpe/WebDragClientWPE.cpp: * Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp: * Source/WebKit/WebProcess/WebPage/glib/WebPageGLib.cpp: * Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp: Canonical link: https://commits.webkit.org/299937@main
1 parent d97070b commit 05a5475

File tree

172 files changed

+245
-53
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

172 files changed

+245
-53
lines changed

‎Source/JavaScriptCore/bytecode/CallLinkInfoBase.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
#include "CachedCall.h"
3030
#include "CallLinkInfo.h"
3131
#include "JSCJSValueInlines.h"
32+
#include "JSFunctionInlines.h"
3233
#include "PolymorphicCallStubRoutine.h"
3334

3435
namespace JSC {

‎Source/JavaScriptCore/bytecode/GetByVariant.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828
#include "CacheableIdentifier.h"
2929
#include "CallLinkStatus.h"
30+
#include "JSFunctionInlines.h"
3031
#include "ObjectPropertyConditionSet.h"
3132
#include "PropertyOffset.h"
3233
#include "StructureSet.h"

‎Source/JavaScriptCore/interpreter/CachedCall.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
#include "ArgList.h"
2929
#include "CallLinkInfoBase.h"
3030
#include "ExceptionHelpers.h"
31-
#include "JSFunction.h"
31+
#include "JSFunctionInlines.h"
3232
#include "Interpreter.h"
3333
#include "ProtoCallFrameInlines.h"
3434
#include "VMEntryScope.h"

‎Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
#include "CodeBlock.h"
3232
#include "FullCodeOrigin.h"
3333
#include "JSCJSValueInlines.h"
34+
#include "JSFunctionInlines.h"
3435
#include "LinkBuffer.h"
3536

3637
WTF_ALLOW_UNSAFE_BUFFER_USAGE_BEGIN

‎Source/JavaScriptCore/runtime/JSFunction.h‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,10 @@ class JSFunction : public JSCallee {
106106
}
107107

108108
// To call any of these methods include JSFunctionInlines.h
109-
bool isHostFunction() const;
110-
bool isNonBoundHostFunction() const;
111-
FunctionExecutable* jsExecutable() const;
112-
Intrinsic intrinsic() const;
109+
inline bool isHostFunction() const;
110+
inline bool isNonBoundHostFunction() const;
111+
inline FunctionExecutable* jsExecutable() const;
112+
inline Intrinsic intrinsic() const;
113113

114114
JS_EXPORT_PRIVATE const SourceCode* sourceCode() const;
115115

‎Source/JavaScriptCore/runtime/StackFrame.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
#include "DebuggerPrimitives.h"
3131
#include "FunctionExecutable.h"
3232
#include "JSCellInlines.h"
33+
#include "JSFunctionInlines.h"
3334
#include <wtf/text/MakeString.h>
3435

3536
namespace JSC {

‎Source/WebCore/Modules/WebGPU/GPURenderPassDepthStencilAttachment.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include "GPUIntegralTypes.h"
2929
#include "GPULoadOp.h"
3030
#include "GPUStoreOp.h"
31+
#include "GPUTexture.h"
3132
#include "GPUTextureView.h"
3233
#include "WebGPURenderPassDepthStencilAttachment.h"
3334
#include <wtf/RefPtr.h>

‎Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassDepthStencilAttachment.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
namespace WebCore::WebGPU {
3636

3737
class TextureView;
38+
class Texture;
3839

3940
using RenderPassDepthAttachmentView = Variant<const WeakRef<Texture>, const WeakRef<TextureView>>;
4041

‎Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
#include "Clipboard.h"
3232
#include "ClipboardItem.h"
3333
#include "CommonAtomStrings.h"
34+
#include "ContextDestructionObserverInlines.h"
3435
#include "Document.h"
3536
#include "DocumentInlines.h"
3637
#include "ExceptionCode.h"

‎Source/WebCore/Modules/cache/DOMCacheStorage.cpp‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828

2929
#include "CacheQueryOptions.h"
3030
#include "ClientOrigin.h"
31+
#include "ContextDestructionObserverInlines.h"
3132
#include "EventLoop.h"
3233
#include "JSDOMCache.h"
3334
#include "JSDOMPromiseDeferred.h"

0 commit comments

Comments
 (0)