Fix smart pointers errors with CFRunLoopGetMain()/CFRunLoopGetCurrent()

https://bugs.webkit.org/show_bug.cgi?id=298865

Reviewed by Chris Dumez.

Ownership follows the The Get Rule, so they need a RetainPtr:
https://developer.apple.com/documentation/corefoundation/cfrunloopgetcurrent()?language=objc
https://developer.apple.com/documentation/corefoundation/cfrunloopgetmain()?language=objc

* Source/WebKit/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidConnection.mm:
(WebKit::HidConnection::initialize):
(WebKit::HidConnection::terminate):
* Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm:
(WebKit::HidService::~HidService):
(WebKit::HidService::platformStartDiscovery):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::computeHasVisualSearchResults):
* Source/WebKit/WebProcess/WebPage/WebDisplayRefreshMonitor.cpp:
(WebKit::WebDisplayRefreshMonitor::startNotificationMechanism):
* Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm:
(WebKit::WebPushToolVerb::done):

Canonical link: https://commits.webkit.org/300027@main

Author: fred-wang

Source/WebKit/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations

@@ -140,7 +140,6 @@ UIProcess/RemoteLayerTree/mac/RemoteLayerTreeDrawingAreaProxyMac.mm
 UIProcess/RemoteLayerTree/mac/RemoteLayerTreeEventDispatcher.mm
 UIProcess/WebAuthentication/Cocoa/CcidConnection.mm
 UIProcess/WebAuthentication/Cocoa/HidConnection.mm
-UIProcess/WebAuthentication/Cocoa/HidService.mm
 UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
 UIProcess/WebAuthentication/Cocoa/LocalConnection.mm
 UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
@@ -178,7 +177,6 @@ WebProcess/Plugins/PDF/WKAccessibilityPDFDocumentObject.mm
 WebProcess/WebPage/Cocoa/WebPageCocoa.mm
 WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm
 WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm
-WebProcess/WebPage/WebDisplayRefreshMonitor.cpp
 WebProcess/WebPage/WebPage.cpp
 WebProcess/WebPage/mac/PageBannerMac.mm
 WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm
@@ -191,4 +189,3 @@ webpushd/WebPushDaemon.mm
 webpushd/WebPushDaemonMain.mm
 webpushd/_WKMockUserNotificationCenter.mm
 webpushd/webpushtool/WebPushToolConnection.mm
-webpushd/webpushtool/WebPushToolMain.mm

Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidConnection.mm

@@ -76,7 +76,7 @@ static void reportReceived(void* context, IOReturn status, void*, IOHIDReportTyp
 {
 #if HAVE(SECURITY_KEY_API)
     IOHIDDeviceOpen(m_device.get(), kIOHIDOptionsTypeSeizeDevice);
-    IOHIDDeviceScheduleWithRunLoop(m_device.get(), CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
+    IOHIDDeviceScheduleWithRunLoop(m_device.get(), retainPtr(CFRunLoopGetCurrent()).get(), kCFRunLoopDefaultMode);
     m_inputBuffer.resize(kHidMaxPacketSize);
     IOHIDDeviceRegisterInputReportCallback(m_device.get(), m_inputBuffer.mutableSpan().data(), m_inputBuffer.size(), &reportReceived, this);
 #endif
@@ -87,7 +87,7 @@ static void reportReceived(void* context, IOReturn status, void*, IOHIDReportTyp
 {
 #if HAVE(SECURITY_KEY_API)
     IOHIDDeviceRegisterInputReportCallback(m_device.get(), m_inputBuffer.mutableSpan().data(), m_inputBuffer.size(), nullptr, nullptr);
-    IOHIDDeviceUnscheduleFromRunLoop(m_device.get(), CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
+    IOHIDDeviceUnscheduleFromRunLoop(m_device.get(), retainPtr(CFRunLoopGetCurrent()).get(), kCFRunLoopDefaultMode);
     IOHIDDeviceClose(m_device.get(), kIOHIDOptionsTypeNone);
 #endif
     m_isInitialized = false;

Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm

@@ -73,7 +73,7 @@ static void deviceRemovedCallback(void* context, IOReturn, void*, IOHIDDeviceRef
 HidService::~HidService()
 {
 #if HAVE(SECURITY_KEY_API)
-    IOHIDManagerUnscheduleFromRunLoop(m_manager.get(), CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
+    IOHIDManagerUnscheduleFromRunLoop(m_manager.get(), retainPtr(CFRunLoopGetCurrent()).get(), kCFRunLoopDefaultMode);
     IOHIDManagerClose(m_manager.get(), kIOHIDOptionsTypeNone);
 #endif
 }
@@ -86,7 +86,7 @@ static void deviceRemovedCallback(void* context, IOReturn, void*, IOHIDDeviceRef
 void HidService::platformStartDiscovery()
 {
 #if HAVE(SECURITY_KEY_API)
-    IOHIDManagerScheduleWithRunLoop(m_manager.get(), CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
+    IOHIDManagerScheduleWithRunLoop(m_manager.get(), retainPtr(CFRunLoopGetCurrent()).get(), kCFRunLoopDefaultMode);
     IOHIDManagerOpen(m_manager.get(), kIOHIDOptionsTypeNone);
 #endif
 }

Source/WebKit/UIProcess/mac/WebViewImpl.mm

@@ -6976,11 +6976,12 @@ static NSTextAlignment nsTextAlignmentFromTextAlignment(TextAlignment textAlignm
     auto startTime = MonotonicTime::now();
     [ensureImageAnalyzer() processRequest:request.get() progressHandler:nil completionHandler:makeBlockPtr([completion = WTFMove(completion), startTime] (CocoaImageAnalysis *analysis, NSError *) mutable {
         BOOL result = [analysis hasResultsForAnalysisTypes:VKAnalysisTypeVisualSearch];
-        CFRunLoopPerformBlock(CFRunLoopGetMain(), (__bridge CFStringRef)NSEventTrackingRunLoopMode, makeBlockPtr([completion = WTFMove(completion), result, startTime] () mutable {
+        RetainPtr loop = CFRunLoopGetMain();
+        CFRunLoopPerformBlock(loop.get(), (__bridge CFStringRef)NSEventTrackingRunLoopMode, makeBlockPtr([completion = WTFMove(completion), result, startTime] () mutable {
             RELEASE_LOG(ImageAnalysis, "Image analysis completed in %.0f ms (found visual search results? %d)", (MonotonicTime::now() - startTime).milliseconds(), result);
             completion(result);
         }).get());
-        CFRunLoopWakeUp(CFRunLoopGetMain());
+        CFRunLoopWakeUp(loop.get());
     }).get()];
 }
 

Source/WebKit/WebProcess/WebPage/WebDisplayRefreshMonitor.cpp

@@ -93,7 +93,7 @@ bool WebDisplayRefreshMonitor::startNotificationMechanism()
         });
     }
 
-    m_runLoopObserver->schedule(CFRunLoopGetCurrent());
+    m_runLoopObserver->schedule(retainPtr(CFRunLoopGetCurrent()).get());
 #endif
     m_displayLinkIsActive = true;
 

Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm

@@ -172,7 +172,7 @@ static bool registerDaemonWithLaunchD(WebPushTool::PreferTestService preferTestS
 public:
     virtual ~WebPushToolVerb() = default;
     virtual void run(WebPushTool::Connection&) = 0;
-    virtual void done() { CFRunLoopStop(CFRunLoopGetMain()); }
+    virtual void done() { CFRunLoopStop(retainPtr(CFRunLoopGetMain()).get()); }
 };
 
 class InjectPushMessageVerb : public WebPushToolVerb {