Embed version into artifact and player script error.

Author: devoxin

common/build.gradle.kts

@@ -1,5 +1,6 @@
 import com.vanniktech.maven.publish.JavaLibrary
 import com.vanniktech.maven.publish.JavadocJar
+import org.apache.tools.ant.filters.ReplaceTokens
 
 plugins {
     `java-library`
@@ -24,3 +25,13 @@ dependencies {
 mavenPublishing {
     configure(JavaLibrary(JavadocJar.Javadoc()))
 }
+
+tasks {
+    processResources {
+        filter<ReplaceTokens>(
+            "tokens" to mapOf(
+                "version" to project.version
+            )
+        )
+    }
+}

common/src/main/java/dev/lavalink/youtube/YoutubeSource.java

@@ -0,0 +1,25 @@
+package dev.lavalink.youtube;
+
+import java.io.IOException;
+import java.io.InputStream;
+
+public class YoutubeSource {
+    public static String VERSION = "Unknown";
+
+    static {
+        try (InputStream versionStream = YoutubeSource.class.getResourceAsStream("/version.txt")) {
+            if (versionStream != null) {
+                byte[] content = new byte[versionStream.available()];
+                versionStream.read(content);
+
+                String versionS = new String(content);
+
+                if (!versionS.startsWith("@")) {
+                    VERSION = versionS;
+                }
+            }
+        } catch (IOException ignored) {
+
+        }
+    }
+}

common/src/main/java/dev/lavalink/youtube/cipher/SignatureCipherManager.java

@@ -4,6 +4,7 @@
 import com.sedmelluq.discord.lavaplayer.tools.ExceptionTools;
 import com.sedmelluq.discord.lavaplayer.tools.io.HttpClientTools;
 import com.sedmelluq.discord.lavaplayer.tools.io.HttpInterface;
+import dev.lavalink.youtube.YoutubeSource;
 import dev.lavalink.youtube.track.format.StreamFormat;
 import org.apache.http.client.methods.CloseableHttpResponse;
 import org.apache.http.client.methods.HttpGet;
@@ -218,8 +219,8 @@ private void dumpProblematicScript(@NotNull String script, @NotNull String sourc
       Path path = Files.createTempFile("lavaplayer-yt-player-script", ".js");
       Files.write(path, script.getBytes(StandardCharsets.UTF_8));
 
-      log.error("Problematic YouTube player script {} detected (issue detected with script: {}). Dumped to {}",
-          sourceUrl, issue, path.toAbsolutePath());
+      log.error("Problematic YouTube player script {} detected (issue detected with script: {}). Dumped to {} (Source version: {})",
+          sourceUrl, issue, path.toAbsolutePath(), YoutubeSource.VERSION);
     } catch (Exception e) {
       log.error("Failed to dump problematic YouTube player script {} (issue detected with script: {})", sourceUrl, issue);
     }

common/src/main/resources/version.txt

@@ -0,0 +1 @@
+@version@

plugin/src/main/java/dev/lavalink/youtube/plugin/PluginInfo.java

@@ -4,6 +4,7 @@
 import com.grack.nanojson.JsonObject;
 import com.grack.nanojson.JsonParser;
 import com.grack.nanojson.JsonParserException;
+import dev.lavalink.youtube.YoutubeSource;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -15,7 +16,6 @@
 
 public class PluginInfo {
     private static final Logger log = LoggerFactory.getLogger(PluginInfo.class);
-    public static final String VERSION = getPluginVersion();
 
     static {
         try {
@@ -25,27 +25,14 @@ public class PluginInfo {
         }
     }
 
-    public static String getPluginVersion() {
-        try (InputStream properties = PluginInfo.class.getClassLoader().getResourceAsStream("lavalink-plugins/youtube-plugin.properties")) {
-            Properties props = new Properties();
-            props.load(properties);
-
-            if (props.containsKey("version")) {
-                return props.getProperty("version");
-            }
-        } catch (IOException ignored) {
-
-        }
-
-        return "Unknown";
-    }
-
     public static void checkForNewRelease() throws IOException, JsonParserException {
-        if ("Unknown".equals(VERSION)) {
+        String versionS = YoutubeSource.VERSION;
+
+        if ("Unknown".equals(versionS)) {
             return; // Cannot compare versions.
         }
 
-        Version currentVersion = Version.parse(VERSION);
+        Version currentVersion = Version.parse(versionS);
 
         URL url = new URL("https://api.github.com/repos/lavalink-devs/youtube-source/releases");