Merge pull request #50 from faekiva/fix-postgres-backup #patch

fix: changed container hostname source to find databases using another container's networking

Author: lawndoc

src/restic_compose_backup/containers.py

@@ -14,32 +14,34 @@
 
 class Container:
     """Represents a docker container"""
+
     container_type = None
 
     def __init__(self, data: dict):
         self._data = data
-        self._state = data.get('State')
-        self._config = data.get('Config')
-        self._mounts = [Mount(mnt, container=self) for mnt in data.get('Mounts')]
+        self._state = data.get("State")
+        self._config = data.get("Config")
+        self._mounts = [Mount(mnt, container=self) for mnt in data.get("Mounts")]
 
         if not self._state:
-            raise ValueError('Container meta missing State')
+            raise ValueError("Container meta missing State")
         if self._config is None:
-            raise ValueError('Container meta missing Config')
+            raise ValueError("Container meta missing Config")
 
-        self._labels = self._config.get('Labels')
+        self._labels = self._config.get("Labels")
         if self._labels is None:
-            raise ValueError('Container meta missing Config->Labels')
+            raise ValueError("Container meta missing Config->Labels")
 
         self._include = self._parse_pattern(self.get_label(enums.LABEL_VOLUMES_INCLUDE))
         self._exclude = self._parse_pattern(self.get_label(enums.LABEL_VOLUMES_EXCLUDE))
 
     @property
-    def instance(self) -> 'Container':
+    def instance(self) -> "Container":
         """Container: Get a service specific subclass instance"""
         # TODO: Do this smarter in the future (simple registry)
         if self.database_backup_enabled:
             from restic_compose_backup import containers_db
+
             if self.mariadb_backup_enabled:
                 return containers_db.MariadbContainer(self._data)
             if self.mysql_backup_enabled:
@@ -52,28 +54,29 @@ def instance(self) -> 'Container':
     @property
     def id(self) -> str:
         """str: The id of the container"""
-        return self._data.get('Id')
+        return self._data.get("Id")
 
     @property
     def hostname(self) -> str:
-        """12 character hostname based on id"""
-        return self.id[:12]
+        """Hostname of the container"""
+        return self.get_config("Hostname", default=self.id[0:12])
 
     @property
     def image(self) -> str:
         """Image name"""
-        return self.get_config('Image')
+        return self.get_config("Image")
 
     @property
     def name(self) -> str:
         """Container name"""
-        return self._data['Name'].replace('/', '')
+        return self._data["Name"].replace("/", "")
 
     @property
     def service_name(self) -> str:
         """Name of the container/service"""
-        return self.get_label('com.docker.compose.service', default='') or \
-            self.get_label('com.docker.swarm.service.name', default='')
+        return self.get_label(
+            "com.docker.compose.service", default=""
+        ) or self.get_label("com.docker.swarm.service.name", default="")
 
     @property
     def backup_process_label(self) -> str:
@@ -83,7 +86,7 @@ def backup_process_label(self) -> str:
     @property
     def project_name(self) -> str:
         """str: Name of the compose setup"""
-        return self.get_label('com.docker.compose.project', default='')
+        return self.get_label("com.docker.compose.project", default="")
 
     @property
     def stack_name(self) -> str:
@@ -93,28 +96,28 @@ def stack_name(self) -> str:
     @property
     def is_oneoff(self) -> bool:
         """Was this container started with run command?"""
-        return self.get_label('com.docker.compose.oneoff', default='False') == 'True'
+        return self.get_label("com.docker.compose.oneoff", default="False") == "True"
 
     @property
     def environment(self) -> list:
         """All configured env vars for the container as a list"""
-        return self.get_config('Env')
+        return self.get_config("Env")
 
     def remove(self):
         self._data.remove()
 
     def get_config_env(self, name) -> str:
         """Get a config environment variable by name"""
         # convert to dict and fetch env var by name
-        data = {i[0:i.find('=')]: i[i.find('=') + 1:] for i in self.environment}
+        data = {i[0 : i.find("=")]: i[i.find("=") + 1 :] for i in self.environment}
         return data.get(name)
 
     def set_config_env(self, name, value):
         """Set an environment variable"""
         env = self.environment
-        new_value = f'{name}={value}'
+        new_value = f"{name}={value}"
         for i, entry in enumerate(env):
-            if f'{name}=' in entry:
+            if f"{name}=" in entry:
                 env[i] = new_value
                 break
         else:
@@ -129,19 +132,21 @@ def volumes(self) -> dict:
         volumes = {}
         for mount in self._mounts:
             volumes[mount.source] = {
-                'bind': mount.destination,
-                'mode': 'rw',
+                "bind": mount.destination,
+                "mode": "rw",
             }
 
         return volumes
 
     @property
     def backup_enabled(self) -> bool:
         """Is backup enabled for this container?"""
-        return any([
-            self.volume_backup_enabled,
-            self.database_backup_enabled,
-        ])
+        return any(
+            [
+                self.volume_backup_enabled,
+                self.database_backup_enabled,
+            ]
+        )
 
     @property
     def volume_backup_enabled(self) -> bool:
@@ -155,50 +160,63 @@ def volume_backup_enabled(self) -> bool:
     @property
     def database_backup_enabled(self) -> bool:
         """bool: Is database backup enabled in any shape or form?"""
-        return any([
-            self.mysql_backup_enabled,
-            self.mariadb_backup_enabled,
-            self.postgresql_backup_enabled,
-        ])
+        return any(
+            [
+                self.mysql_backup_enabled,
+                self.mariadb_backup_enabled,
+                self.postgresql_backup_enabled,
+            ]
+        )
 
     @property
     def mysql_backup_enabled(self) -> bool:
         """bool: If the ``stack-back.mysql`` label is set"""
         explicity_enabled = utils.is_true(self.get_label(enums.LABEL_MYSQL_ENABLED))
         explicity_disabled = utils.is_false(self.get_label(enums.LABEL_MYSQL_ENABLED))
-        automatically_enabled = utils.is_true(config.auto_backup_all) and self.image.startswith('mysql:')
+        automatically_enabled = utils.is_true(
+            config.auto_backup_all
+        ) and self.image.startswith("mysql:")
         return explicity_enabled or (automatically_enabled and not explicity_disabled)
 
     @property
     def mariadb_backup_enabled(self) -> bool:
         """bool: If the ``stack-back.mariadb`` label is set"""
         explicity_enabled = utils.is_true(self.get_label(enums.LABEL_MARIADB_ENABLED))
         explicity_disabled = utils.is_false(self.get_label(enums.LABEL_MARIADB_ENABLED))
-        automatically_enabled = utils.is_true(config.auto_backup_all) and self.image.startswith('mariadb:')
+        automatically_enabled = utils.is_true(
+            config.auto_backup_all
+        ) and self.image.startswith("mariadb:")
         return explicity_enabled or (automatically_enabled and not explicity_disabled)
 
     @property
     def postgresql_backup_enabled(self) -> bool:
         """bool: If the ``stack-back.postgres`` label is set"""
         explicity_enabled = utils.is_true(self.get_label(enums.LABEL_POSTGRES_ENABLED))
-        explicity_disabled = utils.is_false(self.get_label(enums.LABEL_POSTGRES_ENABLED))
-        automatically_enabled = utils.is_true(config.auto_backup_all) and self.image.startswith('postgres:')
+        explicity_disabled = utils.is_false(
+            self.get_label(enums.LABEL_POSTGRES_ENABLED)
+        )
+        automatically_enabled = utils.is_true(
+            config.auto_backup_all
+        ) and self.image.startswith("postgres:")
         return explicity_enabled or (automatically_enabled and not explicity_disabled)
 
     @property
     def stop_during_backup(self) -> bool:
         """bool: If the ``stack-back.volumes.stop-during-backup`` label is set"""
-        return utils.is_true(self.get_label(enums.LABEL_STOP_DURING_BACKUP)) and not self.database_backup_enabled
+        return (
+            utils.is_true(self.get_label(enums.LABEL_STOP_DURING_BACKUP))
+            and not self.database_backup_enabled
+        )
 
     @property
     def is_backup_process_container(self) -> bool:
         """Is this container the running backup process?"""
-        return self.get_label(self.backup_process_label) == 'True'
+        return self.get_label(self.backup_process_label) == "True"
 
     @property
     def is_running(self) -> bool:
         """bool: Is the container running?"""
-        return self._state.get('Running', False)
+        return self._state.get("Running", False)
 
     def get_config(self, name, default=None):
         """Get value from config dict"""
@@ -215,7 +233,11 @@ def filter_mounts(self):
 
         # If exclude_bind_mounts is true, only volume mounts are kept in the list of mounts
         exclude_bind_mounts = utils.is_true(config.exclude_bind_mounts)
-        mounts = list(filter(lambda m: not exclude_bind_mounts or m.type == "volume", self._mounts))
+        mounts = list(
+            filter(
+                lambda m: not exclude_bind_mounts or m.type == "volume", self._mounts
+            )
+        )
 
         if not self.volume_backup_enabled:
             return filtered
@@ -239,20 +261,23 @@ def filter_mounts(self):
                     filtered.append(mount)
         else:
             for mount in mounts:
-                if self.database_backup_enabled and mount.destination in database_mounts:
+                if (
+                    self.database_backup_enabled
+                    and mount.destination in database_mounts
+                ):
                     continue
                 filtered.append(mount)
 
         return filtered
 
-    def volumes_for_backup(self, source_prefix='/volumes', mode='ro'):
+    def volumes_for_backup(self, source_prefix="/volumes", mode="ro"):
         """Get volumes configured for backup"""
         mounts = self.filter_mounts()
         volumes = {}
         for mount in mounts:
             volumes[mount.source] = {
-                'bind': self.get_volume_backup_destination(mount, source_prefix),
-                'mode': mode,
+                "bind": self.get_volume_backup_destination(mount, source_prefix),
+                "mode": mode,
             }
 
         return volumes
@@ -263,7 +288,7 @@ def get_volume_backup_destination(self, mount, source_prefix) -> str:
 
         if utils.is_true(config.include_project_name):
             project_name = self.project_name
-            if project_name != '':
+            if project_name != "":
                 destination /= project_name
 
         destination /= self.service_name
@@ -303,7 +328,7 @@ def _parse_pattern(self, value: str) -> List[str]:
         if len(value) == 0:
             return None
 
-        return value.split(',')
+        return value.split(",")
 
     def __eq__(self, other):
         """Compare container by id"""
@@ -324,6 +349,7 @@ def __str__(self):
 
 class Mount:
     """Represents a volume mount (volume or bind)"""
+
     def __init__(self, data, container=None):
         self._data = data
         self._container = container
@@ -336,22 +362,22 @@ def container(self) -> Container:
     @property
     def type(self) -> str:
         """bind/volume"""
-        return self._data.get('Type')
+        return self._data.get("Type")
 
     @property
     def name(self) -> str:
         """Name of the mount"""
-        return self._data.get('Name')
+        return self._data.get("Name")
 
     @property
     def source(self) -> str:
         """Source of the mount. Volume name or path"""
-        return self._data.get('Source')
+        return self._data.get("Source")
 
     @property
     def destination(self) -> str:
         """Destination path for the volume mount in the container"""
-        return self._data.get('Destination')
+        return self._data.get("Destination")
 
     def __repr__(self) -> str:
         return str(self)
@@ -382,7 +408,7 @@ def __init__(self):
         # Find the container we are running in.
         # If we don't have this information we cannot continue
         for container_data in all_containers:
-            if container_data.get('Id').startswith(os.environ['HOSTNAME']):
+            if container_data.get("Id").startswith(os.environ["HOSTNAME"]):
                 self.this_container = Container(container_data)
 
         if not self.this_container:
@@ -393,9 +419,11 @@ def __init__(self):
             container = Container(container_data)
 
             # Gather stale backup process containers
-            if (self.this_container.image == container.image
-                    and not container.is_running
-                    and container.is_backup_process_container):
+            if (
+                self.this_container.image == container.image
+                and not container.is_running
+                and container.is_backup_process_container
+            ):
                 self.stale_backup_process_containers.append(container)
 
             # We only care about running containers after this point
@@ -450,12 +478,14 @@ def containers_for_backup(self):
         """Obtain all containers with backup enabled"""
         return [container for container in self.containers if container.backup_enabled]
 
-    def generate_backup_mounts(self, dest_prefix='/volumes') -> dict:
+    def generate_backup_mounts(self, dest_prefix="/volumes") -> dict:
         """Generate mounts for backup for the entire compose setup"""
         mounts = {}
         for container in self.containers_for_backup():
             if container.volume_backup_enabled:
-                mounts.update(container.volumes_for_backup(source_prefix=dest_prefix, mode='ro'))
+                mounts.update(
+                    container.volumes_for_backup(source_prefix=dest_prefix, mode="ro")
+                )
 
         return mounts