Changes following PR comments

Author: lucdion

Sources/Impl/PinLayout+Coordinates.swift

@@ -328,7 +328,7 @@ extension PinLayout {
     }
 
     internal func validateWidth(_ width: CGFloat, context: Context) -> Bool {
-        guard width.isNormal && width >= 0  else {
+        guard width >= 0, width.isFinite else {
             warnWontBeApplied("the width (\(width)) must be greater than or equal to zero.", context)
             return false
         }
@@ -337,15 +337,15 @@ extension PinLayout {
     }
 
     internal func validateComputedWidth(_ width: CGFloat?) -> Bool {
-        if let width = width, !width.isNormal || width < 0 {
+        if let width = width, !width.isFinite || width < 0 {
             return false
         } else {
             return true
         }
     }
 
     internal func validateHeight(_ height: CGFloat, context: Context) -> Bool {
-        guard height.isNormal && height >= 0 else {
+        guard height >= 0, height.isFinite else {
             warnWontBeApplied("the height (\(height)) must be greater than or equal to zero.", context)
             return false
         }
@@ -354,7 +354,7 @@ extension PinLayout {
     }
 
     internal func validateComputedHeight(_ height: CGFloat?) -> Bool {
-        if let height = height, !height.isNormal || height < 0 {
+        if let height = height, !height.isFinite || height < 0 {
             return false
         } else {
             return true

Tests/Common/AdjustSizeSpec.swift

@@ -115,6 +115,12 @@ class AdjustSizeSpec: QuickSpec {
                 expect(aView.frame).to(equal(CGRect(x: 140.0, y: 100.0, width: 50.0, height: 60.0)))
             }
 
+            it("should accept a width of 0") {
+                aView.pin.width(0)
+                expect(Pin.lastWarningText).to(beNil())
+                expect(aView.frame).to(equal(CGRect(x: 140, y: 100.0, width: 0.0, height: 60.0)))
+            }
+            
             it("should warn about negative width value") {
                 aView.pin.width(-2)
                 expect(Pin.lastWarningText).to(contain(["width", "won't be applied", "the width", "must be greater than or equal to zero"]))
@@ -127,11 +133,23 @@ class AdjustSizeSpec: QuickSpec {
                expect(aView.frame).to(equal(CGRect(x: 140, y: 100.0, width: 100.0, height: 60.0)))
             }
 
+            it("should warn about -NaN width value") {
+                aView.pin.width(-CGFloat.nan)
+               expect(Pin.lastWarningText).to(contain(["width", "nan", "won't be applied", "the width", "must be greater than or equal to zero"]))
+               expect(aView.frame).to(equal(CGRect(x: 140, y: 100.0, width: 100.0, height: 60.0)))
+            }
+            
             it("should warn about infinity width value") {
                 aView.pin.width(CGFloat.infinity)
                expect(Pin.lastWarningText).to(contain(["width", "inf", "won't be applied", "the width", "must be greater than or equal to zero"]))
                expect(aView.frame).to(equal(CGRect(x: 140, y: 100.0, width: 100.0, height: 60.0)))
             }
+            
+            it("should warn about -infinity width value") {
+                aView.pin.width(-CGFloat.infinity)
+               expect(Pin.lastWarningText).to(contain(["width", "inf", "won't be applied", "the width", "must be greater than or equal to zero"]))
+               expect(aView.frame).to(equal(CGRect(x: 140, y: 100.0, width: 100.0, height: 60.0)))
+            }
         }
 
         describe("the result of the height(...) methods") {
@@ -166,6 +184,12 @@ class AdjustSizeSpec: QuickSpec {
                 expect(aView.frame).to(equal(CGRect(x: 140.0, y: 100.0, width: 100.0, height: 30.0)))
             }
 
+            it("should accept a height of 0") {
+                aView.pin.height(0)
+                expect(Pin.lastWarningText).to(beNil())
+                expect(aView.frame).to(equal(CGRect(x: 140, y: 100.0, width: 100.0, height: 0.0)))
+            }
+            
             it("should warn about negative height value") {
                 aView.pin.height(-2)
                 expect(Pin.lastWarningText).to(contain(["height", "won't be applied", "the height", "must be greater than or equal to zero"]))
@@ -178,11 +202,23 @@ class AdjustSizeSpec: QuickSpec {
                expect(aView.frame).to(equal(CGRect(x: 140, y: 100.0, width: 100.0, height: 60.0)))
             }
 
+            it("should warn about -NaN height value") {
+                aView.pin.height(-CGFloat.nan)
+               expect(Pin.lastWarningText).to(contain(["height", "nan", "won't be applied", "the height", "must be greater than or equal to zero"]))
+               expect(aView.frame).to(equal(CGRect(x: 140, y: 100.0, width: 100.0, height: 60.0)))
+            }
+            
             it("should warn about infinity height value") {
                 aView.pin.height(CGFloat.infinity)
                expect(Pin.lastWarningText).to(contain(["height", "inf", "won't be applied", "the height", "must be greater than or equal to zero"]))
                expect(aView.frame).to(equal(CGRect(x: 140, y: 100.0, width: 100.0, height: 60.0)))
             }
+            
+            it("should warn about -infinity height value") {
+                aView.pin.height(-CGFloat.infinity)
+               expect(Pin.lastWarningText).to(contain(["height", "inf", "won't be applied", "the height", "must be greater than or equal to zero"]))
+               expect(aView.frame).to(equal(CGRect(x: 140, y: 100.0, width: 100.0, height: 60.0)))
+            }
         }
 
         describe("the result of the size(...) methods") {