Add Pin.activeWarnings.aspectRatioImageNotSet

Author: Luc Dion

README.md

@@ -1591,6 +1591,8 @@ Few individual warnings can also be enabled/disabled individually:
 
 * **`Pin.activeWarnings.noSpaceAvailableBetweenViews: Boolean`**  
 If true, a warning is displayed if there is no space available between views specified in a call to `horizontallyBetween(...)` or `verticallyBetween(...)`
+* **`Pin.activeWarnings. aspectRatioImageNotSet: Boolean`**  
+If true, a warning is displayed if 'aspectRatio()' is called on a UIImageView without a valid UIImage.
 
 <br/>
 

Sources/Pin.swift

@@ -76,7 +76,10 @@ import Foundation
 }
 
 @objc public class ActiveWarnings: NSObject {
-    /// When set to true, a warning will be issue in Debug if there is no space available between views
-    /// specified in a call to `horizontallyBetween(...)` or `verticallyBetween(...)`
+    /// When set to true, a warning is displayed if there is no space available between views
+    /// specified in a call to `horizontallyBetween(...)` or `verticallyBetween(...)`.
     public var noSpaceAvailableBetweenViews = true
+
+    /// When set to true, a warning is displayed if 'aspectRatio()' is called on a UIImageView without a valid UIImage.
+    public var aspectRatioImageNotSet = true
 }

Sources/PinLayout+Between.swift

@@ -66,7 +66,7 @@ extension PinLayout {
             setRight(view1MinX, context)
             applyVerticalAlignment(aligned, coordinates: [coordinates[1]], context: context)
         } else {
-            guard Pin.activeWarnings.noSpaceAvailableBetweenViews else { return self }
+            guard Pin.logWarnings && Pin.activeWarnings.noSpaceAvailableBetweenViews else { return self }
             warnWontBeApplied("there is no horizontal space between these views. (noSpaceAvailableBetweenViews)", context)
         }
 
@@ -120,7 +120,7 @@ extension PinLayout {
             setBottom(view1MinY, context)
             applyHorizontalAlignment(aligned, coordinates: [coordinates[1]], context: context)
         } else {
-            guard Pin.activeWarnings.noSpaceAvailableBetweenViews else { return self }
+            guard Pin.logWarnings && Pin.activeWarnings.noSpaceAvailableBetweenViews else { return self }
             warnWontBeApplied("there is no vertical space between these views. (noSpaceAvailableBetweenViews)", context)
         }
 

Sources/PinLayout+Size.swift

@@ -144,12 +144,13 @@ extension PinLayout {
     public func aspectRatio() -> PinLayout {
         func context() -> String { return "aspectRatio()" }
         guard let imageView = view as? UIImageView else {
-            warnWontBeApplied("the layouted must be an UIImageView() to use the aspectRatio() method without parameter.", context)
+            warnWontBeApplied("the layouted view must be an UIImageView() to use the aspectRatio() method without parameter.", context)
             return self
         }
 
         guard let imageSize = imageView.image?.size else {
-            warnWontBeApplied("the layouted UIImageView's image hasn't been set", context)
+            guard Pin.logWarnings && Pin.activeWarnings.aspectRatioImageNotSet else { return self }
+            warnWontBeApplied("the layouted UIImageView's image hasn't been set (aspectRatioImageNotSet)", context)
             return self
         }
 

Tests/Common/AspectRatioTests.swift

@@ -65,6 +65,11 @@ class AspectRatioTests: QuickSpec {
             rootView.addSubview(imageView)
             #endif
         }
+
+        afterEach {
+            _pinlayoutSetUnitTest(scale: nil)
+            Pin.resetWarnings()
+        }
 
         //
         // aspectRatio(: CGFloat)
@@ -166,9 +171,27 @@ class AspectRatioTests: QuickSpec {
         describe("the result of the aspectRatio(CGFloat)") {
             it("should warn about aspectRatio()") {
                 aView.pin.left().width(100).aspectRatio()
-                expect(Pin.lastWarningText).to(contain(["aspectRatio() won't be applied", "the layouted must be an UIImageView()"]))
+                expect(Pin.lastWarningText).to(contain(["aspectRatio() won't be applied", "the layouted view must be an UIImageView()"]))
                 expect(aView.frame).to(equal(CGRect(x: 0.0, y: 100.0, width: 100.0, height: 100.0)))
             }
+
+            it("should warn about aspectRatio() if no image is set") {
+                imageView.image = nil
+                imageView.pin.left().width(100).aspectRatio()
+                expect(Pin.lastWarningText).to(contain(["aspectRatio() won't be applied", "the layouted UIImageView's image hasn't been set (aspectRatioImageNotSet)"]))
+            }
+
+            it("should not warn about aspectRatio() if no image is set") {
+                Pin.activeWarnings.aspectRatioImageNotSet = false
+                imageView.image = nil
+                imageView.pin.left().width(100).aspectRatio()
+                expect(Pin.lastWarningText).to(beNil())
+                expect(imageView.frame).to(equal(CGRect(x: 0.0, y: 10.0, width: 100.0, height: 60.0)))
+            }
+
+//            guard Pin.logWarnings &&  else { return self }
+//            warnWontBeApplied(")", context)
+
 
             it("should warn about aspectRatio()") {
                 imageView.pin.left().aspectRatio()