Skip to content

Commit 254d0db

Browse files
authored
update NEWS and README (#40)
1 parent 9877bc3 commit 254d0db

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

NEWS.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212

1313
* converted shared library to C++
1414

15+
* bugfix: group terminate in Windows
16+
17+
1518
# subprocess 0.7.4
1619

1720
* initial submission to CRAN; basic API works in Linux and Windows

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ print(handle)
4040
And here is what the child process has sent so far to its output streams:
4141

4242
```r
43-
process_read(handle, timeout = 1000)
43+
process_read(handle, PIPE_STDOUT, timeout = TIMEOUT_INFINITE)
4444
#> [1] "Welcome to Ubuntu 16.10 (GNU/Linux 4.8.0-27-generic x86_64)"
4545
#> [2] ""
4646
#> [3] " * Documentation: https://help.ubuntu.com"
@@ -60,7 +60,7 @@ to list files.
6060
```r
6161
process_write(handle, 'ls\n')
6262
#> [1] 3
63-
process_read(handle, timeout = 1000)
63+
process_read(handle, PIPE_STDOUT, timeout = TIMEOUT_INFINITE)
6464
#> [1] "Desktop" "Download" "examples.desktop"
6565
#> [4] "Music" "Public" "Video"
6666
process_read(handle, PIPE_STDERR)
@@ -78,7 +78,7 @@ We are now ready to close the connection by exiting the remote shell:
7878
```r
7979
process_write(handle, 'exit\n')
8080
#> [1] 5
81-
process_read(handle, timeout = TIMEOUT_INFINITE)
81+
process_read(handle, PIPE_STDOUT, timeout = TIMEOUT_INFINITE)
8282
#> character(0)
8383
process_read(handle, PIPE_STDERR)
8484
#> character(0)
@@ -87,7 +87,7 @@ process_read(handle, PIPE_STDERR)
8787
The last thing is making sure that the child process is no longer alive:
8888

8989
```r
90-
process_wait(handle)
90+
process_wait(handle, TIMEOUT_INFINITE)
9191
#> [1] 0
9292
process_status(handle)
9393
#> [1] "exited"

0 commit comments

Comments
 (0)