Fix logic related to obtain strings, closes #428

Author: sandbergja

app/components/obtain_online_component.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 
 class ObtainOnlineComponent < ViewComponent::Base
-  def initialize(size: :medium, document:)
+  attr_reader :string
+
+  def initialize(document:, size: :medium)
     @size = size
     @document = document
     @url = document_url
@@ -12,7 +14,9 @@ def initialize(size: :medium, document:)
   private
 
   def display_string
-    return t(format_i18n_string) if I18n.exists? format_i18n_string
+    return t('obtain.resource') if document_format.blank?
+
+    return t(format_i18n_string) if format_i18n_string
 
     t('obtain.general_online', type: document_format)
   end
@@ -27,8 +31,10 @@ def document_url
 
   def format_i18n_string
     raw_format = document_format
-    "obtain.#{raw_format.downcase.sub(' ', '_')}"
-  end
+    key = "obtain.#{raw_format.downcase.sub(' ', '_')}"
 
+    return nil unless I18n.exists? key
 
+    key
+  end
 end

app/views/bento/_catalog_results_list_author_date.html.erb

@@ -7,7 +7,7 @@
       <%= "(#{record.first(:author_display) || record.first(:pub_date)})" %>
     <% end %>
     <% if online_record? record %>
-    <%= link_to content_tag(:span, 'open_in_new', class: 'material-icons').prepend("#{t('obtain.catalog_record')} "),
+    <%= link_to content_tag(:span, 'open_in_new', class: 'material-icons').prepend("#{t('obtain.resource')} "),
             record.first(:url_fulltext_display), class: 'badge badge-success' %>
     <% elsif(evergreen_record? record) %>
     <%= render(EvergreenHoldingsComponent.new(size: :small, record_id: record.id, service: @evergreen_service)) %>

app/views/bento/_catalog_results_list_minimal.html.erb

@@ -7,7 +7,7 @@
       <%= "(#{record.first(:format) || record.first(:pub_date)})" %>
     <% end %>
     <% if online_record? record %>
-    <%= link_to content_tag(:span, 'open_in_new', class: 'material-icons').prepend("#{t('obtain.catalog_record')} "),
+    <%= link_to content_tag(:span, 'open_in_new', class: 'material-icons').prepend("#{t('obtain.resource')} "),
             record.first(:url_fulltext_display), class: 'badge badge-success' %>
     <% elsif(evergreen_record? record) %>
     <%= render(EvergreenHoldingsComponent.new(size: :small, record_id: record.id, service: @evergreen_service)) %>

config/locales/findit.en.yml

@@ -67,7 +67,7 @@ en:
     available_at: "Available at %{library} (%{location}): %{call_number}"
     unavailable_at: "%{library} owns a copy, but it is currently unavailable."
     available_at_partner_libraries: Available at Partner Libraries
-    catalog_record: Access resource online
+    resource: Access resource online
     ebook: Read ebook online
     general_online: "Access %{type} online"
     place_hold: Request curbside pickup

config/locales/findit.es.yml

@@ -50,7 +50,7 @@ es:
     unavailable: No disponible
     available_at: "Disponible en %{library} (%{location}): %{call_number}"
     unavailable_at: "Artículo de %{library} actualmente no disponible."
-    catalog_record: Acceder a este recurso
+    resource: Acceder a este recurso
     ebook: Leer ebook
     general_online: "Aceder %{type} en línea"
     place_hold: Recogida en la acera

spec/components/obtain_online_component_spec.rb

@@ -0,0 +1,25 @@
+require 'rails_helper'
+
+RSpec.describe ObtainOnlineComponent, type: :component do
+  it 'delivers a reasonable string when format is not known' do
+    component = described_class.new(document: SolrDocument.new('id' => '12345', 'title' => 'Hello World'))
+    expect(component.string).to eq(I18n.t('obtain.resource'))
+  end
+
+  it 'delivers a reasonable string when format is an empty string' do
+    component = described_class.new(document: SolrDocument.new('id' => '12345', 'format' => '', 'title' => 'Hello World'))
+    expect(component.string).to eq(I18n.t('obtain.resource'))
+  end
+
+  it 'delivers a customized string when format is Ebook' do
+    component = described_class.new(document: SolrDocument.new('id' => '12345', 'title' => 'Hello World',
+                                                               'format' => 'Ebook'))
+    expect(component.string).to eq(I18n.t('obtain.ebook'))
+  end
+
+  it 'delivers a customized string when format does not have its own predefined format' do
+    component = described_class.new(document: SolrDocument.new('id' => '12345', 'title' => 'Hello World',
+                                                               'format' => 'Espresso machine'))
+    expect(component.string).to eq(I18n.t('obtain.general_online', type: 'Espresso machine'))
+  end
+end