Only allow editing ICR-data for Agentschap Binnenlands Bestuur and Digitaal Vlaanderen (#93)

* Add ICR role check

* Only allow editing ICR data by correct role

* Store icr roles as constant

Co-authored-by: andreo141 <82985453+andreo141@users.noreply.github.com>

* Rename constant

* Merge branch 'development' into feature/abb-dv-icr

* Revert "Only allow editing ICR data by correct role"

This reverts commit 4a8c27c.

* Store ovo codes in environment

* Allow abb and dv to edit each other's processes

* Add process check for abb or dv

* Only show icr card on abb and dv processes

Author: MartijnBogaert

app/controllers/processes/process/index.js

@@ -128,7 +128,8 @@ export default class ProcessesProcessIndexController extends Controller {
       this.currentSession.canEdit &&
       this.currentSession.group &&
       this.process?.publisher &&
-      this.process.publisher.id === this.currentSession.group.id
+      (this.process.publisher.id === this.currentSession.group.id ||
+        (this.process.isPublishedByAbbOrDv && this.currentSession.isAbbOrDv))
     );
   }
 

app/models/group.js

@@ -2,6 +2,7 @@ import Model, { attr, belongsTo, hasMany } from '@ember-data/model';
 
 export default class GroupModel extends Model {
   @attr name;
+  @attr identifier;
   @belongsTo('site', { inverse: null, async: false }) primarySite;
   @belongsTo('administrative-unit-classification-code', {
     async: false,

app/models/process.js

@@ -85,4 +85,9 @@ export default class ProcessModel extends Model {
     );
     return diagramsSorted[0];
   }
+
+  get isPublishedByAbbOrDv() {
+    const ovoCodes = [ENV.ovoCodes.abb, ENV.ovoCodes.dv];
+    return ovoCodes.includes(this.publisher?.identifier);
+  }
 }

app/services/current-session.js

@@ -1,11 +1,13 @@
 import Service, { service } from '@ember/service';
 import { tracked } from '@glimmer/tracking';
+import ENV from 'frontend-openproceshuis/config/environment';
 
 const EDITOR_ROLES = [
   'LoketLB-OpenProcesHuisGebruiker',
   'LoketLB-OpenProcesHuisAfnemer',
 ];
 const ADMIN_ROLE = 'LoketLB-admin';
+const ABB_DV_IDENTIFIERS = [ENV.ovoCodes.abb, ENV.ovoCodes.dv];
 
 export default class CurrentSessionService extends Service {
   @service session;
@@ -48,12 +50,16 @@ export default class CurrentSessionService extends Service {
     return this.roles.some((role) => EDITOR_ROLES.includes(role));
   }
 
+  get isAbbOrDv() {
+    return ABB_DV_IDENTIFIERS.includes(this.group?.identifier);
+  }
+
   get canEdit() {
     return this.isAuthenticated && this.hasEditorRole;
   }
 
   get readOnly() {
-    return !this.isAdmin && this.isAuthenticated && !this.hasEditorRole;
+    return this.isAuthenticated && !this.isAdmin && !this.hasEditorRole;
   }
 
   get isAdmin() {

app/templates/processes/process/index.hbs

@@ -140,16 +140,18 @@
                   />
                 </:content>
               </Item>
-              <Item>
-                <:label>Blauwdruk</:label>
-                <:content>
-                  <AuToggleSwitch
-                    @onChange={{this.toggleBlueprintStatus}}
-                    @checked={{this.process.isBlueprint}}
-                    @disabled={{not this.canEdit}}
-                  />
-                </:content>
-              </Item>
+              {{#if this.process.isPublishedByAbbOrDv}}
+                <Item>
+                  <:label>Blauwdruk</:label>
+                  <:content>
+                    <AuToggleSwitch
+                      @onChange={{this.toggleBlueprintStatus}}
+                      @checked={{this.process.isBlueprint}}
+                      @disabled={{not this.canEdit}}
+                    />
+                  </:content>
+                </Item>
+              {{/if}}
             </:right>
           </Card.Columns>
         </:card>
@@ -242,15 +244,17 @@
                 />
               </:content>
             </Item>
-            <Item>
-              <:label>Blauwdruk</:label>
-              <:content>
-                <AuToggleSwitch
-                  @disabled={{not this.isEditing}}
-                  @checked={{this.process.isBlueprint}}
-                />
-              </:content>
-            </Item>
+            {{#if this.process.isPublishedByAbbOrDv}}
+              <Item>
+                <:label>Blauwdruk</:label>
+                <:content>
+                  <AuToggleSwitch
+                    @disabled={{not this.isEditing}}
+                    @checked={{this.process.isBlueprint}}
+                  />
+                </:content>
+              </Item>
+            {{/if}}
           </:right>
         </Card.Columns>
       </:card>
@@ -370,7 +374,7 @@
 
     {{! ICR }}
     <div class="au-o-grid__item">
-      {{#if this.process.isBlueprint}}
+      {{#if (and this.process.isBlueprint this.process.isPublishedByAbbOrDv)}}
         <Process::IcrCard @canEdit={{this.canEdit}} @process={{this.process}} />
       {{else}}
         <Process::BlueprintCard

config/environment.js

@@ -21,6 +21,11 @@ module.exports = function (environment) {
 
     appName: 'Open Proces Huis',
 
+    ovoCodes: {
+      abb: 'OVO001835',
+      dv: 'OVO002949',
+    },
+
     conceptSchemes: {
       bpmnElementTypes:
         'http://lblod.data.gift/concept-schemes/d4259f0b-6d6e-4a46-b9e1-114b774e0f1e',