Skip to content

Commit 16aed64

Browse files
[8.18] fix: [Analytics:Visualize Library page]Dialog modal missing title from announcement (elastic#217829) (elastic#218444)
# Backport This will backport the following commits from `main` to `8.18`: - [fix: [Analytics:Visualize Library page]Dialog modal missing title from announcement (elastic#217829)](elastic#217829) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-16T13:19:03Z","message":"fix: [Analytics:Visualize Library page]Dialog modal missing title from announcement (elastic#217829)\n\nCloses: elastic#215112\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n\n1. Added `aria-labelledby={flyoutTitleId}` for mentioned places","sha":"bf7389f515480a4d518e3a238c5fd54caac033f7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:prev-major","v9.1.0"],"title":"fix: [Analytics:Visualize Library page]Dialog modal missing title from announcement","number":217829,"url":"https://github.com/elastic/kibana/pull/217829","mergeCommit":{"message":"fix: [Analytics:Visualize Library page]Dialog modal missing title from announcement (elastic#217829)\n\nCloses: elastic#215112\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n\n1. Added `aria-labelledby={flyoutTitleId}` for mentioned places","sha":"bf7389f515480a4d518e3a238c5fd54caac033f7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217829","number":217829,"mergeCommit":{"message":"fix: [Analytics:Visualize Library page]Dialog modal missing title from announcement (elastic#217829)\n\nCloses: elastic#215112\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n\n1. Added `aria-labelledby={flyoutTitleId}` for mentioned places","sha":"bf7389f515480a4d518e3a238c5fd54caac033f7"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
1 parent 9556de5 commit 16aed64

File tree

7 files changed

+9
-17
lines changed

7 files changed

+9
-17
lines changed

src/platform/plugins/shared/visualizations/public/wizard/agg_based_selection/agg_based_selection.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class AggBasedSelection extends React.Component<AggBasedSelectionProps, AggBased
5858
return (
5959
<>
6060
<EuiModalHeader>
61-
<EuiModalHeaderTitle>
61+
<EuiModalHeaderTitle id="vis-wizard-modal-title">
6262
<FormattedMessage
6363
id="visualizations.newAggVisWizard.title"
6464
defaultMessage="New aggregation based visualization"

src/platform/plugins/shared/visualizations/public/wizard/group_selection/group_selection.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ function GroupSelection({
128128
return (
129129
<>
130130
<EuiModalHeader>
131-
<EuiModalHeaderTitle data-test-subj="groupModalHeader">
131+
<EuiModalHeaderTitle data-test-subj="groupModalHeader" id="vis-wizard-modal-title">
132132
<FormattedMessage
133133
id="visualizations.newVisWizard.title"
134134
defaultMessage="Create visualization"

src/platform/plugins/shared/visualizations/public/wizard/new_vis_modal.tsx

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import React from 'react';
1111

1212
import { EuiModal } from '@elastic/eui';
13-
import { i18n } from '@kbn/i18n';
1413

1514
import { METRIC_TYPE, UiCounterMetricType } from '@kbn/analytics';
1615
import { ApplicationStart, DocLinksStart, IUiSettingsClient } from '@kbn/core/public';
@@ -80,19 +79,15 @@ class NewVisModal extends React.Component<TypeSelectionProps, TypeSelectionState
8079
return null;
8180
}
8281

83-
const visNewVisDialogAriaLabel = i18n.translate(
84-
'visualizations.newVisWizard.helpTextAriaLabel',
85-
{
86-
defaultMessage:
87-
'Start creating your visualization by selecting a type for that visualization. Hit escape to close this modal. Hit Tab key to go further.',
88-
}
89-
);
90-
9182
const WizardComponent = this.state.isMainDialogShown ? GroupSelection : AggBasedSelection;
9283

9384
const selectionModal =
9485
this.state.showSearchVisModal && this.state.visType ? (
95-
<EuiModal onClose={this.onCloseModal} className="visNewVisSearchDialog">
86+
<EuiModal
87+
onClose={this.onCloseModal}
88+
className="visNewVisSearchDialog"
89+
aria-labelledby="vis-wizard-modal-title"
90+
>
9691
<SearchSelection
9792
contentClient={this.props.contentClient}
9893
uiSettings={this.props.uiSettings}
@@ -105,7 +100,7 @@ class NewVisModal extends React.Component<TypeSelectionProps, TypeSelectionState
105100
<EuiModal
106101
onClose={this.onCloseModal}
107102
className={this.state.isMainDialogShown ? 'visNewVisDialog' : 'visNewVisDialog--aggbased'}
108-
aria-label={visNewVisDialogAriaLabel}
103+
aria-labelledby="vis-wizard-modal-title"
109104
>
110105
<WizardComponent
111106
onVisTypeSelected={this.onVisTypeSelected}

src/platform/plugins/shared/visualizations/public/wizard/search_selection/search_selection.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export class SearchSelection extends React.Component<SearchSelectionProps> {
3232
return (
3333
<React.Fragment>
3434
<EuiModalHeader>
35-
<EuiModalHeaderTitle>
35+
<EuiModalHeaderTitle id="vis-wizard-modal-title">
3636
<FormattedMessage
3737
id="visualizations.newVisWizard.newVisTypeTitle"
3838
defaultMessage="New {visTypeName}"

x-pack/platform/plugins/private/translations/translations/fr-FR.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10161,7 +10161,6 @@
1016110161
"visualizations.newVisWizard.chooseSourceTitle": "Choisir une source",
1016210162
"visualizations.newVisWizard.filterVisTypeAriaLabel": "Filtrer un type de visualisation",
1016310163
"visualizations.newVisWizard.goBackLink": "Sélectionner une visualisation différente",
10164-
"visualizations.newVisWizard.helpTextAriaLabel": "Commencez à créer votre visualisation en sélectionnant un type pour cette visualisation. Appuyez sur Échap pour fermer ce mode. Appuyez sur Tab pour aller plus loin.",
1016510164
"visualizations.newVisWizard.learnMoreText": "Envie d'en savoir plus ?",
1016610165
"visualizations.newVisWizard.legacyTab": "Hérité",
1016710166
"visualizations.newVisWizard.legacyTabDescription": "Les visualisations héritées devraient être obsolètes à l’avenir.",

x-pack/platform/plugins/private/translations/translations/ja-JP.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10151,7 +10151,6 @@
1015110151
"visualizations.newVisWizard.chooseSourceTitle": "ソースの選択",
1015210152
"visualizations.newVisWizard.filterVisTypeAriaLabel": "ビジュアライゼーションのタイプでフィルタリング",
1015310153
"visualizations.newVisWizard.goBackLink": "別のビジュアライゼーションを選択",
10154-
"visualizations.newVisWizard.helpTextAriaLabel": "タイプを選択してビジュアライゼーションの作成を始めましょう。ESC を押してこのモーダルを閉じます。Tab キーを押して次に進みます。",
1015510154
"visualizations.newVisWizard.learnMoreText": "詳細について",
1015610155
"visualizations.newVisWizard.legacyTab": "レガシー",
1015710156
"visualizations.newVisWizard.legacyTabDescription": "廃止予定には、今後、レガシービジュアライゼーションが予定されています。",

x-pack/platform/plugins/private/translations/translations/zh-CN.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10169,7 +10169,6 @@
1016910169
"visualizations.newVisWizard.chooseSourceTitle": "选择源",
1017010170
"visualizations.newVisWizard.filterVisTypeAriaLabel": "筛留可视化类型",
1017110171
"visualizations.newVisWizard.goBackLink": "选择不同的可视化",
10172-
"visualizations.newVisWizard.helpTextAriaLabel": "通过为该可视化选择类型,开始创建您的可视化。按 Esc 键关闭此模式。按 Tab 键继续。",
1017310172
"visualizations.newVisWizard.learnMoreText": "希望了解详情?",
1017410173
"visualizations.newVisWizard.legacyTab": "旧版",
1017510174
"visualizations.newVisWizard.legacyTabDescription": "计划在未来弃用旧版可视化。",

0 commit comments

Comments
 (0)