Skip to content

Commit 85ce57c

Browse files
[8.18] fix: [Analytics:MachineLearning:AnomalyDetection:Jobs page] Edit model snapshot flyout missing title from announcement (elastic#217831) (elastic#218273)
# Backport This will backport the following commits from `main` to `8.18`: - [fix: [Analytics:MachineLearning:AnomalyDetection:Jobs page] Edit model snapshot flyout missing title from announcement (elastic#217831)](elastic#217831) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-15T13:38:48Z","message":"fix: [Analytics:MachineLearning:AnomalyDetection:Jobs page] Edit model snapshot flyout missing title from announcement (elastic#217831)\n\nCloses: elastic#216147\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n\n1. Added` aria-labelledby={flyoutTitleId} `for mentioned places","sha":"d47e77627ac594883969066205a0888bb5034efb","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility",":ml","Feature:Anomaly Detection","release_note:skip","backport:prev-major","v9.1.0"],"title":"fix: [Analytics:MachineLearning:AnomalyDetection:Jobs page] Edit model snapshot flyout missing title from announcement","number":217831,"url":"https://github.com/elastic/kibana/pull/217831","mergeCommit":{"message":"fix: [Analytics:MachineLearning:AnomalyDetection:Jobs page] Edit model snapshot flyout missing title from announcement (elastic#217831)\n\nCloses: elastic#216147\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n\n1. Added` aria-labelledby={flyoutTitleId} `for mentioned places","sha":"d47e77627ac594883969066205a0888bb5034efb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/217831","number":217831,"mergeCommit":{"message":"fix: [Analytics:MachineLearning:AnomalyDetection:Jobs page] Edit model snapshot flyout missing title from announcement (elastic#217831)\n\nCloses: elastic#216147\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made:**\n\n1. Added` aria-labelledby={flyoutTitleId} `for mentioned places","sha":"d47e77627ac594883969066205a0888bb5034efb"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
1 parent 330e31c commit 85ce57c

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

x-pack/platform/plugins/shared/ml/public/application/components/model_snapshots/edit_model_snapshot_flyout/edit_model_snapshot_flyout.tsx

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import {
2424
EuiSwitch,
2525
EuiConfirmModal,
2626
EuiCallOut,
27+
useGeneratedHtmlId,
2728
} from '@elastic/eui';
2829

2930
import type {
@@ -98,13 +99,22 @@ export const EditModelSnapshotFlyout: FC<Props> = ({ snapshot, job, closeFlyout
9899
setDeleteModalVisible(false);
99100
}
100101

102+
const flyoutTitleId = useGeneratedHtmlId({
103+
prefix: 'editModelSnapshotFlyout',
104+
});
105+
101106
return (
102107
<>
103-
<EuiFlyout onClose={closeWithoutReload} hideCloseButton size="m">
108+
<EuiFlyout
109+
onClose={closeWithoutReload}
110+
hideCloseButton
111+
size="m"
112+
aria-labelledby={flyoutTitleId}
113+
>
104114
<EuiFlyoutBody>
105115
<EuiFlexItem>
106116
<EuiTitle size="s">
107-
<h5>
117+
<h5 id={flyoutTitleId}>
108118
<FormattedMessage
109119
id="xpack.ml.editModelSnapshotFlyout.title"
110120
defaultMessage="Edit snapshot {ssId}"

0 commit comments

Comments
 (0)