Skip to content

Commit 06b6275

Browse files
authored
Merge pull request #205 from lchrusciel/claude/symfony-8-support-N0kzS
[Maintenance] Add Symfony 8.0 support
2 parents 9223f28 + 348c0a3 commit 06b6275

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

.github/workflows/build.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,18 @@ jobs:
2020
strategy:
2121
fail-fast: false
2222
matrix:
23-
php: [8.1, 8.2, 8.3, 8.4, 8.5]
24-
symfony: [6.4.*, 7.4.*]
23+
php: [8.2, 8.3, 8.4, 8.5]
24+
symfony: [6.4.*, 7.4.*, 8.0.*]
2525
phpunit: [^10.0, ^11.0, ^12.0]
2626
php-matcher: [^6.0]
27-
orm: [^2.5, ^3.0]
27+
orm: [^3.0]
2828
exclude:
29-
- php: 8.1
30-
symfony: 7.4.*
31-
- php: 8.1
32-
phpunit: ^11.0
33-
- php: 8.1
34-
phpunit: ^12.0
29+
# Symfony 8 requires PHP 8.4+
30+
- php: 8.2
31+
symfony: 8.0.*
32+
- php: 8.3
33+
symfony: 8.0.*
34+
# PHPUnit 12 requires PHP 8.3+
3535
- php: 8.2
3636
phpunit: ^12.0
3737

composer.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,26 +24,26 @@
2424
}
2525
],
2626
"require": {
27-
"php": "^8.1",
27+
"php": "^8.2",
2828
"ext-json": "*",
2929

3030
"coduo/php-matcher": "^6.0",
3131
"openlss/lib-array2xml": "^1.0",
3232
"doctrine/data-fixtures": "^1.2 || ^2.0",
3333
"doctrine/doctrine-bundle": "^2.0 || ^3.0",
34-
"doctrine/orm": "^2.5 || ^3.0",
34+
"doctrine/orm": "^3.0",
3535
"nelmio/alice": "^3.6",
3636
"phpspec/php-diff": "^1.1",
3737
"phpunit/phpunit": "^10.0 || ^11.0 || ^12.0",
38-
"symfony/browser-kit": "^6.4 || ^7.4",
39-
"symfony/finder": "^6.4 || ^7.4",
40-
"symfony/framework-bundle": "^6.4 || ^7.4",
38+
"symfony/browser-kit": "^6.4 || ^7.4 || ^8.0",
39+
"symfony/finder": "^6.4 || ^7.4 || ^8.0",
40+
"symfony/framework-bundle": "^6.4 || ^7.4 || ^8.0",
4141
"theofidry/alice-data-fixtures": "^1.0"
4242
},
4343
"require-dev": {
4444
"phpstan/phpstan-strict-rules": "^1.0",
4545
"phpstan/phpstan-webmozart-assert": "^1.0",
46-
"symfony/serializer": "^5.4 || ^6.0 || ^7.0",
46+
"symfony/serializer": "^5.4 || ^6.0 || ^7.0 || ^8.0",
4747
"phpstan/phpstan": "^1.8"
4848
},
4949
"scripts": {

test/app/AppKernel.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function getProjectDir(): string
4444
/**
4545
* {@inheritdoc}
4646
*/
47-
public function registerContainerConfiguration(LoaderInterface $loader)
47+
public function registerContainerConfiguration(LoaderInterface $loader): void
4848
{
4949
$loader->load(static function (ContainerBuilder $container): void {
5050
$container->loadFromExtension('framework', [

test/src/Controller/SampleController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public function categoryIndexAction(Request $request): Response
7979
public function showAction(Request $request): Response
8080
{
8181
$productRepository = $this->objectManager->getRepository(Product::class);
82-
$product = $productRepository->find($request->get('id'));
82+
$product = $productRepository->find($request->attributes->get('id'));
8383

8484
if (!$product) {
8585
throw new NotFoundHttpException();

0 commit comments

Comments
 (0)