Merge pull request #2600 from czgdp1807/fast_fix

Remove ``is_fast`` and its associated methods from ``PassManager``

Author: czgdp1807

run_tests.py

@@ -32,6 +32,7 @@ def is_included(backend):
     run = is_included("run")
     run_with_dbg = is_included("run_with_dbg")
     disable_main = is_included("disable_main")
+    fast = is_included("fast")
     pass_ = test.get("pass", None)
     optimization_passes = ["flip_sign", "div_to_mul", "fma", "sign_from_value",
                            "inline_function_calls", "loop_unroll",
@@ -97,6 +98,8 @@ def is_included(backend):
         cmd = "lpython "
         if is_cumulative:
             cmd += "--cumulative "
+        if fast:
+            cmd += "--fast "
         cmd += "--pass=" + pass_ + \
             " --show-asr --no-color {infile} -o {outfile}"
         run_test(filename, "pass_{}".format(pass_), cmd,

src/bin/lpython.cpp

@@ -1691,7 +1691,10 @@ int main(int argc, char *argv[])
         // ReleaseSafe Mode
         } else if ( compiler_options.po.fast ) {
         // Release Mode
-            lpython_pass_manager.use_optimization_passes();
+        // No need to do anything, compiler_options.po.fast
+        // sends the signal to pass_manager when passes are applied
+        // Earlier it was redundant to call `use_optimisation_passes`
+        // which is now removed
         } else {
         // Debug Mode
             compiler_options.enable_bounds_checking = true;

src/libasr/pass/pass_manager.h

@@ -106,7 +106,6 @@ namespace LCompilers {
             {"insert_deallocate", &pass_insert_deallocate}
         };
 
-        bool is_fast;
         bool apply_default_passes;
         bool c_skip_pass; // This will contain the passes that are to be skipped in C
 
@@ -196,7 +195,7 @@ namespace LCompilers {
             }
         }
 
-        PassManager(): is_fast{false}, apply_default_passes{false},
+        PassManager(): apply_default_passes{false},
             c_skip_pass{false} {
             _passes = {
                 "nested_vars",
@@ -287,12 +286,10 @@ namespace LCompilers {
                           PassOptions& pass_options,
                           diag::Diagnostics &diagnostics) {
             if( !_user_defined_passes.empty() ) {
-                pass_options.fast = true;
                 apply_passes(al, asr, _user_defined_passes, pass_options,
                     diagnostics);
             } else if( apply_default_passes ) {
-                pass_options.fast = is_fast;
-                if( is_fast ) {
+                if( pass_options.fast ) {
                     apply_passes(al, asr, _with_optimization_passes, pass_options,
                         diagnostics);
                 } else {
@@ -371,14 +368,6 @@ namespace LCompilers {
             }
         }
 
-        void use_optimization_passes() {
-            is_fast = true;
-        }
-
-        void do_not_use_optimization_passes() {
-            is_fast = false;
-        }
-
         void use_default_passes(bool _c_skip_pass=false) {
             apply_default_passes = true;
             c_skip_pass = _c_skip_pass;

…nction_calls-func_inline_01-8b6a5da.json …nction_calls-func_inline_01-fba3c47.jsontests/reference/pass_inline_function_calls-func_inline_01-8b6a5da.json renamed to tests/reference/pass_inline_function_calls-func_inline_01-fba3c47.json tests/reference/pass_inline_function_calls-func_inline_01-8b6a5da.json renamed to tests/reference/pass_inline_function_calls-func_inline_01-fba3c47.json

@@ -1,11 +1,11 @@
 {
-    "basename": "pass_inline_function_calls-func_inline_01-8b6a5da",
-    "cmd": "lpython --pass=inline_function_calls --show-asr --no-color {infile} -o {outfile}",
+    "basename": "pass_inline_function_calls-func_inline_01-fba3c47",
+    "cmd": "lpython --fast --pass=inline_function_calls --show-asr --no-color {infile} -o {outfile}",
     "infile": "tests/../integration_tests/func_inline_01.py",
     "infile_hash": "65a2e9a9bc7ad68a5e104549eed00cafd02b643a1d91ab2e175b2198",
     "outfile": null,
     "outfile_hash": null,
-    "stdout": "pass_inline_function_calls-func_inline_01-8b6a5da.stdout",
+    "stdout": "pass_inline_function_calls-func_inline_01-fba3c47.stdout",
     "stdout_hash": "1705050e9a2183a2f6aa493125e093e7c4d17a4f2f4949749950e11a",
     "stderr": null,
     "stderr_hash": null,

…tion_calls-func_inline_01-8b6a5da.stdout …tion_calls-func_inline_01-fba3c47.stdouttests/reference/pass_inline_function_calls-func_inline_01-8b6a5da.stdout renamed to tests/reference/pass_inline_function_calls-func_inline_01-fba3c47.stdout tests/reference/pass_inline_function_calls-func_inline_01-8b6a5da.stdout renamed to tests/reference/pass_inline_function_calls-func_inline_01-fba3c47.stdout

@@ -228,6 +228,7 @@ asr = true
 llvm = true
 pass_with_llvm = true
 pass = "inline_function_calls"
+fast = true
 
 # to make sure static keyword is actually present in function declaration
 [[test]]