Merge pull request #2093 from Smit-create/i-2088

Fix 1-dim array length in message

Author: Smit-create

src/libasr/asr_utils.h

@@ -1004,9 +1004,9 @@ static inline std::string type_python_1dim_helper(const std::string & res,
     }
 
     if( ASRUtils::expr_value(e->m_length) ) {
-        int64_t length_dim = -1;
+        int64_t length_dim = 0;
         ASRUtils::extract_value(ASRUtils::expr_value(e->m_length), length_dim);
-        return res + "[" + std::to_string(length_dim + 1) + "]";
+        return res + "[" + std::to_string(length_dim) + "]";
     }
 
     return res;

tests/errors/arrays_01.py

@@ -0,0 +1,17 @@
+from lpython import (i8, i32, dataclass)
+from numpy import empty, int8
+
+# test issue-2088
+
+@dataclass
+class LPBHV_small:
+    dim : i32 = 4
+    a : i8[4] = empty(4, dtype=int8)
+
+
+def g() -> None:
+    l2 : LPBHV_small = LPBHV_small(
+        4,
+        [i8(214), i8(157), i8(3), i8(146)])
+
+g()

tests/reference/asr-arrays_01-a617b64.json

@@ -0,0 +1,13 @@
+{
+    "basename": "asr-arrays_01-a617b64",
+    "cmd": "lpython --show-asr --no-color {infile} -o {outfile}",
+    "infile": "tests/errors/arrays_01.py",
+    "infile_hash": "9e11033fc97f884cd3d55a9194cb45add6805e5fc4d9473f9e1b9611",
+    "outfile": null,
+    "outfile_hash": null,
+    "stdout": null,
+    "stdout_hash": null,
+    "stderr": "asr-arrays_01-a617b64.stderr",
+    "stderr_hash": "b8317c7306f747ceefa8557c06f2a0b4a8a4bd7ae805bb494fca6ef2",
+    "returncode": 2
+}

tests/reference/asr-arrays_01-a617b64.stderr

@@ -0,0 +1,8 @@
+semantic error: Type mismatch in procedure call; the types must be compatible
+  --> tests/errors/arrays_01.py:15:9
+   |
+15 |         [i8(214), i8(157), i8(3), i8(146)])
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ type mismatch (passed argument type is list[i8] but required type is i8[4])
+   |
+ 9 |     a : i8[4] = empty(4, dtype=int8)
+   |         ^^^^^ type mismatch (passed argument type is list[i8] but required type is i8[4])

tests/reference/asr-test_annassign_type_mismatch-7dac7be.json

@@ -8,6 +8,6 @@
     "stdout": null,
     "stdout_hash": null,
     "stderr": "asr-test_annassign_type_mismatch-7dac7be.stderr",
-    "stderr_hash": "a794ce35be79f7fcbb0889e04091555055f3c1c537bcf14840d33e60",
+    "stderr_hash": "26fc89f95c7dda5f1d9c3cb1af9843880cf693eb7b97125372b11f80",
     "returncode": 2
 }

tests/reference/asr-test_annassign_type_mismatch-7dac7be.stderr

@@ -2,4 +2,4 @@ semantic error: Type mismatch in annotation-assignment, the types must be compat
  --> tests/errors/test_annassign_type_mismatch.py:4:5
   |
 4 |     x: i32[4] = [1, 2, 3, 4]
-  |     ^           ^^^^^^^^^^^^ type mismatch ('i32[5]' and 'list[i32]')
+  |     ^           ^^^^^^^^^^^^ type mismatch ('i32[4]' and 'list[i32]')

tests/reference/asr-test_annassign_type_mismatch2-fc883f7.json

@@ -8,6 +8,6 @@
     "stdout": null,
     "stdout_hash": null,
     "stderr": "asr-test_annassign_type_mismatch2-fc883f7.stderr",
-    "stderr_hash": "3c2bbba713689c37ed22127cdd7a37ab6b1bce03d01380803884849d",
+    "stderr_hash": "873b4521e2155bc92405db41e7745a4fb5441b5d80f94467d7b1b637",
     "returncode": 2
 }

tests/reference/asr-test_annassign_type_mismatch2-fc883f7.stderr

@@ -2,4 +2,4 @@ semantic error: Type mismatch in annotation-assignment, the types must be compat
  --> tests/errors/test_annassign_type_mismatch2.py:4:5
   |
 4 |     x: f64[5] = [1.0, 2.0, 3.0, 4.0, 5.0]
-  |     ^           ^^^^^^^^^^^^^^^^^^^^^^^^^ type mismatch ('f64[6]' and 'list[f64]')
+  |     ^           ^^^^^^^^^^^^^^^^^^^^^^^^^ type mismatch ('f64[5]' and 'list[f64]')

tests/tests.toml

@@ -651,6 +651,10 @@ asr = true
 filename = "errors/structs_01.py"
 asr = true
 
+[[test]]
+filename = "errors/arrays_01.py"
+asr = true
+
 [[test]]
 filename = "errors/structs_02.py"
 asr = true