Seeded random.random() with system clock if it is left unseeded (#2549)

Author: advikkabra

src/libasr/codegen/asr_to_llvm.cpp

@@ -3034,19 +3034,19 @@ class ASRToLLVMVisitor : public ASR::BaseVisitor<ASRToLLVMVisitor>
         }
         builder->SetInsertPoint(BB);
 
-        // Call the `_lpython_set_argv` function to assign command line argument
-        // values to `argc` and `argv`.
+        // Call the `_lpython_call_initial_functions` function to assign command line argument
+        // values to `argc` and `argv`, and set the random seed to the system clock.
         {
             if (compiler_options.emit_debug_info) debug_emit_loc(x);
-            llvm::Function *fn = module->getFunction("_lpython_set_argv");
+            llvm::Function *fn = module->getFunction("_lpython_call_initial_functions");
             if(!fn) {
                 llvm::FunctionType *function_type = llvm::FunctionType::get(
                     llvm::Type::getVoidTy(context), {
                         llvm::Type::getInt32Ty(context),
                         character_type->getPointerTo()
                     }, false);
                 fn = llvm::Function::Create(function_type,
-                    llvm::Function::ExternalLinkage, "_lpython_set_argv", *module);
+                    llvm::Function::ExternalLinkage, "_lpython_call_initial_functions", *module);
             }
             std::vector<llvm::Value *> args;
             for (llvm::Argument &llvm_arg : F->args()) {

src/libasr/runtime/lfortran_intrinsics.c

@@ -2545,6 +2545,13 @@ LFORTRAN_API char *_lpython_get_argv(int32_t index) {
 
 // << Command line arguments << ------------------------------------------------
 
+// Initial setup
+LFORTRAN_API void _lpython_call_initial_functions(int32_t argc_1, char *argv_1[]) {
+    _lpython_set_argv(argc_1, argv_1);
+    _lfortran_init_random_clock();
+}
+// << Initial setup << ---------------------------------------------------------
+
 // >> Runtime Stacktrace >> ----------------------------------------------------
 #ifdef HAVE_RUNTIME_STACKTRACE
 #ifdef HAVE_LFORTRAN_UNWIND

src/libasr/runtime/lfortran_intrinsics.h

@@ -277,6 +277,7 @@ LFORTRAN_API int32_t _lfortran_all(bool *mask, int32_t n);
 LFORTRAN_API void _lpython_set_argv(int32_t argc_1, char *argv_1[]);
 LFORTRAN_API int32_t _lpython_get_argc();
 LFORTRAN_API char *_lpython_get_argv(int32_t index);
+LFORTRAN_API void _lpython_call_initial_functions(int32_t argc_1, char *argv_1[]);
 LFORTRAN_API void print_stacktrace_addresses(char *filename, bool use_colors);
 LFORTRAN_API char *_lfortran_get_env_variable(char *name);
 LFORTRAN_API int _lfortran_exec_command(char *cmd);

tests/reference/llvm-assert1-8df4f31.json

@@ -6,7 +6,7 @@
     "outfile": null,
     "outfile_hash": null,
     "stdout": "llvm-assert1-8df4f31.stdout",
-    "stdout_hash": "15764832892f7e0cd2a438b247a148564f5f83b3a00ca929bd9cc625",
+    "stdout_hash": "de8886bdb5b86970a042b8ee00f309cf6bcf9e3e192cb4875ab3b2b0",
     "stderr": null,
     "stderr_hash": null,
     "returncode": 0

tests/reference/llvm-assert1-8df4f31.stdout

@@ -3,8 +3,8 @@ source_filename = "LFortran"
 
 define i32 @main(i32 %0, i8** %1) {
 .entry:
-  call void @_lpython_set_argv(i32 %0, i8** %1)
+  call void @_lpython_call_initial_functions(i32 %0, i8** %1)
   ret i32 0
 }
 
-declare void @_lpython_set_argv(i32, i8**)
+declare void @_lpython_call_initial_functions(i32, i8**)

tests/reference/llvm-bindc_01-c984f09.json

@@ -6,7 +6,7 @@
     "outfile": null,
     "outfile_hash": null,
     "stdout": "llvm-bindc_01-c984f09.stdout",
-    "stdout_hash": "36302aceabcf2682f3e954ab4bc56dd960fe532dc7799cb58baa19a3",
+    "stdout_hash": "054106835033c19d6d0b10c264d915a4d4b11fee2a70abd6d66bade3",
     "stderr": null,
     "stderr_hash": null,
     "returncode": 0

tests/reference/llvm-bindc_01-c984f09.stdout

@@ -73,9 +73,9 @@ declare void @exit(i32)
 
 define i32 @main(i32 %0, i8** %1) {
 .entry:
-  call void @_lpython_set_argv(i32 %0, i8** %1)
+  call void @_lpython_call_initial_functions(i32 %0, i8** %1)
   call void @__module___main_____main__global_stmts()
   ret i32 0
 }
 
-declare void @_lpython_set_argv(i32, i8**)
+declare void @_lpython_call_initial_functions(i32, i8**)

tests/reference/llvm-bool1-af4376b.json

@@ -6,7 +6,7 @@
     "outfile": null,
     "outfile_hash": null,
     "stdout": "llvm-bool1-af4376b.stdout",
-    "stdout_hash": "cb60cdc2beb220bbe693b54079b5ebc7efcdc2cdc830c3cc0e213c39",
+    "stdout_hash": "7c68133cc3f970d6eddca6cf982fb405b5a1c8014ef5aa916ea38cf6",
     "stderr": null,
     "stderr_hash": null,
     "returncode": 0

tests/reference/llvm-bool1-af4376b.stdout

@@ -56,9 +56,9 @@ declare void @_lfortran_printf(i8*, ...)
 
 define i32 @main(i32 %0, i8** %1) {
 .entry:
-  call void @_lpython_set_argv(i32 %0, i8** %1)
+  call void @_lpython_call_initial_functions(i32 %0, i8** %1)
   call void @__module___main_____main__global_stmts()
   ret i32 0
 }
 
-declare void @_lpython_set_argv(i32, i8**)
+declare void @_lpython_call_initial_functions(i32, i8**)

tests/reference/llvm-expr14-b96b5b1.json

@@ -6,7 +6,7 @@
     "outfile": null,
     "outfile_hash": null,
     "stdout": "llvm-expr14-b96b5b1.stdout",
-    "stdout_hash": "15764832892f7e0cd2a438b247a148564f5f83b3a00ca929bd9cc625",
+    "stdout_hash": "de8886bdb5b86970a042b8ee00f309cf6bcf9e3e192cb4875ab3b2b0",
     "stderr": null,
     "stderr_hash": null,
     "returncode": 0