Merge pull request #1903 from Shaikh-Ubaid/asr_verify_arr_dims

ASRVerify: Require signed integer array dimensions

Author: ubaidsk

src/libasr/asr_utils.h

@@ -115,6 +115,17 @@ static inline ASR::ttype_t *type_get_past_array(ASR::ttype_t *f)
     }
 }
 
+static inline ASR::ttype_t *type_get_past_const(ASR::ttype_t *f)
+{
+    if (ASR::is_a<ASR::Const_t>(*f)) {
+        ASR::Const_t *e = ASR::down_cast<ASR::Const_t>(f);
+        LCOMPILERS_ASSERT(!ASR::is_a<ASR::Const_t>(*e->m_type));
+        return e->m_type;
+    } else {
+        return f;
+    }
+}
+
 static inline ASR::Variable_t* EXPR2VAR(const ASR::expr_t *f)
 {
     return ASR::down_cast<ASR::Variable_t>(symbol_get_past_external(

src/libasr/asr_verify.cpp

@@ -1015,6 +1015,22 @@ class VerifyVisitor : public BaseWalkVisitor<VerifyVisitor>
         BaseWalkVisitor<VerifyVisitor>::visit_ArrayConstant(x);
     }
 
+    void visit_dimension(const dimension_t &x) {
+        if (x.m_start) {
+            require_with_loc(ASR::is_a<ASR::Integer_t>(
+                *ASRUtils::type_get_past_const(ASRUtils::expr_type(x.m_start))),
+                "Start dimension must be a signed integer", x.loc);
+            visit_expr(*x.m_start);
+        }
+
+        if (x.m_length) {
+            require_with_loc(ASR::is_a<ASR::Integer_t>(
+                *ASRUtils::type_get_past_const(ASRUtils::expr_type(x.m_length))),
+                "Length dimension must be a signed integer", x.loc);
+            visit_expr(*x.m_length);
+        }
+    }
+
     void visit_Array(const Array_t& x) {
         visit_ttype(*x.m_type);
         require(x.n_dims != 0, "Array type cannot have 0 dimensions.")