Use id: in errors_on

Author: lcreid

lib/bootstrap_form/helpers/bootstrap.rb

@@ -34,7 +34,10 @@ def errors_on(name, options={})
         hide_attribute_name = options[:hide_attribute_name] || false
         custom_class = options[:custom_class] || false
 
-        tag.div(class: custom_class || "invalid-feedback", id: field_id(name, :feedback)) do
+        tag.div(
+          class: custom_class || "invalid-feedback",
+          id: options[:id].present? ? "#{options[:id]}_feedback" : field_id(name, :feedback)
+        ) do
           errors = if hide_attribute_name
                      object.errors[name]
                    else

lib/bootstrap_form/inputs/base.rb

@@ -24,6 +24,8 @@ def bootstrap_field(field_name)
 
         def bootstrap_select_group(field_name)
           define_method(:"#{field_name}_with_bootstrap") do |name, options={}, html_options={}|
+            # Specifying the id for a select doesn't work. The Rails helpers need to generate
+            # what they generate, and that includes the ids for each select option.
             options.delete(:id)
             html_options = html_options.reverse_merge(control_class: "form-select")
             form_group_builder(name, options, html_options) do

test/bootstrap_form_test.rb

@@ -1596,6 +1596,19 @@ def warn(message, ...)
     assert_equivalent_html expected, @builder.errors_on(:email, custom_class: "custom-error-class")
   end
 
+  test "errors_on with specified id:" do
+    @user.email = nil
+    assert @user.invalid?
+
+    expected = <<~HTML
+      <div class="invalid-feedback" id="custom-id_feedback">
+        Email can't be blank, Email is too short (minimum is 5 characters)
+      </div>
+    HTML
+
+    assert_equivalent_html expected, @builder.errors_on(:email, id: "custom-id")
+  end
+
   test "horizontal-style forms" do
     expected = <<~HTML
       <form accept-charset="UTF-8" action="/users" class="new_user" id="new_user" method="post">