Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| bazelisk-cache: true | ||
| repository-cache: true | ||
| external-cache: false | ||
| disk-cache: ${{ github.workflow }}} |
There was a problem hiding this comment.
Extra closing brace in disk-cache key value
Medium Severity
The disk-cache value ${{ github.workflow }}} has three closing braces instead of two. The GitHub Actions expression ${{ ... }} ends at the second }, leaving a literal } appended to the workflow name. This means the disk cache path will include a trailing } character (e.g., "Bazel Crossbuild}"), causing cache misses against any other configuration expecting the clean workflow name.
| - "pkg/store/mockstore/unistore/testutil.go" | ||
| - "k8s.io/apimachinery/pkg" | ||
| - "build" | ||
| - "lighting/cmd" |
There was a problem hiding this comment.
Typo "lighting" instead of "lightning" in ignore path
Low Severity
The codecov ignore path "lighting/cmd" is misspelled — the actual directory is lightning/cmd. This means codecov will not ignore the intended lightning/cmd directory, and coverage reports will include files from that path that were meant to be excluded.
| *.result diff | ||
|
|
||
| util/collate/unicode_0*_ci.go linguist-generated=true | ||
| util/collate/ucadata/unicode_*_data.go linguist-generated=true |
There was a problem hiding this comment.
Gitattributes linguist patterns have wrong directory prefix
Low Severity
The linguist-generated patterns use paths util/collate/... but the actual files live under pkg/util/collate/.... There is no util/collate/ directory at the repo root. Additionally, the glob unicode_0*_ci.go wouldn't match the actual generated filenames like unicode_0400_ci_generated.go (which end in _ci_generated.go, not _ci.go). Similarly, unicode_*_data.go won't match unicode_0900_ai_ci_data_generated.go. These patterns will silently match nothing.
| @@ -1,10 +1,8 @@ | |||
| .git/ | |||
There was a problem hiding this comment.
Missing .git/ in dockerignore bloats Docker builds
Medium Severity
The .git/ entry was removed from .dockerignore, but the Dockerfile uses COPY . . to copy the entire working directory into the builder image. Without .git/ being ignored, the entire git history (potentially hundreds of megabytes) gets sent as Docker build context and copied into the builder layer, significantly slowing down every Docker build. This also risks leaking repository metadata into the build environment.
20 participants
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Note
Medium Risk
CI/build pipeline behavior changes (Bazel upgrade, workflow trigger/matrix updates, and disabling Codecov checks) can affect build stability and signal quality, though runtime product code is untouched.
Overview
Updates Bazel tooling by bumping
.bazelversionto7.7.1and tuning.bazelrcfor more resilient remote/HTTP behavior (timeouts, retries), more detailed test output, flaky retries, and proxy env passthrough.Reworks Codecov config to disable project/patch status checks and GitHub checks, adds component/flag management metadata, and expands ignore patterns.
Refreshes GitHub automation and repo metadata: adds a reusable
tidb_buildcomposite action plus a new Bazel crossbuild workflow, broadens BR/Lightning compile workflows (adds manual dispatch, Windows matrix, neweractions/*versions, and MySQL matrix updates for dumpling), and updates templates/contact links plus various hygiene configs (.gitignore,.dockerignore,.gitattributes, licenser ignore list, and moves the enterprise extension submodule path topkg/extension/enterprise).Written by Cursor Bugbot for commit 6ff1adf. This will update automatically on new commits. Configure here.