Clean up asserts and getters in controls

Author: pfmooney

lib/controls/control.js

@@ -1,55 +1,48 @@
 // Copyright 2011 Mark Cavage, Inc.  All rights reserved.
 
-var assert = require('assert');
+var assert = require('assert-plus');
 var util = require('util');
 
 var asn1 = require('asn1');
 
 var Protocol = require('../protocol');
 
 
-
 ///--- Globals
 
 var Ber = asn1.Ber;
 
 
-
 ///--- API
 
 function Control(options) {
-  if (options) {
-    if (typeof (options) !== 'object')
-      throw new TypeError('options must be an object');
-    if (options.type && typeof (options.type) !== 'string')
-      throw new TypeError('options.type must be a string');
-    if (options.criticality !== undefined &&
-        typeof (options.criticality) !== 'boolean')
-      throw new TypeError('options.criticality must be a boolean');
-    if (options.value && !Buffer.isBuffer(options.value))
-      throw new TypeError('options.value must be a Buffer');
-  } else {
-    options = {};
+  assert.optionalObject(options);
+  options = options || {};
+  assert.optionalString(options.type);
+  assert.optionalBool(options.criticality);
+  if (options.value) {
+  console.log(assert.buffer.toString());
+    assert.buffer(options.value);
   }
 
   this.type = options.type || '';
   this.criticality = options.critical || options.criticality || false;
   this.value = options.value || null;
-
-  var self = this;
-  this.__defineGetter__('json', function () {
-    var obj = {
-      controlType: self.type,
-      criticality: self.criticality,
-      controlValue: self.value
-    };
-    return (typeof (self._json) === 'function' ? self._json(obj) : obj);
-  });
 }
-module.exports = Control;
-
+Object.defineProperties(Control.prototype, {
+  json: {
+    get: function getJson() {
+      var obj = {
+        controlType: this.type,
+        criticality: this.criticality,
+        controlValue: this.value
+      };
+      return (typeof (this._json) === 'function' ? this._json(obj) : obj);
+    }
+  }
+});
 
-Control.prototype.toBer = function (ber) {
+Control.prototype.toBer = function toBer(ber) {
   assert.ok(ber);
 
   ber.startSequence();
@@ -66,7 +59,10 @@ Control.prototype.toBer = function (ber) {
   return;
 };
 
-
-Control.prototype.toString = function () {
+Control.prototype.toString = function toString() {
   return this.json;
 };
+
+
+///--- Exports
+module.exports = Control;

lib/controls/entry_change_notification_control.js

@@ -1,25 +1,22 @@
-var assert = require('assert');
+var assert = require('assert-plus');
 var util = require('util');
 
 var asn1 = require('asn1');
 
 var Control = require('./control');
 
 
-
 ///--- Globals
 
 var BerReader = asn1.BerReader;
 var BerWriter = asn1.BerWriter;
 
 
-
 ///--- API
 
 function EntryChangeNotificationControl(options) {
-  if (!options)
-    options = {};
-
+  assert.optionalObject(options);
+  options = options || {};
   options.type = EntryChangeNotificationControl.OID;
   if (options.value) {
     if (Buffer.isBuffer(options.value)) {
@@ -32,15 +29,14 @@ function EntryChangeNotificationControl(options) {
     options.value = null;
   }
   Control.call(this, options);
-
-  var self = this;
-  this.__defineGetter__('value', function () {
-    return self._value || {};
-  });
 }
 util.inherits(EntryChangeNotificationControl, Control);
-module.exports = EntryChangeNotificationControl;
-
+Object.defineProperties(EntryChangeNotificationControl.prototype, {
+  value: {
+    get: function () { return this._value || {}; },
+    configurable: false
+  }
+});
 
 EntryChangeNotificationControl.prototype.parse = function parse(buffer) {
   assert.ok(buffer);
@@ -63,7 +59,6 @@ EntryChangeNotificationControl.prototype.parse = function parse(buffer) {
   return false;
 };
 
-
 EntryChangeNotificationControl.prototype._toBer = function (ber) {
   assert.ok(ber);
 
@@ -82,12 +77,13 @@ EntryChangeNotificationControl.prototype._toBer = function (ber) {
   ber.writeBuffer(writer.buffer, 0x04);
 };
 
-
 EntryChangeNotificationControl.prototype._json = function (obj) {
   obj.controlValue = this.value;
   return obj;
 };
 
+EntryChangeNotificationControl.OID = '2.16.840.1.113730.3.4.7';
 
 
-EntryChangeNotificationControl.OID = '2.16.840.1.113730.3.4.7';
+///--- Exports
+module.exports = EntryChangeNotificationControl;

lib/controls/index.js

@@ -26,60 +26,44 @@ module.exports = {
       return null;
 
     var type;
-    var critical = false;
-    var value;
+    var opts = {
+      criticality: false,
+      value: null
+    };
 
     if (ber.length) {
       var end = ber.offset + ber.length;
 
       type = ber.readString();
       if (ber.offset < end) {
         if (ber.peek() === Ber.Boolean)
-          critical = ber.readBoolean();
+          opts.criticality = ber.readBoolean();
       }
 
       if (ber.offset < end)
-        value = ber.readString(Ber.OctetString, true);
+        opts.value = ber.readString(Ber.OctetString, true);
     }
 
     var control;
     switch (type) {
     case PersistentSearchControl.OID:
-      control = new PersistentSearchControl({
-        critical: critical,
-        value: value
-      });
+      control = new PersistentSearchControl(opts);
       break;
     case EntryChangeNotificationControl.OID:
-      control = new EntryChangeNotificationControl({
-        critical: critical,
-        value: value
-      });
+      control = new EntryChangeNotificationControl(opts);
       break;
     case PagedResultsControl.OID:
-      control = new PagedResultsControl({
-        critical: critical,
-        value: value
-      });
+      control = new PagedResultsControl(opts);
       break;
     case ServerSideSortingRequestControl.OID:
-      control = new ServerSideSortingRequestControl({
-        critical: critical,
-        value: value
-      });
+      control = new ServerSideSortingRequestControl(opts);
       break;
     case ServerSideSortingResponseControl.OID:
-      control = new ServerSideSortingResponseControl({
-        critical: critical,
-        value: value
-      });
+      control = new ServerSideSortingResponseControl(opts);
       break;
     default:
-      control = new Control({
-        type: type,
-        critical: critical,
-        value: value
-      });
+      opts.type = type;
+      control = new Control(opts);
       break;
     }
 

lib/controls/paged_results_control.js

@@ -1,25 +1,22 @@
-var assert = require('assert');
+var assert = require('assert-plus');
 var util = require('util');
 
 var asn1 = require('asn1');
 
 var Control = require('./control');
 
 
-
 ///--- Globals
 
 var BerReader = asn1.BerReader;
 var BerWriter = asn1.BerWriter;
 
 
-
 ///--- API
 
 function PagedResultsControl(options) {
-  if (!options)
-    options = {};
-
+  assert.optionalObject(options);
+  options = options || {};
   options.type = PagedResultsControl.OID;
   if (options.value) {
     if (Buffer.isBuffer(options.value)) {
@@ -32,15 +29,14 @@ function PagedResultsControl(options) {
     options.value = null;
   }
   Control.call(this, options);
-
-  var self = this;
-  this.__defineGetter__('value', function () {
-    return self._value || {};
-  });
 }
 util.inherits(PagedResultsControl, Control);
-module.exports = PagedResultsControl;
-
+Object.defineProperties(PagedResultsControl.prototype, {
+  value: {
+    get: function () { return this._value || {}; },
+    configurable: false
+  }
+});
 
 PagedResultsControl.prototype.parse = function parse(buffer) {
   assert.ok(buffer);
@@ -60,7 +56,6 @@ PagedResultsControl.prototype.parse = function parse(buffer) {
   return false;
 };
 
-
 PagedResultsControl.prototype._toBer = function (ber) {
   assert.ok(ber);
 
@@ -80,12 +75,13 @@ PagedResultsControl.prototype._toBer = function (ber) {
   ber.writeBuffer(writer.buffer, 0x04);
 };
 
-
 PagedResultsControl.prototype._json = function (obj) {
   obj.controlValue = this.value;
   return obj;
 };
 
+PagedResultsControl.OID = '1.2.840.113556.1.4.319';
 
 
-PagedResultsControl.OID = '1.2.840.113556.1.4.319';
+///--- Exports
+module.exports = PagedResultsControl;

lib/controls/persistent_search_control.js

@@ -1,28 +1,26 @@
 // Copyright 2011 Mark Cavage, Inc.  All rights reserved.
 
-var assert = require('assert');
+var assert = require('assert-plus');
 var util = require('util');
 
 var asn1 = require('asn1');
 
 var Control = require('./control');
 
 
-
 ///--- Globals
 
 var BerReader = asn1.BerReader;
 var BerWriter = asn1.BerWriter;
 
 
-
 ///--- API
 
 function PersistentSearchControl(options) {
-  if (!options)
-    options = {};
-
+  assert.optionalObject(options);
+  options = options || {};
   options.type = PersistentSearchControl.OID;
+
   if (options.value) {
     if (Buffer.isBuffer(options.value)) {
       this.parse(options.value);
@@ -34,15 +32,14 @@ function PersistentSearchControl(options) {
     options.value = null;
   }
   Control.call(this, options);
-
-  var self = this;
-  this.__defineGetter__('value', function () {
-    return self._value || {};
-  });
 }
 util.inherits(PersistentSearchControl, Control);
-module.exports = PersistentSearchControl;
-
+Object.defineProperties(PersistentSearchControl.prototype, {
+  value: {
+    get: function () { return this._value || {}; },
+    configurable: false
+  }
+});
 
 PersistentSearchControl.prototype.parse = function parse(buffer) {
   assert.ok(buffer);
@@ -61,7 +58,6 @@ PersistentSearchControl.prototype.parse = function parse(buffer) {
   return false;
 };
 
-
 PersistentSearchControl.prototype._toBer = function (ber) {
   assert.ok(ber);
 
@@ -78,12 +74,12 @@ PersistentSearchControl.prototype._toBer = function (ber) {
   ber.writeBuffer(writer.buffer, 0x04);
 };
 
-
 PersistentSearchControl.prototype._json = function (obj) {
   obj.controlValue = this.value;
   return obj;
 };
 
-
-
 PersistentSearchControl.OID = '2.16.840.1.113730.3.4.3';
+
+///--- Exports
+module.exports = PersistentSearchControl;