Update dependencies and CI (#796)

* Update dependencies

* Run CI for "next" releases

* Grrr

* Update target versions

* Fix test on Node 17

* Fix deprecation notice

Author: jsumners

.github/workflows/integration.yml

@@ -4,9 +4,14 @@ name: 'Integration Tests'
 #  https://github.community/t5/GitHub-Actions/Github-Actions-services-not-reachable/m-p/30739/highlight/true#M538
 
 on:
+  push:
+    branches:
+      - master
+      - next
   pull_request:
     branches:
       - master
+      - next
 
 jobs:
   baseline:

.github/workflows/main.yml

@@ -4,9 +4,11 @@ on:
   push:
     branches:
       - master
+      - next
   pull_request:
     branches:
       - master
+      - next
 
 jobs:
   lint:
@@ -15,6 +17,8 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
+        with:
+          node-version: 'lts/*'
       - name: Install Packages
         run: npm install
       - name: Lint Code
@@ -28,10 +32,9 @@ jobs:
           - ubuntu-latest
           - windows-latest
         node:
-          - 10.13.0
-          - 10.x
-          - 12.x
-          - 14.x
+          - 14
+          - 16
+          - 17
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3

.npmrc

@@ -0,0 +1,7 @@
+# npm general settings
+package-lock=false
+legacy-peer-deps=true
+
+# pnpm specific settings
+hoist=false
+public-hoist-pattern[]=*eslint*

package.json

@@ -27,17 +27,17 @@
     "verror": "^1.8.1"
   },
   "devDependencies": {
-    "eslint": "^7.20.0",
+    "@fastify/pre-commit": "^2.0.2",
+    "eslint": "8.12.0",
     "eslint-config-standard": "^16.0.2",
     "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-promise": "^5.1.0",
+    "eslint-plugin-promise": "6.0.0",
     "front-matter": "^4.0.2",
     "get-port": "^5.1.1",
     "highlight.js": "^11.0.1",
-    "husky": "^4.2.5",
     "marked": "^4.0.0",
-    "tap": "15.2.3"
+    "tap": "16.0.1"
   },
   "scripts": {
     "test": "tap --no-cov -R terse",
@@ -51,9 +51,8 @@
     "lint:ci": "eslint .",
     "docs": "node scripts/build-docs.js"
   },
-  "husky": {
-    "hooks": {
-      "pre-commit": "npm run lint:ci && npm run test"
-    }
-  }
+  "pre-commit": [
+    "lint:ci",
+    "test"
+  ]
 }

test/laundry.test.js

@@ -122,7 +122,7 @@ tap.test('GH-55 Client emits connect multiple times', function (t) {
     t.ok(socket)
     count++
     c.bind('cn=root', 'secret', function (err) {
-      t.ifError(err)
+      t.error(err)
       c.unbind(function () {
         t.equal(count, 1)
         t.end()

test/server.test.js

@@ -55,7 +55,7 @@ tap.test('properties', function (t) {
 
   t.equal(server.url, null, 'url empty before bind')
   // listen on a random port so we have a url
-  server.listen(0, 'localhost', function () {
+  server.listen(0, '127.0.0.1', function () {
     t.ok(server.url)
 
     server.close(() => t.end())
@@ -94,7 +94,7 @@ tap.test('listen on static port', function (t) {
 
 tap.test('listen on ephemeral port', function (t) {
   const server = ldap.createServer()
-  server.listen(0, 'localhost', function () {
+  server.listen(0, '127.0.0.1', function () {
     const addr = server.address()
     t.ok(addr.port > 0)
     t.ok(addr.port < 65535)