Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Commit e4264f7

Browse files
stalbjsumners
authored andcommitted
add a callback optionnal parameter for server.close method (#528)
* add a callback optionnal parameter for server.close method net and tls server.close method accept an optional callback parameter. ldapjs server.close method delegates to net or tls server.close method and accept now an optional callback parameter... * add tests for server.close callback
1 parent 736b570 commit e4264f7

File tree

2 files changed

+30
-2
lines changed

2 files changed

+30
-2
lines changed

lib/server.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -732,8 +732,8 @@ Server.prototype.listenFD = function (fd) {
732732
this.port = fd;
733733
return this.server.listenFD(fd);
734734
};
735-
Server.prototype.close = function () {
736-
return this.server.close();
735+
Server.prototype.close = function (callback) {
736+
return this.server.close(callback);
737737
};
738738
Server.prototype.address = function () {
739739
return this.server.address();

test/server.test.js

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,4 +310,32 @@ test('non-strict routing', function (t) {
310310
});
311311
});
312312
});
313+
314+
test('close accept a callback', function (t) {
315+
server = ldap.createServer();
316+
// callback is called when the server is closed
317+
server.close(function(err){
318+
t.end();
319+
});
320+
});
321+
322+
test('close without error calls callback', function (t) {
323+
server = ldap.createServer();
324+
// when the server is closed without error, the callback parameter is undefined
325+
server.listen(389,'127.0.0.1',function(err){
326+
server.close(function(err){
327+
t.error(err);
328+
t.end();
329+
});
330+
});
331+
});
332+
333+
test('close passes error to callback', function (t) {
334+
server = ldap.createServer();
335+
// when the server is closed with an error, the error is the first parameter of the callback
336+
server.close(function(err){
337+
t.ok(err);
338+
t.end();
339+
});
340+
});
313341
});

0 commit comments

Comments
 (0)