Applied walkmod to fix pmd rules automatically (#34)

Author: ArnauPrat

src/main/java/ldbc/snb/datagen/dictionary/FlashmobTagDictionary.java

@@ -179,10 +179,8 @@ public ArrayList<FlashmobTag> generateFlashmobTags(Random rand, TreeSet<Integer>
                 Iterator<FlashmobTag> it2 = instances.iterator();
                 while (it2.hasNext()) {
                     FlashmobTag instance = it2.next();
-                    if (instance.date >= fromDate) {
-                        if (rand.nextDouble() > 1 - probInterestFlashmobTag) {
-                            result.add(instance);
-                        }
+                    if ((instance.date >= fromDate) && (rand.nextDouble() > 1 - probInterestFlashmobTag)) {
+                        result.add(instance);
                     }
                 }
             }

src/main/java/ldbc/snb/datagen/dictionary/IPAddressDictionary.java

@@ -165,7 +165,6 @@ public IP getRandomIP(Random random) {
     }
 
     private boolean changeUsualIp(Random randomDiffIP, Random randomDiffIPForTravelers, long date) {
-        double diffIpProb = randomDiffIP.nextDouble();
         double diffIpForTravelersProb = randomDiffIPForTravelers.nextDouble();
         boolean isTravelSeason = DateGenerator.isTravelSeason(date);
                 if ((isTravelSeason && diffIpForTravelersProb < probDiffIPinTravelSeason) ||

src/main/java/ldbc/snb/datagen/generator/ClusteringKnowsGenerator.java

@@ -285,7 +285,6 @@ private void estimateCCCommunity( ClusteringInfo cInfo, Community c, float prob
 
         // Computing clustering coefficient of core nodes
         for ( PersonInfo pI : c.core_ ){
-            int size = c.core_.size();
             if( pI.degree_ > 1 ) {
                 // core core triangles
                 double internalTriangles = 0.0;
@@ -294,7 +293,6 @@ private void estimateCCCommunity( ClusteringInfo cInfo, Community c, float prob
                 if(internalDegree >= 2.0) {
                     internalTriangles = (internalDegree * (internalDegree - 1) * prob);
                 }
-                boolean enteredOffset = false;
 
                 // core periphery triangles
                 double peripheryTriangles = 0;

src/main/java/ldbc/snb/datagen/generator/DateGenerator.java

@@ -61,7 +61,6 @@ public class DateGenerator {
 	private long deltaTime_;
 	private long updateThreshold_;
 	private PowerDistGenerator powerDist_;
-    private SimpleDateFormat gmtDateFormatter_;
 	private DateFormatter dateFormatter_;
 
 	// This constructor is for the case of friendship's created date generator

src/main/java/ldbc/snb/datagen/generator/DistanceKnowsGenerator.java

@@ -1,6 +1,5 @@
 package ldbc.snb.datagen.generator;
 
-import ldbc.snb.datagen.dictionary.Dictionaries;
 import ldbc.snb.datagen.objects.Knows;
 import ldbc.snb.datagen.objects.Person;
 import ldbc.snb.datagen.util.RandomGeneratorFarm;

src/main/java/ldbc/snb/datagen/generator/FlashmobPostGenerator.java

@@ -73,7 +73,6 @@ private int searchEarliest( FlashmobTag[] tags, ForumMembership membership ) {
 
     private void populateForumFlashmobTags( Random randomNumPost, Forum forum ) {
 
-	    ArrayList<Integer> forumTags = forum.tags();
 	    TreeSet<Integer> tags = new TreeSet<Integer>();
 	    for( Integer tag : tags ) {
 		    tags.add(tag);

src/main/java/ldbc/snb/datagen/generator/ForumGenerator.java

@@ -95,16 +95,14 @@ public Forum createGroup(RandomGeneratorFarm randomFarm, long forumId, Person pe
 				int candidateIndex = randomFarm.get(RandomGeneratorFarm.Aspect.MEMBERSHIP_INDEX).nextInt(persons.size());
 				Person member = persons.get(candidateIndex);
 				prob = randomFarm.get(RandomGeneratorFarm.Aspect.MEMBERSHIP).nextDouble();
-				if (prob < 0.1) {
-					if (!added.contains(member.accountId())) {
+				if ((prob < 0.1) && !added.contains(member.accountId())) {
+					added.add(member.accountId());
+					Random random = randomFarm.get(RandomGeneratorFarm.Aspect.MEMBERSHIP_INDEX);
+					date = Dictionaries.dates.randomDate(random, Math.max(forum.creationDate(), member.creationDate() + DatagenParams.deltaTime));
+					{
+						assert forum.creationDate() + DatagenParams.deltaTime <= date : "Forum creation date larger than membership date for block based members";
+						forum.addMember(new ForumMembership(forum.id(), date, new Person.PersonSummary(member)));
 						added.add(member.accountId());
-						Random random = randomFarm.get(RandomGeneratorFarm.Aspect.MEMBERSHIP_INDEX);
-						date = Dictionaries.dates.randomDate(random,Math.max(forum.creationDate(), member.creationDate()+DatagenParams.deltaTime));
-						/*if( date < Dictionaries.dates.getEndDateTime() )*/ {
-							assert forum.creationDate() +DatagenParams.deltaTime <= date : "Forum creation date larger than membership date for block based members";
-							forum.addMember(new ForumMembership(forum.id(), date, new Person.PersonSummary(member)));
-							added.add(member.accountId());
-						}
 					}
 				}
 			}

src/main/java/ldbc/snb/datagen/generator/LDBCDatagen.java

@@ -198,7 +198,6 @@ public int runGenerateJob(Configuration conf) throws Exception {
             printProgress("Sorting update streams ");
 
             int blockSize = DatagenParams.blockSize;
-            int numBlocks = (int)Math.ceil(DatagenParams.numPersons / (double)blockSize);
 
             List<String> personStreamsFileNames = new ArrayList<String>();
             List<String> forumStreamsFileNames = new ArrayList<String>();

src/main/java/ldbc/snb/datagen/generator/LikeGenerator.java

@@ -22,7 +22,6 @@
  * @author aprat
  */
 public class LikeGenerator {
-	private double maxNumberOfLikes;
 	private final PowerDistGenerator likesGenerator_;
 	private Like like;
 

src/main/java/ldbc/snb/datagen/generator/PersonActivityGenerator.java

@@ -150,7 +150,6 @@ public void generateActivityForBlock( int seed, ArrayList<Person> block, Context
 		personActivitySerializer_.reset();
 		int counter = 0;
         float personGenerationTime = 0.0f;
-        long initTime = System.currentTimeMillis();
 		for( Person p : block ) {
 			long start = System.currentTimeMillis();
 			generateActivity(p, block);