Skip to content

Commit 3208700

Browse files
committed
update READMEs
1 parent e7f28fc commit 3208700

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ It is also possible to pass a parameter file:
156156

157157
### Docker images
158158
SNB Datagen images are available via [Docker Hub](https://hub.docker.com/orgs/ldbc/repositories).
159-
The image tags follow the pattern `${DATAGEN_VERSION}-${PLATFORM_VERSION}`, e.g `ldbc/datagen-standalone:0.5.0-2.12_spark3.1`.
159+
The image tags follow the pattern `${DATAGEN_VERSION/+/-}-${PLATFORM_VERSION}`, e.g `ldbc/datagen-standalone:0.5.0-2.12_spark3.2`.
160160

161161
When building images ensure that you [use BuildKit](https://docs.docker.com/develop/develop-images/build_enhancements/#to-enable-buildkit-builds).
162162

@@ -170,27 +170,28 @@ docker run \
170170
--mount type=bind,source="$(pwd)"/out_sf0.003_interactive,target=/out \
171171
--mount type=bind,source="$(pwd)"/conf,target=/conf,readonly \
172172
-e SPARK_CONF_DIR=/conf \
173-
ldbc/datagen-standalone:latest --parallelism 1 -- --format csv --scale-factor 0.003 --mode interactive
173+
ldbc/datagen-standalone:${DATAGEN_VERSION/+/-}-${PLATFORM_VERSION} --parallelism 1 -- --format csv --scale-factor 0.003 --mode interactive
174174
```
175175

176176
The standalone Docker image can be built with the provided Dockerfile. To build, execute the following command from the repository directory:
177177

178178
```bash
179-
docker build . --target=standalone -t ldbc/datagen-standalone:latest
179+
docker build . --target=standalone -t ldbc/datagen-standalone:${DATAGEN_VERSION/+/-}-${PLATFORM_VERSION}
180180
```
181181

182182
#### JAR-only image
183183
The `ldbc/datagen-jar` image contains the assembly JAR, so it can bundled in your custom container:
184184

185185
```docker
186186
FROM my-spark-image
187-
COPY --from=ldbc/datagen-jar:latest /jar /lib/ldbc-datagen.jar
187+
ARG VERSION
188+
COPY --from=ldbc/datagen-jar:$VERSION /jar /lib/ldbc-datagen.jar
188189
```
189190

190191
The JAR-only Docker image can be built with the provided Dockerfile. To build, execute the following command from the repository directory:
191192

192193
```bash
193-
docker build . --target=jar -t ldbc/datagen-jar:latest
194+
docker build . --target=jar -t ldbc/datagen-jar:${DATAGEN_VERSION/+/-}-${PLATFORM_VERSION}
194195
```
195196
### Elastic MapReduce
196197

tools/emr/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Install the required libraries as described in the [main README](../../README.md
2828

2929
## Submitting a job
3030

31-
1. Upload the JAR to S3. (We don't version the JARs yet, so you can only make sure that you run the intended code this way :( )
31+
1. Upload the JAR to S3.
3232

3333
```bash
3434
export PLATFORM_VERSION=$(sbt -batch -error 'print platformVersion')

0 commit comments

Comments
 (0)