Merge pull request #312 from ldbc/fix-replyof-edge

szarnyasg · web-flow · commit 328b94e0c8c0 · 2021-07-09T16:58:17.000+02:00
Fix incorrect Comment generation
diff --git a/src/main/java/ldbc/snb/datagen/generator/generators/CommentGenerator.java b/src/main/java/ldbc/snb/datagen/generator/generators/CommentGenerator.java
@@ -124,7 +124,7 @@ public Stream<Pair<Comment, Stream<Like>>> createComments(RandomGeneratorFarm ra
 
             // creation date
             long minCreationDate = Math.max(parentMessage.getCreationDate(), membership.getCreationDate()) + DatagenParams.delta;
-            long maxCreationDate = Math.min(membership.getDeletionDate(), Dictionaries.dates.getSimulationEnd());
+            long maxCreationDate = Collections.min(Arrays.asList(membership.getDeletionDate(), parentMessage.getDeletionDate(), Dictionaries.dates.getSimulationEnd()));
             if (maxCreationDate <= minCreationDate) {
                 return Iterators.ForIterator.CONTINUE();
             }

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ public Stream<Pair<Comment, Stream<Like>>> createComments(RandomGeneratorFarm ra`
`124`	`124`
`125`	`125`	`// creation date`
`126`	`126`	`long minCreationDate = Math.max(parentMessage.getCreationDate(), membership.getCreationDate()) + DatagenParams.delta;`
`127`		`- long maxCreationDate = Math.min(membership.getDeletionDate(), Dictionaries.dates.getSimulationEnd());`
	`127`	`+ long maxCreationDate = Collections.min(Arrays.asList(membership.getDeletionDate(), parentMessage.getDeletionDate(), Dictionaries.dates.getSimulationEnd()));`
`128`	`128`	`if (maxCreationDate <= minCreationDate) {`
`129`	`129`	`return Iterators.ForIterator.CONTINUE();`
`130`	`130`	`}`