Skip to content

Commit a6f25dd

Browse files
committed
FactorGen: Change 'frequency' attribute for Interactive factor tables to a more descriptive name
E.g. numFriendX or numFriendOfFriendX where X may be Comments, Companies, etc.
1 parent 1299e6d commit a6f25dd

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

src/main/scala/ldbc/snb/datagen/factors/FactorGenerationStage.scala

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -527,7 +527,8 @@ object FactorGenerationStage extends DatagenStage with Logging {
527527
value = $"numFriendPosts2.numFriendPosts",
528528
by = Seq($"numFriendPosts1.Person1Id", $"numFriendPosts1.numDirectPosts", $"numFriendPosts1.numFriendPosts"),
529529
agg = sum
530-
)
530+
).select($"Person1Id", $"numDirectPosts", $"numFriendPosts", $"frequency".as("numFriendOfFriendPosts"))
531+
531532
numFriendOfFriendPosts
532533
},
533534
// comments
@@ -550,7 +551,7 @@ object FactorGenerationStage extends DatagenStage with Logging {
550551
value = $"numPersonComments2.numDirectComments",
551552
by = Seq($"numPersonComments1.Person1Id", $"numPersonComments1.numDirectComments"),
552553
agg = sum
553-
)
554+
).select($"Person1Id", $"numDirectComments", $"frequency".as("numFriendComments"))
554555
numFriendComments
555556
},
556557
// likes
@@ -563,7 +564,12 @@ object FactorGenerationStage extends DatagenStage with Logging {
563564
.as("Person")
564565
.join(personLikesMessage.as("personLikesMessage"), $"personLikesMessage.PersonId" === $"Person.id", "leftouter")
565566

566-
val personLikesNumMessages = frequency(messages, value = $"personLikesMessage.MessageId", by = Seq($"Person.id"))
567+
val personLikesNumMessages = frequency(
568+
messages,
569+
value = $"personLikesMessage.MessageId",
570+
by = Seq($"Person.id"),
571+
agg = count
572+
)
567573
personLikesNumMessages
568574
},
569575
// tags
@@ -586,7 +592,7 @@ object FactorGenerationStage extends DatagenStage with Logging {
586592
value = $"numPersonTags2.numDirectTags",
587593
by = Seq($"numPersonTags1.Person1Id", $"numPersonTags1.numDirectTags"),
588594
agg = sum
589-
)
595+
).select($"Person1Id", $"numDirectTags", $"frequency".as("numFriendTags"))
590596
numFriendTags
591597
},
592598
// forums
@@ -612,7 +618,7 @@ object FactorGenerationStage extends DatagenStage with Logging {
612618
value = $"numForums2.numDirectForums",
613619
by = Seq($"numForums1.Person1Id", $"numForums1.creationDate", $"numForums1.deletionDate", $"numForums1.numDirectForums"),
614620
agg = sum
615-
).select($"numForums1.Person1Id".as("Person1Id"), $"creationDate", $"deletionDate", $"numForums1.numDirectForums", $"frequency".as("numFriendForums"))
621+
).select($"Person1Id", $"creationDate", $"deletionDate", $"numDirectForums", $"frequency".as("numFriendForums"))
616622

617623
// forums of friends of friends
618624
val friendOfFriendForums = numFriendForums.as("numFriendForums1")
@@ -646,7 +652,7 @@ object FactorGenerationStage extends DatagenStage with Logging {
646652
value = $"numCompanies2.numDirectCompanies",
647653
by = Seq($"numCompanies1.Person1Id", $"numCompanies1.numDirectCompanies"),
648654
agg = sum
649-
).select($"numCompanies1.Person1Id".as("Person1Id"), $"numCompanies1.numDirectCompanies", $"frequency".as("numFriendCompanies"))
655+
).select($"Person1Id", $"numDirectCompanies", $"frequency".as("numFriendCompanies"))
650656

651657
// companies of friends of friends
652658
val friendOfFriendCompanies = numFriendCompanies.as("numFriendCompanies1")
@@ -658,7 +664,8 @@ object FactorGenerationStage extends DatagenStage with Logging {
658664
value = $"numFriendCompanies2.numFriendCompanies",
659665
by = Seq($"numFriendCompanies1.Person1Id", $"numFriendCompanies1.numDirectCompanies", $"numFriendCompanies1.numFriendCompanies"),
660666
agg = sum
661-
)
667+
).select($"Person1Id", $"numDirectCompanies", $"numFriendCompanies", $"frequency".as("numFriendOfFriendCompanies"))
668+
662669
numFriendOfFriendCompanies
663670
},
664671
)

0 commit comments

Comments
 (0)