IMproved memory usage during person activity generation

Author: ArnauPrat

src/main/java/ldbc/snb/datagen/generator/CommentGenerator.java

@@ -24,11 +24,13 @@ public class CommentGenerator {
 	private String[] shortComments_ = {"ok", "good", "great", "cool", "thx", "fine", "LOL", "roflol", "no way!", "I see", "right", "yes", "no", "duh", "thanks", "maybe"};
 	private TextGenerator generator;
 	private LikeGenerator likeGenerator_;
+    private Comment comment_;
 	/* A set of random number generator for different purposes.*/
 
 	public CommentGenerator(TextGenerator generator, LikeGenerator likeGenerator){
 		this.generator = generator;
 		this.likeGenerator_ = likeGenerator;
+        this.comment_ = new Comment();
 	}
 
 	public long createComments(RandomGeneratorFarm randomFarm, final Forum forum, final Post post, long numComments, long startId, PersonActivityExporter exporter){
@@ -91,7 +93,7 @@ public long createComments(RandomGeneratorFarm randomFarm, final Forum forum, fi
 					Dictionaries.browsers.getPostBrowserId(randomFarm.get(RandomGeneratorFarm.Aspect.DIFF_BROWSER), randomFarm.get(RandomGeneratorFarm.Aspect.BROWSER), member.person().browserId()),
 					post.messageId(),
 					replyTo.messageId());
-				if(!isShort) replyCandidates.add(comment);
+				if(!isShort) replyCandidates.add(new Comment(comment));
 				exporter.export(comment);
 				if( comment.content().length() > 10 && randomFarm.get(RandomGeneratorFarm.Aspect.NUM_LIKE).nextDouble() <= 0.1 ) {
 					likeGenerator_.generateLikes(randomFarm.get(RandomGeneratorFarm.Aspect.NUM_LIKE), forum, comment, Like.LikeType.COMMENT, exporter);

src/main/java/ldbc/snb/datagen/generator/PhotoGenerator.java

@@ -21,11 +21,13 @@
 public class PhotoGenerator {
 	private long postId = 0;
 	private LikeGenerator likeGenerator_;
+	private Photo photo_;
 
 	private static final String SEPARATOR = "  ";
 
 	public PhotoGenerator(LikeGenerator likeGenerator) {
 		this.likeGenerator_ = likeGenerator;
+		this.photo_ = new Photo();
 	}
 	public long createPhotos(RandomGeneratorFarm randomFarm, final Forum album, final ArrayList<ForumMembership> memberships, long numPhotos, long startId, PersonActivityExporter exporter){
 		long nextId = startId;
@@ -77,10 +79,10 @@ public long createPhotos(RandomGeneratorFarm randomFarm, final Forum album, fina
 			long date = album.creationDate()+DatagenParams.deltaTime+1000*(i+1);
 			if( date <= Dictionaries.dates.getEndDateTime() ) {
 				long id = SN.formId(SN.composeId(nextId++,date));
-				Photo photo = new Photo(id,date,album.moderator(), album.id(), "photo"+id+".jpg",tags,album.moderator().ipAddress(),album.moderator().browserId(),latt,longt);
-				exporter.export(photo);
+				photo_.initialize(id,date,album.moderator(), album.id(), "photo"+id+".jpg",tags,album.moderator().ipAddress(),album.moderator().browserId(),latt,longt);
+				exporter.export(photo_);
 				if( randomFarm.get(RandomGeneratorFarm.Aspect.NUM_LIKE).nextDouble() <= 0.1 ) {
-					likeGenerator_.generateLikes(randomFarm.get(RandomGeneratorFarm.Aspect.NUM_LIKE), album, photo, Like.LikeType.PHOTO, exporter);
+					likeGenerator_.generateLikes(randomFarm.get(RandomGeneratorFarm.Aspect.NUM_LIKE), album, photo_, Like.LikeType.PHOTO, exporter);
 				}
 			}
 		}

src/main/java/ldbc/snb/datagen/generator/PostGenerator.java

@@ -54,6 +54,7 @@ abstract public class PostGenerator {
 	private TextGenerator generator_;
 	private CommentGenerator commentGenerator_;
 	private LikeGenerator likeGenerator_;
+	private Post post_;
 
 	static protected class PostInfo {
 		public TreeSet<Integer> tags;
@@ -71,6 +72,7 @@ public PostGenerator( TextGenerator generator, CommentGenerator commentGenerator
 		this.generator_ = generator;
 		this.commentGenerator_ = commentGenerator;
 		this.likeGenerator_ = likeGenerator;
+		this.post_ = new Post();
 	}
 
 	/** @brief Initializes the post generator.*/
@@ -99,7 +101,7 @@ public long createPosts(RandomGeneratorFarm randomFarm, final Forum forum, final
 
 					// crear properties class para passar
 					content = this.generator_.generateText(member.person(), postInfo.tags,prop);
-					Post post = new Post( SN.formId(SN.composeId(postId++,postInfo.date)),
+					post_.initialize( SN.formId(SN.composeId(postId++,postInfo.date)),
 						postInfo.date,
 						member.person(),
 						forum.id(),
@@ -108,15 +110,15 @@ public long createPosts(RandomGeneratorFarm randomFarm, final Forum forum, final
 						Dictionaries.ips.getIP(randomFarm.get(RandomGeneratorFarm.Aspect.IP), randomFarm.get(RandomGeneratorFarm.Aspect.DIFF_IP), randomFarm.get(RandomGeneratorFarm.Aspect.DIFF_IP_FOR_TRAVELER), member.person().ipAddress(), postInfo.date),
 						Dictionaries.browsers.getPostBrowserId(randomFarm.get(RandomGeneratorFarm.Aspect.DIFF_BROWSER), randomFarm.get(RandomGeneratorFarm.Aspect.BROWSER), member.person().browserId()),
 						forum.language());
-					exporter.export(post);
+					exporter.export(post_);
 
 					if( randomFarm.get(RandomGeneratorFarm.Aspect.NUM_LIKE).nextDouble() <= 0.1 ) {
-						likeGenerator_.generateLikes(randomFarm.get(RandomGeneratorFarm.Aspect.NUM_LIKE), forum, post, Like.LikeType.POST, exporter);
+						likeGenerator_.generateLikes(randomFarm.get(RandomGeneratorFarm.Aspect.NUM_LIKE), forum, post_, Like.LikeType.POST, exporter);
 					}
 
 					//// generate comments
 					int numComments = randomFarm.get(RandomGeneratorFarm.Aspect.NUM_COMMENT).nextInt(DatagenParams.maxNumComments+1);
-					postId = commentGenerator_.createComments(randomFarm, forum, post, numComments, postId, exporter);
+					postId = commentGenerator_.createComments(randomFarm, forum, post_, numComments, postId, exporter);
 				}
 			}
 		}

src/main/java/ldbc/snb/datagen/objects/Comment.java

@@ -50,6 +50,12 @@ public Comment() {
         super();
     }
 
+    public Comment( Comment comment ) {
+        super(comment.messageId(), comment.creationDate(), comment.author(), comment.forumId(), comment.content(), comment.tags(), comment.ipAddress(), comment.browserId());
+        postId_ = comment.postId();
+        replyOf_ = comment.replyOf();
+    }
+
     public Comment(long commentId,
                    long creationDate,
                    PersonSummary author,

src/main/java/ldbc/snb/datagen/objects/Photo.java

@@ -45,6 +45,10 @@ public class Photo extends Message {
     private double latt_;
     private double longt_;
 
+    public Photo() {
+        super();
+    }
+
     public Photo(long messageId,
                  long creationDate,
                  PersonSummary author,
@@ -61,6 +65,23 @@ public Photo(long messageId,
         longt_ = longt;
     }
 
+    public void initialize(long messageId,
+                 long creationDate,
+                 PersonSummary author,
+                 long forumId,
+                 String content,
+                 TreeSet<Integer> tags,
+                 IP ipAddress,
+                 int browserId,
+                 double latt,
+                 double longt
+    ) {
+        super.initialize(messageId, creationDate, author, forumId, content, tags, ipAddress, browserId);
+        latt_ = latt;
+        longt_ = longt;
+    }
+
+
     public double latt() {
 	    return latt_;
     }

src/main/java/ldbc/snb/datagen/objects/Post.java

@@ -48,6 +48,10 @@ public class Post extends Message {
      * < @brief The language used in the post.
      */
 
+    public Post() {
+        super();
+    }
+
     public Post(long postId,
                 long creationDate,
                 PersonSummary author,
@@ -62,6 +66,20 @@ public Post(long postId,
         language_ = language;
     }
 
+    public void initialize(long postId,
+                long creationDate,
+                PersonSummary author,
+                long forumId,
+                String content,
+                TreeSet<Integer> tags,
+                IP ipAddress,
+                int browserId,
+                int language
+    )  {
+        super.initialize(postId, creationDate, author, forumId, content, tags, ipAddress, browserId);
+        language_ = language;
+    }
+
     public int language() {
 	    return language_;
     }