Skip to content

Commit b353d73

Browse files
committed
Fixed test command
Changed entity id generation to better use the available bits
1 parent 4697e0f commit b353d73

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

src/main/java/ldbc/snb/datagen/generator/PersonGenerator.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,9 @@ public PersonGenerator( Configuration conf, String degreeDistribution ) {
4141
}
4242

4343
private long composeUserId(long id, long date) {
44-
long idMask = ~(0xFFFFFFFFFFFFFFFFL << 40);
45-
//long bucket = (long) (256 * (date - Dictionaries.dates.getStartDateTime()) / (double) Dictionaries.dates.getMaxDateTime());
44+
long idMask = ~(0xFFFFFFFFFFFFFFFFL << 41);
4645
long bucket = (long) (256 * (date - Dictionaries.dates.getStartDateTime()) / (double) Dictionaries.dates.getEndDateTime());
47-
return (bucket << 40) | ((id & idMask));
46+
return (bucket << 41) | ((id & idMask));
4847
}
4948

5049
/** Tells if a person is a large poster or not.

src/main/java/ldbc/snb/datagen/vocabulary/SN.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,10 @@ public class SN {
5858
*/
5959

6060
public static void initialize() {
61-
minDate = Dictionaries.dates.getStartDateTime();
62-
//maxDate = Dictionaries.dates.getMaxDateTime();
61+
minDate = Dictionaries.dates.getStartDateTime();
6362
maxDate = Dictionaries.dates.getEndDateTime();
6463
numBits = (int) Math.ceil(Math.log10(Math.ceil(DatagenParams.numPersons/(double)DatagenParams.blockSize)) / Math.log10(2));
65-
if (numBits > 14) System.out.print("WARNING: Possible id overlapp");
64+
if (numBits > 20) System.out.print("WARNING: Possible id overlapp");
6665
}
6766

6867
/**
@@ -168,7 +167,7 @@ public static Long formId(long id) {
168167

169168
public static long composeId(long id, long date) {
170169
long bucket = (long) (256 * (date - minDate) / (double) maxDate);
171-
long idMask = ~(0xFFFFFFFFFFFFFFFFL << 33);
172-
return (bucket << 33) | (id & idMask);
170+
long idMask = ~(0xFFFFFFFFFFFFFFFFL << 36);
171+
return (bucket << 36) | (id & idMask);
173172
}
174173
}

src/test/java/ldbc/snb/datagen/test/LDBCDatagenTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public class LDBCDatagenTest {
2525

2626
@BeforeClass
2727
public static void generateData() {
28-
ProcessBuilder pb = new ProcessBuilder("java", "-ea","-cp","target/ldbc_snb_datagen-0.2.5.jar","ldbc.snb.datagen.generator.LDBCDatagen","./test_params.ini");
28+
ProcessBuilder pb = new ProcessBuilder("java", "-ea","-cp","target/ldbc_snb_datagen-0.2.5-jar-with-dependencies.jar","ldbc.snb.datagen.generator.LDBCDatagen","./test_params.ini");
2929
pb.directory(new File("./"));
3030
File log = new File("test_log");
3131
pb.redirectErrorStream(true);

0 commit comments

Comments
 (0)