Skip to content

Commit e6213b5

Browse files
authored
Merge pull request #114 from ldbc/exception-handling
Throw RuntimeExceptions to fail as early as possible
2 parents 4e0fa45 + 753a414 commit e6213b5

34 files changed

+45
-52
lines changed

src/main/java/ldbc/snb/datagen/LdbcDatagen.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,6 @@ public static void main(String[] args) throws Exception {
348348
} catch (Exception e) {
349349
System.err.println("Error during execution");
350350
System.err.println(e.getMessage());
351-
e.printStackTrace();
352351
throw e;
353352
}
354353
}

src/main/java/ldbc/snb/datagen/dictionary/BrowserDictionary.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ private void load(String fileName) {
7373
}
7474
dictionary.close();
7575
} catch (IOException e) {
76-
e.printStackTrace();
76+
throw new RuntimeException(e);
7777
}
7878
}
7979

src/main/java/ldbc/snb/datagen/dictionary/CompanyDictionary.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ private void load(String fileName) {
114114
}
115115
dictionary.close();
116116
} catch (IOException e) {
117-
e.printStackTrace();
117+
throw new RuntimeException(e);
118118
}
119119
}
120120

src/main/java/ldbc/snb/datagen/dictionary/EmailDictionary.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ private void load(String fileName) {
8686
}
8787
emailDictionary.close();
8888
} catch (IOException e) {
89-
e.printStackTrace();
89+
throw new RuntimeException(e);
9090
}
9191
}
9292

src/main/java/ldbc/snb/datagen/dictionary/IPAddressDictionary.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ private void load(String mappingFileName, String baseIPdir) {
119119
ipZoneFile.close();
120120
}
121121
} catch (IOException e) {
122-
e.printStackTrace();
122+
throw new RuntimeException(e);
123123
}
124124
}
125125

src/main/java/ldbc/snb/datagen/dictionary/LanguageDictionary.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ private void load(String fileName) {
124124
}
125125
dictionary.close();
126126
} catch (IOException e) {
127-
e.printStackTrace();
127+
throw new RuntimeException(e);
128128
}
129129
}
130130

src/main/java/ldbc/snb/datagen/dictionary/NamesDictionary.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public void extractSurNames() {
110110
surnameDictionary.close();
111111
System.out.println("Done ... " + totalSurNames + " surnames were extracted ");
112112
} catch (IOException e) {
113-
e.printStackTrace();
113+
throw new RuntimeException(e);
114114
}
115115
}
116116

@@ -140,7 +140,7 @@ public void extractGivenNames() {
140140
givennameDictionary.close();
141141
System.out.println("Done ... " + totalGivenNames + " given names were extracted ");
142142
} catch (IOException e) {
143-
e.printStackTrace();
143+
throw new RuntimeException(e);
144144
}
145145
}
146146

src/main/java/ldbc/snb/datagen/dictionary/PlaceDictionary.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ private void readCities(String fileName) {
291291
}
292292
dictionary.close();
293293
} catch (IOException e) {
294-
e.printStackTrace();
294+
throw new RuntimeException(e);
295295
}
296296
}
297297

@@ -331,7 +331,7 @@ private void readCountries(String fileName) {
331331
cumulativeDistribution = new Float[temporalCumulative.size()];
332332
cumulativeDistribution = temporalCumulative.toArray(cumulativeDistribution);
333333
} catch (IOException e) {
334-
e.printStackTrace();
334+
throw new RuntimeException(e);
335335
}
336336
}
337337

@@ -372,7 +372,7 @@ private void readContinents(String fileName) {
372372
}
373373
dictionary.close();
374374
} catch (IOException e) {
375-
e.printStackTrace();
375+
throw new RuntimeException(e);
376376
}
377377
}
378378

src/main/java/ldbc/snb/datagen/dictionary/PopularPlacesDictionary.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ private void load(String fileName) {
107107
}
108108
dicPopularPlace.close();
109109
} catch (IOException e) {
110-
e.printStackTrace();
110+
throw new RuntimeException(e);
111111
}
112112
}
113113

src/main/java/ldbc/snb/datagen/dictionary/TagDictionary.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ private void load(String tagsFileName, String popularTagByCountryFileName, Strin
227227

228228
dictionary.close();
229229
} catch (IOException e) {
230-
e.printStackTrace();
230+
throw new RuntimeException(e);
231231
}
232232
}
233233

0 commit comments

Comments
 (0)