[LDC] Use . instead of :: as CodeView DI scope separator

For compile units with D language tag, i.e., if compiled with `-g`.

Author: kinke

llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp

@@ -300,17 +300,26 @@ const DISubprogram *CodeViewDebug::collectParentScopeNames(
 }
 
 static std::string formatNestedName(ArrayRef<StringRef> QualifiedNameComponents,
-                                    StringRef TypeName) {
+                                    StringRef TypeName,
+                                    const std::string &Separator) {
   std::string FullyQualifiedName;
   for (StringRef QualifiedNameComponent :
        llvm::reverse(QualifiedNameComponents)) {
     FullyQualifiedName.append(std::string(QualifiedNameComponent));
-    FullyQualifiedName.append("::");
+    FullyQualifiedName.append(Separator);
   }
   FullyQualifiedName.append(std::string(TypeName));
   return FullyQualifiedName;
 }
 
+// Added for LDC: use `.` as scope separator for compile units with D language
+// tag.
+const char *CodeViewDebug::getScopeSeparator() const {
+  NamedMDNode *CUs = MMI->getModule()->getNamedMetadata("llvm.dbg.cu");
+  const DICompileUnit *CU = cast<DICompileUnit>(*CUs->operands().begin());
+  return CU->getSourceLanguage() == dwarf::DW_LANG_D ? "." : "::";
+}
+
 struct CodeViewDebug::TypeLoweringScope {
   TypeLoweringScope(CodeViewDebug &CVD) : CVD(CVD) { ++CVD.TypeEmissionLevel; }
   ~TypeLoweringScope() {
@@ -331,7 +340,7 @@ std::string CodeViewDebug::getFullyQualifiedName(const DIScope *Scope,
   TypeLoweringScope S(*this);
   SmallVector<StringRef, 5> QualifiedNameComponents;
   collectParentScopeNames(Scope, QualifiedNameComponents);
-  return formatNestedName(QualifiedNameComponents, Name);
+  return formatNestedName(QualifiedNameComponents, Name, getScopeSeparator());
 }
 
 std::string CodeViewDebug::getFullyQualifiedName(const DIScope *Ty) {
@@ -1487,8 +1496,8 @@ void CodeViewDebug::addToUDTs(const DIType *Ty) {
   const DISubprogram *ClosestSubprogram =
       collectParentScopeNames(Ty->getScope(), ParentScopeNames);
 
-  std::string FullyQualifiedName =
-      formatNestedName(ParentScopeNames, getPrettyScopeName(Ty));
+  std::string FullyQualifiedName = formatNestedName(
+      ParentScopeNames, getPrettyScopeName(Ty), getScopeSeparator());
 
   if (ClosestSubprogram == nullptr) {
     GlobalUDTs.emplace_back(std::move(FullyQualifiedName), Ty);

llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h

@@ -286,6 +286,9 @@ class LLVM_LIBRARY_VISIBILITY CodeViewDebug : public DebugHandlerBase {
     LocalUDTs.clear();
   }
 
+  // LDC
+  const char *getScopeSeparator() const;
+
   /// Emit the magic version number at the start of a CodeView type or symbol
   /// section. Appears at the front of every .debug$S or .debug$T or .debug$P
   /// section.