Skip to content

Commit 27581fc

Browse files
committed
[LDC] PGO: Avoid COMDAT members with private linkage for Windows
To prevent according IR verifier errors with IR-based PGO ('comdat global value has private linkage').
1 parent 310b277 commit 27581fc

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

llvm/lib/ProfileData/InstrProf.cpp

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -508,8 +508,13 @@ GlobalVariable *createPGOFuncNameVar(Module &M,
508508
else if (Linkage == GlobalValue::AvailableExternallyLinkage)
509509
Linkage = GlobalValue::LinkOnceODRLinkage;
510510
else if (Linkage == GlobalValue::InternalLinkage ||
511-
Linkage == GlobalValue::ExternalLinkage)
512-
Linkage = GlobalValue::PrivateLinkage;
511+
Linkage == GlobalValue::ExternalLinkage) {
512+
// LDC: use internal instead of private linkage for COFF (still local, but
513+
// allows for COMDATs on Windows)
514+
Linkage = Triple(M.getTargetTriple()).isOSBinFormatCOFF()
515+
? GlobalValue::InternalLinkage
516+
: GlobalValue::PrivateLinkage;
517+
}
513518

514519
auto *Value =
515520
ConstantDataArray::getString(M.getContext(), PGOFuncName, false);

0 commit comments

Comments
 (0)