fix: try to fix FunctionDefinition for Gemini pro's MALFORMED_FUNCTION_CALL

Author: zensh

anda_engine/Cargo.toml

@@ -3,7 +3,7 @@ name = "anda_engine"
 description = "Agents engine for Anda -- an AI agent framework built with Rust, powered by ICP and TEEs."
 repository = "https://github.com/ldclabs/anda/tree/main/anda_engine"
 publish = true
-version = "0.9.15"
+version = "0.9.16"
 edition.workspace = true
 keywords.workspace = true
 categories.workspace = true

anda_engine/src/memory.rs

@@ -46,10 +46,10 @@ pub static FUNCTION_DEFINITION: LazyLock<FunctionDefinition> = LazyLock::new(||
                 },
                 "parameters": {
                     "type": "object",
-                    "description": "JSON object of key-value pairs for safe placeholder substitution (placeholders start with ':', e.g., :name). Must be complete JSON tokens; do not embed in quoted strings."
+                    "description": "Optional JSON object of key-value pairs for safe placeholder substitution (placeholders start with ':', e.g., :name). Must be complete JSON tokens; do not embed in quoted strings. Only provide if placeholders are used in the command."
                 }
             },
-            "required": ["command", "parameters"]
+            "required": ["command"]
         }
     })).unwrap()
 });
@@ -263,6 +263,7 @@ pub struct MemoryManagement {
     logs: Arc<Collection>,
     resources: Arc<Collection>,
     enable_kip_logging: bool,
+    kip_function_definitions: FunctionDefinition,
 }
 
 impl MemoryManagement {
@@ -342,9 +343,15 @@ impl MemoryManagement {
             logs,
             resources,
             enable_kip_logging: true,
+            kip_function_definitions: FUNCTION_DEFINITION.clone(),
         })
     }
 
+    pub fn with_kip_function_definitions(mut self, def: FunctionDefinition) -> Self {
+        self.kip_function_definitions = def;
+        self
+    }
+
     pub fn disable_kip_logging(&mut self) {
         self.enable_kip_logging = false;
     }
@@ -630,15 +637,15 @@ impl Tool<BaseCtx> for Arc<MemoryManagement> {
     type Output = Response;
 
     fn name(&self) -> String {
-        FUNCTION_DEFINITION.name.clone()
+        self.kip_function_definitions.name.clone()
     }
 
     fn description(&self) -> String {
-        FUNCTION_DEFINITION.description.clone()
+        self.kip_function_definitions.description.clone()
     }
 
     fn definition(&self) -> FunctionDefinition {
-        FUNCTION_DEFINITION.clone()
+        self.kip_function_definitions.clone()
     }
 
     async fn call(

anda_engine/src/model/gemini.rs

@@ -89,6 +89,8 @@ impl Client {
 pub struct CompletionModel {
     /// Gemini client instance
     client: Client,
+    /// Default request template
+    default_request: types::GenerateContentRequest,
     /// Model identifier
     pub model: String,
 }
@@ -100,11 +102,20 @@ impl CompletionModel {
     /// * `client` - Gemini client instance
     /// * `model` - Model identifier string
     pub fn new(client: Client, model: &str) -> Self {
+        let mut default_request = types::GenerateContentRequest::default();
+        default_request.generation_config.top_p = Some(0.95);
         Self {
             client,
+            default_request,
             model: model.to_string(),
         }
     }
+
+    /// Sets a default request template for the model
+    pub fn with_default_request(mut self, greq: types::GenerateContentRequest) -> Self {
+        self.default_request = greq;
+        self
+    }
 }
 
 impl CompletionFeatures for CompletionModel {
@@ -129,12 +140,12 @@ impl CompletionFeaturesDyn for CompletionModel {
     fn completion(&self, req: CompletionRequest) -> BoxPinFut<Result<AgentOutput, BoxError>> {
         let model = self.model.clone();
         let client = self.client.clone();
+        let mut greq = self.default_request.clone();
 
         Box::pin(async move {
             let timestamp = unix_ms();
             let mut raw_history: Vec<Json> = Vec::new();
             let mut chat_history: Vec<Message> = Vec::new();
-            let mut greq = types::GenerateContentRequest::default();
 
             if !req.instructions.is_empty() {
                 greq.system_instruction = Some(types::Content {
@@ -185,7 +196,6 @@ impl CompletionFeaturesDyn for CompletionModel {
                 greq.contents.push(msg);
             }
 
-            greq.generation_config.top_p = Some(0.95);
             if let Some(temperature) = req.temperature {
                 greq.generation_config.temperature = Some(temperature);
             }