update for No sites/data found using the selection criteria specified text (not xml)

Author: ldecicco-USGS

R/getWebServiceData.R

@@ -54,9 +54,8 @@ getWebServiceData <- function(obs_url, ...) {
       returnedDoc <- httr2::resp_body_string(returnedList)
     } else if (content %in% return_readLines) {
       returnedList <- httr2::resp_body_string(returnedList)
-      txt <- readLines(returnedList$content)
-      message(txt)
-      return(txt)
+      message(returnedList)
+      returnedDoc <- returnedList
     } else if (content %in% return_json){
       returnedDoc <- httr2::resp_body_json(returnedList)
     } else {

tests/testthat/tests_userFriendly_fxns.R

@@ -103,6 +103,12 @@ test_that("peak, rating curves, surface-water measurements", {
   siteID <- "263819081585801"
   gwl_1 <- readNWISgwl(siteID)
   expect_equal(unique(gwl_1$site_no), siteID)
+  
+  # No data:
+  expect_message(readNWISpeak(stations, 
+                            startDate = "2024-08-01",
+                            endDate = "2024-08-31",
+                            convertType = FALSE))
 })
 
 test_that("NWIS dv tests", {

vignettes/Status.Rmd

@@ -34,6 +34,7 @@ If you have additional questions about the NWIS qw data service, email CompTools
 * The output of the "constructURL..." functions are now `httr2` requests instead of a character string. 
 
 * The update to `httr2` will give us more flexibility to set up the eventual replacements to the NWIS web services. Over the next year, expect to see some new and major updates to USGS data access. dataRetrieval WILL stay on the cutting edge for accessing new USGS APIs. 
+
 * WQP continues to default to the legacy system (that does not include recent USGS discrete sample data). To access the most recent USGS data from the new "WQX3" services use the function `readWQPqw` and set the argument `legacy=FALSE` or use the function `readWQPdata` and set the argument `service = "ResultWQX3"`. Why aren't the new services set as default? This is because the WQP itself still considers those services "beta", and therefore performance is not guaranteed.  
 
 * Finally, saving the best for last! There's a new set of functions that access the new USGS "samples-data" services. This is a USGS-specific service for discrete sample data. If you are only interested in USGS discrete water quality data (as opposed to USGS AND non-USGS discrete water quality data available from Water Quality Portal), you can use the `read_USGS_samples` function.