Fix: warnings

Author: lduchosal

src/System.Net.IPNetwork/CidrClassFull.cs

@@ -29,40 +29,40 @@ public sealed class CidrClassFull : ICidrGuess
     /// <returns>true if ip was converted successfully; otherwise, false.</returns>
     public bool TryGuessCidr(string ip, out byte cidr)
     {
-            bool parsed = IPAddress.TryParse($"{ip}", out var ipaddress);
-            if (parsed == false)
-            {
-                cidr = 0;
-                return false;
-            }
-
-            if (ipaddress.AddressFamily == AddressFamily.InterNetworkV6)
-            {
-                cidr = 64;
-                return true;
-            }
+        bool parsed = IPAddress.TryParse($"{ip}", out var ipaddress);
+        if (parsed == false)
+        {
+            cidr = 0;
+            return false;
+        }
 
-            var uintIPAddress = IPNetwork2.ToBigInteger(ipaddress);
-            uintIPAddress = uintIPAddress >> 30;
-            if (uintIPAddress <= 1)
-            {
-                cidr = 8;
-                return true;
-            }
+        if (ipaddress.AddressFamily == AddressFamily.InterNetworkV6)
+        {
+            cidr = 64;
+            return true;
+        }
 
-            if (uintIPAddress <= 2)
-            {
-                cidr = 16;
-                return true;
-            }
+        var uintIPAddress = IPNetwork2.ToBigInteger(ipaddress);
+        uintIPAddress = uintIPAddress >> 30;
+        if (uintIPAddress <= 1)
+        {
+            cidr = 8;
+            return true;
+        }
 
-            if (uintIPAddress <= 3)
-            {
-                cidr = 24;
-                return true;
-            }
+        if (uintIPAddress <= 2)
+        {
+            cidr = 16;
+            return true;
+        }
 
-            cidr = 0;
-            return false;
+        if (uintIPAddress <= 3)
+        {
+            cidr = 24;
+            return true;
         }
+
+        cidr = 0;
+        return false;
+    }
 }

src/System.Net.IPNetwork/CidrClassLess.cs

@@ -7,7 +7,7 @@ namespace System.Net;
 using System.Net.Sockets;
 
 /// <summary>
-/// Try to guess a CIDR in a ClassLess way ie. ipv4 = 32, ipv6 = 128.
+/// Try to guess a CIDR in a ClassLess way: ipv4 = 32, ipv6 = 128.
 /// </summary>
 public sealed class CidrClassLess : ICidrGuess
 {
@@ -17,7 +17,7 @@ public sealed class CidrClassLess : ICidrGuess
     /// IPV6 : 128.
     ///
     /// </summary>
-    /// <param name="ip">A string representing an ipadress that will be used to guess CIDR.</param>
+    /// <param name="ip">A string representing an IPAddress that will be used to guess CIDR.</param>
     /// <param name="cidr">A byte representing the netmask in cidr format (/24).</param>
     /// <returns>true if ip was converted successfully; otherwise, false.</returns>
     public bool TryGuessCidr(string ip, out byte cidr)

src/System.Net.IPNetwork/IPNetwork2WideSubnet.cs

@@ -48,10 +48,10 @@ public static IPNetwork2 WideSubnet(string start, string end)
             throw new NotSupportedException("MixedAddressFamily");
         }
 
-        var ipnetwork = new IPNetwork2(0, startIP.AddressFamily, 0);
+        IPNetwork2 ipnetwork;
 
         // ReSharper disable once ConditionIsAlwaysTrueOrFalse
-        for (byte cidr = 32; cidr >= 0; cidr--)
+        for (byte cidr = 32; ; cidr--)
         {
             var wideSubnet = Parse(start, cidr);
             if (wideSubnet.Contains(endIP))
@@ -148,10 +148,9 @@ internal static void InternalWideSubnet(bool tryWide, IPNetwork2[] ipnetworks, o
             }
         }
 
-        var ipn = new IPNetwork2(0, family, 0);
+        IPNetwork2 ipn;
 
-        // ReSharper disable once ConditionIsAlwaysTrueOrFalse
-        for (byte cidr = nnin0.cidr; cidr >= 0; cidr--)
+        for (byte cidr = nnin0.cidr; ; cidr--)
         {
             var wideSubnet = new IPNetwork2(uintNnin0, family, cidr);
             if (wideSubnet.Contains(ipaddressX))

src/ipnetwork.sln.DotSettings

@@ -5,5 +5,7 @@
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=bmask/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=ipnet/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=ipnetworks/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=ipnx/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=nnin/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=widesubnet/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=wildcardmask/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>