Fix: quality

Author: lduchosal

src/System.Net.IPNetwork/UniqueLocalAddress.cs

@@ -81,7 +81,7 @@ public static IPNetwork2 GenerateUlaPrefix(string seed)
     {
         if (string.IsNullOrEmpty(seed))
         {
-            throw new ArgumentNullException("Seed cannot be null or empty", nameof(seed));
+            throw new ArgumentNullException(nameof(seed), "Seed cannot be null or empty");
         }
 
         byte[] globalId = GenerateGlobalIdFromSeed(seed);

src/TestProject/IPAddressExtensionTests.cs

@@ -98,10 +98,7 @@ e XOR'd with the byte count so the two sequences will be different. */
         foreach (int i in Enumerable.Range(1, 1000))
         {
             /* Hash the current interation to get a new block of deterministic bytes. */
-            using (var hash = SHA256.Create())
-            {
-                hashInput = hash.ComputeHash(hashInput);
-            }
+            hashInput = SHA256.HashData(hashInput);
 
             /* Convert the first n bytes for an address. 4 will have an IPv4. 16 will make an IPv6. */
             yield return new IPAddress(hashInput.Take(byteCount).ToArray()).ToString();

src/TestProject/UniqueLocalAddressTest.cs

@@ -362,7 +362,7 @@ public void TestUlaGeneration_ProducesUniqueResults()
         }
 
         // Assert - Should produce mostly unique results
-        Assert.IsTrue(generatedUlas.Count > iterations * 0.9,
+        Assert.IsGreaterThan(iterations * 0.9, generatedUlas.Count,
             "ULA generation should produce highly unique results");
     }
 
@@ -421,7 +421,7 @@ public void GenerateUlaPrefix_NoSeed_Tends_To_Vary()
             seen.Add(UniqueLocalAddress.GenerateUlaPrefix().ToString());
         }
 
-        Assert.IsTrue(seen.Count >= 2, "Multiple calls should usually produce at least two distinct prefixes.");
+        Assert.IsGreaterThanOrEqualTo(2, seen.Count, "Multiple calls should usually produce at least two distinct prefixes.");
     }
 
     /// <summary>