Feat: code cleanup (#352)

lduchosal · web-flow · commit 8646dd13a6eb · 2025-03-30T19:31:09.000+02:00
* Feat: code analysis
* Feat: cleanup net46 instructs
* Feat: cleanup TRAVISCI
* Fix: using
* Fix: reorder usings
* Fix: nuget licence
diff --git a/src/.editorconfig b/src/.editorconfig
@@ -144,11 +144,6 @@ dotnet_naming_style.pascal_case.required_suffix =
 dotnet_naming_style.pascal_case.word_separator =
 dotnet_naming_style.pascal_case.capitalization = pascal_case
 
-dotnet_naming_style.pascal_case.required_prefix =
-dotnet_naming_style.pascal_case.required_suffix =
-dotnet_naming_style.pascal_case.word_separator =
-dotnet_naming_style.pascal_case.capitalization = pascal_case
-
 # SA1208: System using directives should be placed before other using directives
 dotnet_diagnostic.SA1208.severity = error
 
@@ -253,8 +248,3 @@ dotnet_naming_style.casse_pascal.required_prefix =
 dotnet_naming_style.casse_pascal.required_suffix =
 dotnet_naming_style.casse_pascal.word_separator =
 dotnet_naming_style.casse_pascal.capitalization = pascal_case
-
-dotnet_naming_style.casse_pascal.required_prefix =
-dotnet_naming_style.casse_pascal.required_suffix =
-dotnet_naming_style.casse_pascal.word_separator =
-dotnet_naming_style.casse_pascal.capitalization = pascal_case
diff --git a/src/ConsoleApplication/ConsoleApplication.csproj b/src/ConsoleApplication/ConsoleApplication.csproj
@@ -8,31 +8,21 @@
 		<Version>3.1.0</Version>
 		<RootNamespace>System.Net</RootNamespace>
 		<LangVersion>latestmajor</LangVersion>
-
+		<GenerateDocumentationFile>true</GenerateDocumentationFile>
 	</PropertyGroup>
 
 	<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
 	  <NoWarn />
+	  <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
 	</PropertyGroup>
 
 	<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
 	  <NoWarn />
+	  <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
 	</PropertyGroup>
-
-	<ItemGroup>
-	  <None Remove="stylecop.json" />
-	</ItemGroup>
-
-	<ItemGroup>
-	  <AdditionalFiles Include="stylecop.json" />
-	</ItemGroup>
-
+	
 	<ItemGroup>
 	  <PackageReference Include="GnuGetOpt" Version="0.9.2.6" />
-	  <PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
-	    <PrivateAssets>all</PrivateAssets>
-	    <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-	  </PackageReference>
 	</ItemGroup>
 
 	<ItemGroup>
diff --git a/src/ConsoleApplication/Program.cs b/src/ConsoleApplication/Program.cs
@@ -4,12 +4,12 @@
 
 namespace System.Net;
 
-using Collections.Generic;
-using Diagnostics;
-using IO;
-using Numerics;
-using Reflection;
 using Gnu.Getopt;
+using System.Collections.Generic;
+using System.Diagnostics;
+using System.IO;
+using System.Numerics;
+using System.Reflection;
 
 /// <summary>
 /// Console app for IPNetwork.
diff --git a/src/ConsoleApplication/stylecop.json b/src/ConsoleApplication/stylecop.json
diff --git a/src/System.Net.IPNetwork/BigIntegerExtensions.cs b/src/System.Net.IPNetwork/BigIntegerExtensions.cs
@@ -5,8 +5,8 @@
 namespace System.Net;
 
 using System;
-using Numerics;
-using Text;
+using System.Numerics;
+using System.Text;
 
 /// <summary>
 /// Extension methods to convert <see cref="System.Numerics.BigInteger"/>
diff --git a/src/System.Net.IPNetwork/CidrClassFull.cs b/src/System.Net.IPNetwork/CidrClassFull.cs
@@ -4,7 +4,7 @@
 
 namespace System.Net;
 
-using Sockets;
+using System.Net.Sockets;
 
 /// <summary>
 /// Class <c>CidrClassFull</c> tries to guess CIDR in a ClassFull way.
diff --git a/src/System.Net.IPNetwork/CidrClassLess.cs b/src/System.Net.IPNetwork/CidrClassLess.cs
@@ -4,7 +4,7 @@
 
 namespace System.Net;
 
-using Sockets;
+using System.Net.Sockets;
 
 /// <summary>
 /// Try to guess a CIDR in a ClassLess way ie. ipv4 = 32, ipv6 = 128.
diff --git a/src/System.Net.IPNetwork/IPAddressCollection.cs b/src/System.Net.IPNetwork/IPAddressCollection.cs
@@ -4,9 +4,9 @@
 
 namespace System.Net;
 
-using Collections;
-using Collections.Generic;
-using Numerics;
+using System.Collections;
+using System.Collections.Generic;
+using System.Numerics;
 
 /// <summary>
 /// Represents different filters for a collection of items.
@@ -45,8 +45,6 @@ internal IPAddressCollection(IPNetwork2 ipnetwork, FilterEnum filter)
         this.Reset();
     }
 
-    #region Count, Array, Enumerator
-
     /// <summary>
     /// Gets the count of IP addresses within the network.
     /// </summary>
@@ -100,10 +98,6 @@ public IPAddress this[BigInteger i]
         }
     }
 
-    #endregion
-
-    #region Legacy Enumeration
-
     /// <summary>
     /// Gets the current <see cref="IPAddress"/> from the collection.
     /// </summary>
@@ -149,10 +143,6 @@ public void Dispose()
         // nothing to dispose
     }
 
-    #endregion
-
-    #region Enumeration
-
     /// <inheritdoc/>
     IEnumerator<IPAddress> IEnumerable<IPAddress>.GetEnumerator()
     {
@@ -213,6 +203,4 @@ public Enumerator(IPAddressCollection collection)
             this.enumerator = -1;
         }
     }
-
-    #endregion
 }
diff --git a/src/System.Net.IPNetwork/IPNetwork2.cs b/src/System.Net.IPNetwork/IPNetwork2.cs
@@ -4,7 +4,7 @@
 
 namespace System.Net;
 
-using Runtime.Serialization;
+using System.Runtime.Serialization;
 
 /// <summary>
 /// IP Network utility class.
diff --git a/src/System.Net.IPNetwork/IPNetwork2BitsSet.cs b/src/System.Net.IPNetwork/IPNetwork2BitsSet.cs
@@ -4,8 +4,8 @@
 
 namespace System.Net;
 
-using Sockets;
-using Numerics;
+using System.Net.Sockets;
+using System.Numerics;
 
 /// <summary>
 /// BitSet.
diff --git a/src/System.Net.IPNetwork/IPNetwork2Contains.cs b/src/System.Net.IPNetwork/IPNetwork2Contains.cs
@@ -4,8 +4,8 @@
 
 namespace System.Net;
 
-using Sockets;
-using Numerics;
+using System.Net.Sockets;
+using System.Numerics;
 
 /// <summary>
 /// Contains.
diff --git a/src/System.Net.IPNetwork/IPNetwork2Ctor.cs b/src/System.Net.IPNetwork/IPNetwork2Ctor.cs
@@ -4,8 +4,8 @@
 
 namespace System.Net;
 
-using Sockets;
-using Numerics;
+using System.Net.Sockets;
+using System.Numerics;
 
 /// <summary>
 /// The constructors of IPNetwork2.
diff --git a/src/System.Net.IPNetwork/IPNetwork2ISerializable.cs b/src/System.Net.IPNetwork/IPNetwork2ISerializable.cs
@@ -4,9 +4,7 @@
 
 namespace System.Net;
 
-using Sockets;
-using Numerics;
-using Runtime.Serialization;
+using System.Runtime.Serialization;
 
 /// <summary>
 /// ISerializable.
diff --git a/src/System.Net.IPNetwork/IPNetwork2InternalParse.cs b/src/System.Net.IPNetwork/IPNetwork2InternalParse.cs
@@ -4,7 +4,7 @@
 
 namespace System.Net;
 
-using Text.RegularExpressions;
+using System.Text.RegularExpressions;
 
 /// <summary>
 /// The InternalParse methodes.
diff --git a/src/System.Net.IPNetwork/IPNetwork2Members.cs b/src/System.Net.IPNetwork/IPNetwork2Members.cs
@@ -4,9 +4,9 @@
 
 namespace System.Net;
 
-using Sockets;
-using Numerics;
-using Runtime.Serialization;
+using System.Numerics;
+using System.Net.Sockets;
+using System.Runtime.Serialization;
 
 /// <summary>
 /// Properties and members of IPNetwork2.
diff --git a/src/System.Net.IPNetwork/IPNetwork2Print.cs b/src/System.Net.IPNetwork/IPNetwork2Print.cs
@@ -4,7 +4,7 @@
 
 namespace System.Net;
 
-using IO;
+using System.IO;
 
 /// <summary>
 /// Print.
diff --git a/src/System.Net.IPNetwork/IPNetwork2Supernet.cs b/src/System.Net.IPNetwork/IPNetwork2Supernet.cs
@@ -4,7 +4,7 @@
 
 namespace System.Net;
 
-using Numerics;
+using System.Numerics;
 
 /// <summary>
 /// supernet.
diff --git a/src/System.Net.IPNetwork/IPNetwork2SupernetArray.cs b/src/System.Net.IPNetwork/IPNetwork2SupernetArray.cs
@@ -4,7 +4,7 @@
 
 namespace System.Net;
 
-using Collections.Generic;
+using System.Collections.Generic;
 
 /// <summary>
 /// SupernetArray.
diff --git a/src/System.Net.IPNetwork/IPNetwork2ToCidr.cs b/src/System.Net.IPNetwork/IPNetwork2ToCidr.cs
@@ -4,8 +4,8 @@
 
 namespace System.Net;
 
-using Sockets;
-using Numerics;
+using System.Net.Sockets;
+using System.Numerics;
 
 /// <summary>
 /// ToCidr.
diff --git a/src/System.Net.IPNetwork/IPNetwork2ToIPAddress.cs b/src/System.Net.IPNetwork/IPNetwork2ToIPAddress.cs
@@ -4,8 +4,8 @@
 
 namespace System.Net;
 
-using Sockets;
-using Numerics;
+using System.Net.Sockets;
+using System.Numerics;
 
 /// <summary>
 /// ToIPAddress.
diff --git a/src/System.Net.IPNetwork/IPNetwork2ToNetmask.cs b/src/System.Net.IPNetwork/IPNetwork2ToNetmask.cs
@@ -4,8 +4,8 @@
 
 namespace System.Net;
 
-using Sockets;
-using Numerics;
+using System.Net.Sockets;
+using System.Numerics;
 
 /// <summary>
 /// ToNetmask.
diff --git a/src/System.Net.IPNetwork/IPNetwork2ToUint.cs b/src/System.Net.IPNetwork/IPNetwork2ToUint.cs
@@ -4,8 +4,8 @@
 
 namespace System.Net;
 
-using Sockets;
-using Numerics;
+using System.Net.Sockets;
+using System.Numerics;
 
 /// <summary>
 /// ToUint.
diff --git a/src/System.Net.IPNetwork/IPNetwork2TryGuessCidr.cs b/src/System.Net.IPNetwork/IPNetwork2TryGuessCidr.cs
@@ -4,7 +4,7 @@
 
 namespace System.Net;
 
-using Sockets;
+using System.Net.Sockets;
 
 /// <summary>
 /// TryGuessCidr.
diff --git a/src/System.Net.IPNetwork/IPNetwork2ValidNetmask.cs b/src/System.Net.IPNetwork/IPNetwork2ValidNetmask.cs
@@ -4,8 +4,8 @@
 
 namespace System.Net;
 
-using Sockets;
-using Numerics;
+using System.Net.Sockets;
+using System.Numerics;
 
 /// <summary>
 /// ValidNetmask.
diff --git a/src/System.Net.IPNetwork/IPNetwork2WideSubnet.cs b/src/System.Net.IPNetwork/IPNetwork2WideSubnet.cs
@@ -4,8 +4,8 @@
 
 namespace System.Net;
 
-using Sockets;
-using Numerics;
+using System.Net.Sockets;
+using System.Numerics;
 
 /// <summary>
 /// WideSubnet.
diff --git a/src/System.Net.IPNetwork/IPNetwork2WildcardMask.cs b/src/System.Net.IPNetwork/IPNetwork2WildcardMask.cs
@@ -4,8 +4,8 @@
 
 namespace System.Net;
 
-using Numerics;
-using Sockets;
+using System.Numerics;
+using System.Net.Sockets;
 
 /// <summary>
 /// WildcardNetmask.
diff --git a/src/System.Net.IPNetwork/IPNetwork2XmlSerialization.cs b/src/System.Net.IPNetwork/IPNetwork2XmlSerialization.cs
@@ -4,7 +4,7 @@
 
 namespace System.Net;
 
-using Sockets;
+using System.Net.Sockets;
 
 /// <summary>
 /// Serialization.
diff --git a/src/System.Net.IPNetwork/IPNetwork2overlap.cs b/src/System.Net.IPNetwork/IPNetwork2overlap.cs
@@ -4,7 +4,7 @@
 
 namespace System.Net;
 
-using Numerics;
+using System.Numerics;
 
 /// <summary>
 /// Overlap.
diff --git a/src/System.Net.IPNetwork/IPNetworkCollection.cs b/src/System.Net.IPNetwork/IPNetworkCollection.cs
diff --git a/src/System.Net.IPNetwork/System.Net.IPNetwork.csproj b/src/System.Net.IPNetwork/System.Net.IPNetwork.csproj
diff --git a/src/System.Net.IPNetwork/stylecop.json b/src/System.Net.IPNetwork/stylecop.json
diff --git a/src/TestProject/CidrClassLessUnitTest.cs b/src/TestProject/CidrClassLessUnitTest.cs
diff --git a/src/TestProject/ConsoleUnitTest.cs b/src/TestProject/ConsoleUnitTest.cs
diff --git a/src/TestProject/EqualsUnitTest.cs b/src/TestProject/EqualsUnitTest.cs
diff --git a/src/TestProject/GetHashCodeUnitTest.cs b/src/TestProject/GetHashCodeUnitTest.cs
diff --git a/src/TestProject/IPAddressCollectionUnitTest.cs b/src/TestProject/IPAddressCollectionUnitTest.cs
diff --git a/src/TestProject/IPNetworkV6/IPNetworkV6ParseTests.cs b/src/TestProject/IPNetworkV6/IPNetworkV6ParseTests.cs
diff --git a/src/TestProject/TestProject.csproj b/src/TestProject/TestProject.csproj
diff --git a/src/TestProject/TryParseUnitTest.cs b/src/TestProject/TryParseUnitTest.cs
diff --git a/src/TestProject/stylecop.json b/src/TestProject/stylecop.json

Original file line number	Diff line number	Diff line change
`@@ -4,9 +4,9 @@`
`4`	`4`
`5`	`5`	`namespace System.Net;`
`6`	`6`
`7`		`-using Collections;`
`8`		`-using Collections.Generic;`
`9`		`-using Numerics;`
	`7`	`+using System.Collections;`
	`8`	`+using System.Collections.Generic;`
	`9`	`+using System.Numerics;`
`10`	`10`
`11`	`11`	`/// <summary>`
`12`	`12`	`/// Represents different filters for a collection of items.`
`@@ -45,8 +45,6 @@ internal IPAddressCollection(IPNetwork2 ipnetwork, FilterEnum filter)`
`45`	`45`	`this.Reset();`
`46`	`46`	`}`
`47`	`47`
`48`		`- #region Count, Array, Enumerator`
`49`		`-`
`50`	`48`	`/// <summary>`
`51`	`49`	`/// Gets the count of IP addresses within the network.`
`52`	`50`	`/// </summary>`
`@@ -100,10 +98,6 @@ public IPAddress this[BigInteger i]`
`100`	`98`	`}`
`101`	`99`	`}`
`102`	`100`
`103`		`- #endregion`
`104`		`-`
`105`		`- #region Legacy Enumeration`
`106`		`-`
`107`	`101`	`/// <summary>`
`108`	`102`	`/// Gets the current <see cref="IPAddress"/> from the collection.`
`109`	`103`	`/// </summary>`
`@@ -149,10 +143,6 @@ public void Dispose()`
`149`	`143`	`// nothing to dispose`
`150`	`144`	`}`
`151`	`145`
`152`		`- #endregion`
`153`		`-`
`154`		`- #region Enumeration`
`155`		`-`
`156`	`146`	`/// <inheritdoc/>`
`157`	`147`	`IEnumerator<IPAddress> IEnumerable<IPAddress>.GetEnumerator()`
`158`	`148`	`{`
`@@ -213,6 +203,4 @@ public Enumerator(IPAddressCollection collection)`
`213`	`203`	`this.enumerator = -1;`
`214`	`204`	`}`
`215`	`205`	`}`
`216`		`-`
`217`		`- #endregion`
`218`	`206`	`}`